All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harinik@xilinx.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
	linux-kernel@vger.kernel.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"David S . Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read
Date: Sat, 9 Mar 2019 17:19:12 +0100	[thread overview]
Message-ID: <20190309161912.GD9000@lunn.ch> (raw)
In-Reply-To: <CAFcVECKU7zD2ms76GH-mF2GxCtNr4RQ+2=jN_xppueQsUSq2wg@mail.gmail.com>

> Related to this, I have a query on how the DT node for gmii2rgmii should look.
> One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use
> this piece of code to register this mdiobus:
> + mdio_np = of_get_child_by_name(np, "mdio");
> + if (mdio_np) {
> + of_node_put(mdio_np);
> + err = of_mdiobus_register(bp->mii_bus, mdio_np);
> + if (err)
> + goto err_out_unregister_bus;
> 
> And the DT node looks like this:
> ethernet {
>     phy-mode = "gmii";
>     phy-handle = <&extphy>;
> 
>     mdio {
>         extphy {
>             reg = <x>;
>         };
>         gmii_to_rgmii{
>             compatible = "xlnx,gmii-to-rgmii-1.0";
>             phy-handle = <&extphy>;
>             reg = <x>;
>         };
>     };
> };

Hi Harini

You have this setup:
  
MAC <==> GMII2RGMII <==> RGMII_PHY

So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'.

Feel free to submit a patch extending
Documentation/devicetree/bindings/net/xilinx_gmii2rgmii.txt to include
a MAC node, etc.

   Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Harini Katakam <harinik@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read
Date: Sat, 9 Mar 2019 17:19:12 +0100	[thread overview]
Message-ID: <20190309161912.GD9000@lunn.ch> (raw)
In-Reply-To: <CAFcVECKU7zD2ms76GH-mF2GxCtNr4RQ+2=jN_xppueQsUSq2wg@mail.gmail.com>

> Related to this, I have a query on how the DT node for gmii2rgmii should look.
> One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use
> this piece of code to register this mdiobus:
> + mdio_np = of_get_child_by_name(np, "mdio");
> + if (mdio_np) {
> + of_node_put(mdio_np);
> + err = of_mdiobus_register(bp->mii_bus, mdio_np);
> + if (err)
> + goto err_out_unregister_bus;
> 
> And the DT node looks like this:
> ethernet {
>     phy-mode = "gmii";
>     phy-handle = <&extphy>;
> 
>     mdio {
>         extphy {
>             reg = <x>;
>         };
>         gmii_to_rgmii{
>             compatible = "xlnx,gmii-to-rgmii-1.0";
>             phy-handle = <&extphy>;
>             reg = <x>;
>         };
>     };
> };

Hi Harini

You have this setup:
  
MAC <==> GMII2RGMII <==> RGMII_PHY

So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'.

Feel free to submit a patch extending
Documentation/devicetree/bindings/net/xilinx_gmii2rgmii.txt to include
a MAC node, etc.

   Andrew

  reply	other threads:[~2019-03-09 16:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 16:32 [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Paul Kocialkowski
2019-02-15 16:32 ` Paul Kocialkowski
2019-02-15 17:02 ` Andrew Lunn
2019-02-15 17:02   ` Andrew Lunn
2019-02-15 17:38 ` Florian Fainelli
2019-02-15 17:38   ` Florian Fainelli
2019-02-15 18:34   ` Paul Kocialkowski
2019-02-15 18:34     ` Paul Kocialkowski
2019-02-15 18:53     ` Florian Fainelli
2019-02-15 18:53       ` Florian Fainelli
2019-02-19  9:56       ` Paul Kocialkowski
2019-02-19  9:56         ` Paul Kocialkowski
2019-02-19 17:25         ` Andrew Lunn
2019-02-19 17:25           ` Andrew Lunn
2019-02-20  6:58           ` Michal Simek
2019-02-20  6:58             ` Michal Simek
2019-02-21 10:24             ` Paul Kocialkowski
2019-02-21 10:24               ` Paul Kocialkowski
2019-02-21 11:03               ` Michal Simek
2019-02-21 11:03                 ` Michal Simek
2019-02-27  8:43                 ` Michal Simek
2019-02-27  8:43                   ` Michal Simek
2019-02-27  9:05                   ` Harini Katakam
2019-02-27  9:05                     ` Harini Katakam
2019-02-28  7:33                     ` Harini Katakam
2019-02-28  7:33                       ` Harini Katakam
2019-03-09 12:09                       ` Harini Katakam
2019-03-09 12:09                         ` Harini Katakam
2019-03-09 16:19                         ` Andrew Lunn [this message]
2019-03-09 16:19                           ` Andrew Lunn
2019-03-11  6:04                           ` Harini Katakam
2019-03-11  6:04                             ` Harini Katakam
2019-03-11 12:27                             ` Harini Katakam
2019-03-11 12:27                               ` Harini Katakam
2019-03-11 12:51                               ` Michal Simek
2019-03-11 12:51                                 ` Michal Simek
2019-03-11  6:45                           ` Michal Simek
2019-03-11  6:45                             ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190309161912.GD9000@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=harinik@xilinx.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.