Re: [PATCH] target:tcmu:add '\n' when return user space

[David Disseldorp <ddiss@suse.de>]

Hi,

On Sun, 10 Mar 2019 22:07:53 +0800, tangwenji wrote:

> In function tcmu_get_global_max_data_area return string should include '\n'.

Why? Please describe the motivation for your changes.

> Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
> ---
>  drivers/target/target_core_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 5831e0e..50229c1 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -244,7 +244,7 @@ static int tcmu_set_global_max_data_area(const char *str,
>  static int tcmu_get_global_max_data_area(char *buffer,
>  					 const struct kernel_param *kp)
>  {
> -	return sprintf(buffer, "%d", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
> +	return sprintf(buffer, "%d\n", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));

Although minor, this is still a modification to a released API so
probably can't be done without potentially breaking user-space.

Cheers, David