From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target:tcmu:add '\n' when return user space
Date: Mon, 11 Mar 2019 16:48:05 +0000 [thread overview]
Message-ID: <20190311174805.1c428705@linux-6o2u> (raw)
On Mon, 11 Mar 2019 11:15:53 -0500, Mike Christie wrote:
> >> Although minor, this is still a modification to a released API so
> >> probably can't be done without potentially breaking user-space.
> >>
> >
> > I think the lack of newline is breaking some tools, because they were
> > looking for newlines due to the other files having it.
> >
>
> I guess that does not make sense. It will be easier to update userspace
> and we would have to carry the userspcae patch for older kernels, so the
> patch is not needed.
Agreed. After getting burnt by 6baca7601bde I'm hesitant to make any
changes to existing configFS attributes.
Cheers, David
next reply other threads:[~2019-03-11 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 16:48 David Disseldorp [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-11 16:15 [PATCH] target:tcmu:add '\n' when return user space Mike Christie
2019-03-11 16:05 Mike Christie
2019-03-11 16:03 Mike Christie
2019-03-10 14:41 David Disseldorp
2019-03-10 14:07 tangwenji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311174805.1c428705@linux-6o2u \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.