From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target:tcmu:add '\n' when return user space
Date: Mon, 11 Mar 2019 16:03:01 +0000 [thread overview]
Message-ID: <5C8686B5.3070502@redhat.com> (raw)
On 03/10/2019 09:07 AM, tangwenji wrote:
> From: tangwenji <tang.wenji@zte.com.cn>
>
> In function tcmu_get_global_max_data_area return string should include '\n'.
>
> Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
> ---
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 5831e0e..50229c1 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -244,7 +244,7 @@ static int tcmu_set_global_max_data_area(const char *str,
> static int tcmu_get_global_max_data_area(char *buffer,
> const struct kernel_param *kp)
> {
> - return sprintf(buffer, "%d", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
> + return sprintf(buffer, "%d\n", TCMU_BLOCKS_TO_MBS(tcmu_global_max_blocks));
> }
>
> static const struct kernel_param_ops tcmu_global_max_data_area_op = {
>
Acked-by: Mike Christie <mchristi@redhat.com>
next reply other threads:[~2019-03-11 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 16:03 Mike Christie [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-11 16:48 [PATCH] target:tcmu:add '\n' when return user space David Disseldorp
2019-03-11 16:15 Mike Christie
2019-03-11 16:05 Mike Christie
2019-03-10 14:41 David Disseldorp
2019-03-10 14:07 tangwenji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C8686B5.3070502@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.