All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Dante Paz <dante.paz@gmail.com>
Cc: devel@driverdev.osuosl.org, Dante Paz <dpaz@unc.edu.ar>,
	linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
	leobras.c@gmail.com, gregkh@linuxfoundation.org,
	dri-devel@lists.freedesktop.org, renatoys08@gmail.com
Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems
Date: Mon, 11 Mar 2019 16:25:27 +0000	[thread overview]
Message-ID: <20190311162527.GA20652@ravnborg.org> (raw)
In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com>

Hi Dante

Thanks for the patch.
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote:
> From: Dante Paz <dpaz@unc.edu.ar>
> 
>     Style and coding function issues were corrected, by avoiding macro functions with a conflicting coding style.
>     Signed-off-by: Dante Paz <dpaz@unc.edu.ar>

But it raised a few comments.

The staging/fbtft is a dumping of a set of drivers that
in the end will be migrated to DRM.
And there is not much gained trying to do coding style changes to these
drivers.
So please conmsider finding a drver where this is more relevant.

Furthermore that patch presented is hard to review as it contains
too much changes in one go.
As a rule of thumb include only one type of change per patch.
This is worth to keep in mind for future submissions.

It it then also good to present the trivial changes first(*), and the
less trivial changes later.

(*) Like whitespace to tabs, spellign errors etc.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Dante Paz <dante.paz@gmail.com>
Cc: devel@driverdev.osuosl.org, Dante Paz <dpaz@unc.edu.ar>,
	linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
	leobras.c@gmail.com, gregkh@linuxfoundation.org,
	dri-devel@lists.freedesktop.org, renatoys08@gmail.com
Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems
Date: Mon, 11 Mar 2019 17:25:27 +0100	[thread overview]
Message-ID: <20190311162527.GA20652@ravnborg.org> (raw)
In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com>

Hi Dante

Thanks for the patch.
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote:
> From: Dante Paz <dpaz@unc.edu.ar>
> 
>     Style and coding function issues were corrected, by avoiding macro functions with a conflicting coding style.
>     Signed-off-by: Dante Paz <dpaz@unc.edu.ar>

But it raised a few comments.

The staging/fbtft is a dumping of a set of drivers that
in the end will be migrated to DRM.
And there is not much gained trying to do coding style changes to these
drivers.
So please conmsider finding a drver where this is more relevant.

Furthermore that patch presented is hard to review as it contains
too much changes in one go.
As a rule of thumb include only one type of change per patch.
This is worth to keep in mind for future submissions.

It it then also good to present the trivial changes first(*), and the
less trivial changes later.

(*) Like whitespace to tabs, spellign errors etc.

	Sam

  parent reply	other threads:[~2019-03-11 16:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 21:48 [PATCH] FBTFT: fbtft-bus: Fix code style problems Dante Paz
2019-03-09 21:48 ` Dante Paz
2019-03-11  8:11 ` Dan Carpenter
2019-03-11  8:11   ` Dan Carpenter
2019-03-11  8:18 ` Dan Carpenter
2019-03-11  8:18   ` Dan Carpenter
2019-03-11 14:06   ` DANTE JAVIER PAZ
2019-03-11 16:25 ` Sam Ravnborg [this message]
2019-03-11 16:25   ` Sam Ravnborg
2019-03-11 20:32   ` DANTE JAVIER PAZ
2019-03-11 20:32     ` DANTE JAVIER PAZ
2019-03-11 21:15     ` Ezequiel Garcia
2019-03-11 21:15       ` Ezequiel Garcia
2019-03-11 21:40       ` Sam Ravnborg
2019-03-11 21:40         ` Sam Ravnborg
2019-03-11 21:43         ` Ezequiel Garcia
2019-03-11 21:43           ` Ezequiel Garcia
2019-03-11 21:42     ` Sam Ravnborg
2019-03-11 21:42       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311162527.GA20652@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dante.paz@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dpaz@unc.edu.ar \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=leobras.c@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    --cc=renatoys08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.