All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: DANTE JAVIER PAZ <dpaz@unc.edu.ar>
Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com,
	linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
	gregkh@linuxfoundation.org, Dante Paz <dante.paz@gmail.com>,
	dri-devel@lists.freedesktop.org, renatoys08@gmail.com
Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems
Date: Mon, 11 Mar 2019 21:42:04 +0000	[thread overview]
Message-ID: <20190311214204.GA24416@ravnborg.org> (raw)
In-Reply-To: <CAJdeGOTPLoSwQ9hb7Tk_cZ+VmT-xvEtGU_pbSUXoxcB20d3rcw@mail.gmail.com>

Hi Dante.

> Hello Sam, thank you very much for your comments,
> As I told Dan (my email did not reach the mailing list) this is my
> first attempt to contribute,
> So I'm learning a lot from your advice and corrections.
> 
> I will look for TODO lists to see if there are more useful
> contributions to make, all suggestions are also welcome.

Keep the good spirit, and find some other driver to look into.

You must realise than experienced developers sometimes goes
through several version before a patch is ready.
So expect it to be a bumpy ride the first few times.

Good luck!
	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: DANTE JAVIER PAZ <dpaz@unc.edu.ar>
Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com,
	linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com,
	gregkh@linuxfoundation.org, Dante Paz <dante.paz@gmail.com>,
	dri-devel@lists.freedesktop.org, renatoys08@gmail.com
Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems
Date: Mon, 11 Mar 2019 22:42:04 +0100	[thread overview]
Message-ID: <20190311214204.GA24416@ravnborg.org> (raw)
In-Reply-To: <CAJdeGOTPLoSwQ9hb7Tk_cZ+VmT-xvEtGU_pbSUXoxcB20d3rcw@mail.gmail.com>

Hi Dante.

> Hello Sam, thank you very much for your comments,
> As I told Dan (my email did not reach the mailing list) this is my
> first attempt to contribute,
> So I'm learning a lot from your advice and corrections.
> 
> I will look for TODO lists to see if there are more useful
> contributions to make, all suggestions are also welcome.

Keep the good spirit, and find some other driver to look into.

You must realise than experienced developers sometimes goes
through several version before a patch is ready.
So expect it to be a bumpy ride the first few times.

Good luck!
	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-03-11 21:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 21:48 [PATCH] FBTFT: fbtft-bus: Fix code style problems Dante Paz
2019-03-09 21:48 ` Dante Paz
2019-03-11  8:11 ` Dan Carpenter
2019-03-11  8:11   ` Dan Carpenter
2019-03-11  8:18 ` Dan Carpenter
2019-03-11  8:18   ` Dan Carpenter
2019-03-11 14:06   ` DANTE JAVIER PAZ
2019-03-11 16:25 ` Sam Ravnborg
2019-03-11 16:25   ` Sam Ravnborg
2019-03-11 20:32   ` DANTE JAVIER PAZ
2019-03-11 20:32     ` DANTE JAVIER PAZ
2019-03-11 21:15     ` Ezequiel Garcia
2019-03-11 21:15       ` Ezequiel Garcia
2019-03-11 21:40       ` Sam Ravnborg
2019-03-11 21:40         ` Sam Ravnborg
2019-03-11 21:43         ` Ezequiel Garcia
2019-03-11 21:43           ` Ezequiel Garcia
2019-03-11 21:42     ` Sam Ravnborg [this message]
2019-03-11 21:42       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311214204.GA24416@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dante.paz@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dpaz@unc.edu.ar \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=leobras.c@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    --cc=renatoys08@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.