From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: "will.deacon@arm.com" <will.deacon@arm.com>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
vkuznets <vkuznets@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Subject: Re: [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver
Date: Tue, 12 Mar 2019 15:01:02 -0700 [thread overview]
Message-ID: <20190312220102.GA17164@kroah.com> (raw)
In-Reply-To: <DM5PR2101MB091877CF62AD20D07D82F452D7490@DM5PR2101MB0918.namprd21.prod.outlook.com>
On Tue, Mar 12, 2019 at 09:53:28PM +0000, Michael Kelley wrote:
> From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> Sent: Tuesday, March 12, 2019 2:47 PM
> > >
> > > Michael Kelley (2):
> > > Drivers: hv: Move Hyper-V clockevents code to new clocksource driver
> > > Drivers: hv: Move Hyper-V clocksource code to new clocksource driver
> >
> > You have two different patches that do different things, yet have the
> > same identical shortlog text :(
> >
> > That's not ok, and something that I reject for trivial patches, it
> > should never happen for a "real" patch as you don't do the same thing in
> > both of these patches.
>
> Hmmm. Not identical. The first patch is "clockevents" code, and the second
> patch is "clocksource" code.
Wow, that's not obvious at all, sorry. You still might want to make it
a bit more different :)
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
vkuznets <vkuznets@redhat.com>, KY Srinivasan <kys@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver
Date: Tue, 12 Mar 2019 15:01:02 -0700 [thread overview]
Message-ID: <20190312220102.GA17164@kroah.com> (raw)
In-Reply-To: <DM5PR2101MB091877CF62AD20D07D82F452D7490@DM5PR2101MB0918.namprd21.prod.outlook.com>
On Tue, Mar 12, 2019 at 09:53:28PM +0000, Michael Kelley wrote:
> From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> Sent: Tuesday, March 12, 2019 2:47 PM
> > >
> > > Michael Kelley (2):
> > > Drivers: hv: Move Hyper-V clockevents code to new clocksource driver
> > > Drivers: hv: Move Hyper-V clocksource code to new clocksource driver
> >
> > You have two different patches that do different things, yet have the
> > same identical shortlog text :(
> >
> > That's not ok, and something that I reject for trivial patches, it
> > should never happen for a "real" patch as you don't do the same thing in
> > both of these patches.
>
> Hmmm. Not identical. The first patch is "clockevents" code, and the second
> patch is "clocksource" code.
Wow, that's not obvious at all, sorry. You still might want to make it
a bit more different :)
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-12 22:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 21:42 [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver Michael Kelley
2019-03-12 21:42 ` Michael Kelley
2019-03-12 21:42 ` [PATCH 1/2] Drivers: hv: Move Hyper-V clockevents code to new " Michael Kelley
2019-03-12 21:42 ` Michael Kelley
2019-03-13 8:28 ` Vitaly Kuznetsov
2019-03-13 8:28 ` Vitaly Kuznetsov
2019-03-13 13:38 ` Michael Kelley
2019-03-13 13:38 ` Michael Kelley
2019-03-13 14:23 ` Vitaly Kuznetsov
2019-03-13 14:23 ` Vitaly Kuznetsov
2019-03-13 16:19 ` Michael Kelley
2019-03-13 16:19 ` Michael Kelley
2019-03-13 17:17 ` Vitaly Kuznetsov
2019-03-13 17:17 ` Vitaly Kuznetsov
2019-03-12 21:42 ` [PATCH 2/2] Drivers: hv: Move Hyper-V clocksource " Michael Kelley
2019-03-12 21:42 ` Michael Kelley
2019-03-12 21:46 ` [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate " gregkh
2019-03-12 21:46 ` gregkh
2019-03-12 21:53 ` Michael Kelley
2019-03-12 21:53 ` Michael Kelley
2019-03-12 22:01 ` gregkh [this message]
2019-03-12 22:01 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312220102.GA17164@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=catalin.marinas@arm.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=marcelo.cerri@canonical.com \
--cc=mark.rutland@arm.com \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sunilmut@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.