From: Dan Carpenter <dan.carpenter@oracle.com>
To: Armando Miraglia <arma2ff0@gmail.com>, Jean Delvare <jdelvare@suse.de>
Cc: devel@driverdev.osuosl.org, sankalpnegi2310@gmail.com,
linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
linux-mediatek@lists.infradead.org, gregkh@linuxfoundation.org,
neil@brown.name, sr@denx.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 14:27:32 +0300 [thread overview]
Message-ID: <20190314112732.GJ2227@kadam> (raw)
In-Reply-To: <20190314111313.GB8034@google.com>
On Thu, Mar 14, 2019 at 12:13:15PM +0100, Armando Miraglia wrote:
> My answers are in-line below. BTW bare with me as this is my attempt to get my
> feet wet in how to contribute to the linux kernel for my own pleasure and
> interest :)
>
No problem at all.
> Is there an explicit intent to deprecate Lindent in favor of checkpatch.pl
> --fix? If one would like to contribute to fixing the tooling for linting which
> of the two would be the right target for such an effort?
>
I've added Jean to the CC list because he worked on Lindent a few
years ago. I really think we should just delete Lindent. I haven't
used the checkpatch.pl --fix option but Joe Perches has good style.
> > > static inline struct mt7621_spi *spidev_to_mt7621_spi(struct spi_device *spi)
> > > @@ -303,7 +303,7 @@ static int mt7621_spi_setup(struct spi_device *spi)
> > > struct mt7621_spi *rs = spidev_to_mt7621_spi(spi);
> > >
> > > if ((spi->max_speed_hz == 0) ||
> > > - (spi->max_speed_hz > (rs->sys_freq / 2)))
> > > + (spi->max_speed_hz > (rs->sys_freq / 2)))
> >
> > Yeah. Lindent is correct here.
>
> Funny enough, this is something I adjusted manually :)
>
:) Good.
> I have a process question here: to post a change for the only accepted change I
> have in this patch should I send out a new patch?
>
Yeah. If you want. Google for how to send a v2 patch.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Armando Miraglia <arma2ff0@gmail.com>, Jean Delvare <jdelvare@suse.de>
Cc: devel@driverdev.osuosl.org, sankalpnegi2310@gmail.com,
linux-kernel@vger.kernel.org, matthias.bgg@gmail.com,
linux-mediatek@lists.infradead.org, gregkh@linuxfoundation.org,
neil@brown.name, sr@denx.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 14:27:32 +0300 [thread overview]
Message-ID: <20190314112732.GJ2227@kadam> (raw)
In-Reply-To: <20190314111313.GB8034@google.com>
On Thu, Mar 14, 2019 at 12:13:15PM +0100, Armando Miraglia wrote:
> My answers are in-line below. BTW bare with me as this is my attempt to get my
> feet wet in how to contribute to the linux kernel for my own pleasure and
> interest :)
>
No problem at all.
> Is there an explicit intent to deprecate Lindent in favor of checkpatch.pl
> --fix? If one would like to contribute to fixing the tooling for linting which
> of the two would be the right target for such an effort?
>
I've added Jean to the CC list because he worked on Lindent a few
years ago. I really think we should just delete Lindent. I haven't
used the checkpatch.pl --fix option but Joe Perches has good style.
> > > static inline struct mt7621_spi *spidev_to_mt7621_spi(struct spi_device *spi)
> > > @@ -303,7 +303,7 @@ static int mt7621_spi_setup(struct spi_device *spi)
> > > struct mt7621_spi *rs = spidev_to_mt7621_spi(spi);
> > >
> > > if ((spi->max_speed_hz == 0) ||
> > > - (spi->max_speed_hz > (rs->sys_freq / 2)))
> > > + (spi->max_speed_hz > (rs->sys_freq / 2)))
> >
> > Yeah. Lindent is correct here.
>
> Funny enough, this is something I adjusted manually :)
>
:) Good.
> I have a process question here: to post a change for the only accepted change I
> have in this patch should I send out a new patch?
>
Yeah. If you want. Google for how to send a v2 patch.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Armando Miraglia <arma2ff0@gmail.com>, Jean Delvare <jdelvare@suse.de>
Cc: neil@brown.name, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, sankalpnegi2310@gmail.com,
matthias.bgg@gmail.com, sr@denx.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 14:27:32 +0300 [thread overview]
Message-ID: <20190314112732.GJ2227@kadam> (raw)
In-Reply-To: <20190314111313.GB8034@google.com>
On Thu, Mar 14, 2019 at 12:13:15PM +0100, Armando Miraglia wrote:
> My answers are in-line below. BTW bare with me as this is my attempt to get my
> feet wet in how to contribute to the linux kernel for my own pleasure and
> interest :)
>
No problem at all.
> Is there an explicit intent to deprecate Lindent in favor of checkpatch.pl
> --fix? If one would like to contribute to fixing the tooling for linting which
> of the two would be the right target for such an effort?
>
I've added Jean to the CC list because he worked on Lindent a few
years ago. I really think we should just delete Lindent. I haven't
used the checkpatch.pl --fix option but Joe Perches has good style.
> > > static inline struct mt7621_spi *spidev_to_mt7621_spi(struct spi_device *spi)
> > > @@ -303,7 +303,7 @@ static int mt7621_spi_setup(struct spi_device *spi)
> > > struct mt7621_spi *rs = spidev_to_mt7621_spi(spi);
> > >
> > > if ((spi->max_speed_hz == 0) ||
> > > - (spi->max_speed_hz > (rs->sys_freq / 2)))
> > > + (spi->max_speed_hz > (rs->sys_freq / 2)))
> >
> > Yeah. Lindent is correct here.
>
> Funny enough, this is something I adjusted manually :)
>
:) Good.
> I have a process question here: to post a change for the only accepted change I
> have in this patch should I send out a new patch?
>
Yeah. If you want. Google for how to send a v2 patch.
regards,
dan carpenter
next prev parent reply other threads:[~2019-03-14 11:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:24 [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c Armando Miraglia
2019-03-13 12:24 ` Armando Miraglia
2019-03-13 12:28 ` Matthias Brugger
2019-03-13 12:28 ` Matthias Brugger
2019-03-13 12:28 ` Matthias Brugger
2019-03-13 12:31 ` Armando Miraglia
2019-03-13 12:31 ` Armando Miraglia
2019-03-13 16:34 ` Chuanhong Guo
2019-03-13 16:34 ` Chuanhong Guo
2019-03-13 16:46 ` Matthias Brugger
2019-03-13 16:46 ` Matthias Brugger
2019-03-13 16:54 ` Stefan Roese
2019-03-13 16:54 ` Stefan Roese
2019-03-13 22:14 ` NeilBrown
2019-03-13 22:14 ` NeilBrown
2019-03-14 2:26 ` Chuanhong Guo
2019-03-14 2:26 ` Chuanhong Guo
2019-03-14 2:26 ` Chuanhong Guo
2019-03-14 2:36 ` NeilBrown
2019-03-14 2:36 ` NeilBrown
2019-03-13 12:34 ` Dan Carpenter
2019-03-13 12:34 ` Dan Carpenter
2019-03-13 12:34 ` Dan Carpenter
2019-03-13 16:47 ` Matthias Brugger
2019-03-13 16:47 ` Matthias Brugger
2019-03-14 11:13 ` Armando Miraglia
2019-03-14 11:13 ` Armando Miraglia
2019-03-14 11:27 ` Dan Carpenter [this message]
2019-03-14 11:27 ` Dan Carpenter
2019-03-14 11:27 ` Dan Carpenter
2019-03-14 14:07 ` Jean Delvare
2019-03-14 14:07 ` Jean Delvare
2019-03-14 20:50 ` Joe Perches
2019-03-14 20:50 ` Joe Perches
2019-03-14 11:36 ` Stefan Roese
2019-03-14 11:36 ` Stefan Roese
2019-03-14 11:37 ` Armando Miraglia
2019-03-14 11:37 ` Armando Miraglia
2019-03-14 13:14 ` Matthias Brugger
2019-03-14 13:14 ` Matthias Brugger
2019-03-14 13:14 ` Matthias Brugger
2019-03-14 13:24 ` Stefan Roese
2019-03-14 13:24 ` Stefan Roese
2019-03-14 17:01 ` Matthias Brugger
2019-03-14 17:01 ` Matthias Brugger
-- strict thread matches above, loose matches on Subject: below --
2019-03-13 11:57 Armando Miraglia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314112732.GJ2227@kadam \
--to=dan.carpenter@oracle.com \
--cc=arma2ff0@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.