All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: John Crispin <john@phrozen.org>, Stefan Roese <sr@denx.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Armando Miraglia <arma2ff0@gmail.com>,
	Armando Miraglia <armax@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sankalpnegi2310@gmail.com, devel@driverdev.osuosl.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 13:36:11 +1100	[thread overview]
Message-ID: <87mulyp4h0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAJsYDVKwJZmaLMkzYOeGnhnor7rXe21Xwvogx7aPfzfXOdqZAg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Thu, Mar 14 2019, Chuanhong Guo wrote:

> Hi!
> On Thu, Mar 14, 2019 at 6:14 AM NeilBrown <neil@brown.name> wrote:
>>
>> [...]
>> My only small concern is that this driver was backported to openwrt
>> (4.14 based) and then reverted
>>
>> https://github.com/openwrt/openwrt/commit/749a29f76ca780d8df70a5163d43bbdc6f13ba3f
>>
>>  "This breaks some mt7621 devices."
>>
>> Possibly it was backported badly, or possibly there is a problem.
> Last time I backported the version with broken SPI modes so it got
> broken SPI CS1 support. There is one mt7621 router using SPI CS1 in
> OpenWrt and the backported driver broke it.
> It has been fixed by my two "drop broken spi modes" patches.

Ahh, thanks for the clarification.  Good to know all known problems are
fixed.

Thanks,
NeilBrown


>>
>> John: do you have any more details of the problem other than what is in
>> the commit message?
>>
>> Thanks,
>> NeilBrown
>
> Regards,
> Chuanhong Guo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neil@brown.name>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: sankalpnegi2310@gmail.com, devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Armando Miraglia <arma2ff0@gmail.com>,
	Armando Miraglia <armax@google.com>,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Stefan Roese <sr@denx.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 13:36:11 +1100	[thread overview]
Message-ID: <87mulyp4h0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAJsYDVKwJZmaLMkzYOeGnhnor7rXe21Xwvogx7aPfzfXOdqZAg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 944 bytes --]

On Thu, Mar 14 2019, Chuanhong Guo wrote:

> Hi!
> On Thu, Mar 14, 2019 at 6:14 AM NeilBrown <neil@brown.name> wrote:
>>
>> [...]
>> My only small concern is that this driver was backported to openwrt
>> (4.14 based) and then reverted
>>
>> https://github.com/openwrt/openwrt/commit/749a29f76ca780d8df70a5163d43bbdc6f13ba3f
>>
>>  "This breaks some mt7621 devices."
>>
>> Possibly it was backported badly, or possibly there is a problem.
> Last time I backported the version with broken SPI modes so it got
> broken SPI CS1 support. There is one mt7621 router using SPI CS1 in
> OpenWrt and the backported driver broke it.
> It has been fixed by my two "drop broken spi modes" patches.

Ahh, thanks for the clarification.  Good to know all known problems are
fixed.

Thanks,
NeilBrown


>>
>> John: do you have any more details of the problem other than what is in
>> the commit message?
>>
>> Thanks,
>> NeilBrown
>
> Regards,
> Chuanhong Guo

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-14  2:36 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 12:24 [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c Armando Miraglia
2019-03-13 12:24 ` Armando Miraglia
2019-03-13 12:28 ` Matthias Brugger
2019-03-13 12:28   ` Matthias Brugger
2019-03-13 12:28   ` Matthias Brugger
2019-03-13 12:31   ` Armando Miraglia
2019-03-13 12:31     ` Armando Miraglia
2019-03-13 16:34   ` Chuanhong Guo
2019-03-13 16:34     ` Chuanhong Guo
2019-03-13 16:46     ` Matthias Brugger
2019-03-13 16:46       ` Matthias Brugger
2019-03-13 16:54       ` Stefan Roese
2019-03-13 16:54         ` Stefan Roese
2019-03-13 22:14         ` NeilBrown
2019-03-13 22:14           ` NeilBrown
2019-03-14  2:26           ` Chuanhong Guo
2019-03-14  2:26             ` Chuanhong Guo
2019-03-14  2:26             ` Chuanhong Guo
2019-03-14  2:36             ` NeilBrown [this message]
2019-03-14  2:36               ` NeilBrown
2019-03-13 12:34 ` Dan Carpenter
2019-03-13 12:34   ` Dan Carpenter
2019-03-13 12:34   ` Dan Carpenter
2019-03-13 16:47   ` Matthias Brugger
2019-03-13 16:47     ` Matthias Brugger
2019-03-14 11:13   ` Armando Miraglia
2019-03-14 11:13     ` Armando Miraglia
2019-03-14 11:27     ` Dan Carpenter
2019-03-14 11:27       ` Dan Carpenter
2019-03-14 11:27       ` Dan Carpenter
2019-03-14 14:07       ` Jean Delvare
2019-03-14 14:07         ` Jean Delvare
2019-03-14 20:50         ` Joe Perches
2019-03-14 20:50           ` Joe Perches
2019-03-14 11:36     ` Stefan Roese
2019-03-14 11:36       ` Stefan Roese
2019-03-14 11:37       ` Armando Miraglia
2019-03-14 11:37         ` Armando Miraglia
2019-03-14 13:14         ` Matthias Brugger
2019-03-14 13:14           ` Matthias Brugger
2019-03-14 13:14           ` Matthias Brugger
2019-03-14 13:24           ` Stefan Roese
2019-03-14 13:24             ` Stefan Roese
2019-03-14 17:01             ` Matthias Brugger
2019-03-14 17:01               ` Matthias Brugger
  -- strict thread matches above, loose matches on Subject: below --
2019-03-13 11:57 Armando Miraglia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mulyp4h0.fsf@notabene.neil.brown.name \
    --to=neil@brown.name \
    --cc=arma2ff0@gmail.com \
    --cc=armax@google.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gch981213@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john@phrozen.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=sankalpnegi2310@gmail.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.