All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, Vladimir Zapolskiy <vz@mleia.com>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver
Date: Sat, 16 Mar 2019 17:16:58 +0000	[thread overview]
Message-ID: <20190316171658.327ab411@archlinux> (raw)
In-Reply-To: <20190315095231.17001-1-gregory.clement@bootlin.com>

On Fri, 15 Mar 2019 10:52:27 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:

> Hello,
> 
> This is the second version of a series adding the support of the scale
> feature to the lpc32xx ADC driver. In order to use it we need to have
> the voltage reference as a device tree property, however in order to
> be backward compatible, this property is optional and do not prevent
> to use the driver if missing.
> 
> I updated the binding documentation accordingly.
> 
> Gregory
> 
> Changelog:
> v1 -> v2:
> 
>  - "dt-bindings: iio: adc: move lpc32xx-adc out of staging" and
>    "iio:adc:lpc32xx use SPDX-License-Identifier" has been merged
> 
>  - split "iio:adc:lpc32xx use SPDX-License-Identifier" in 2 patches
>    one foe sorting and the second one for removal
Hohum. I'm reviewing cover letters now. Must have too much time on 
my hands ;)

This is talking about the wrong patch.

> 
>  - add reviewed-by from Rob Herring on the binding documentation patch
> 
>  - add default in the switch/case in lpc32xx_read_raw()
> 
>  - no more use scan_type.realbits and directly put the value in the
>    IIO_CHAN_INFO_SCALE case
> 
>  - keep the const for the struct iio_chan_spec and declare 2 of them.
> 
>  - remove the unrelated and bad whitespace change.
> 
> Gregory CLEMENT (4):
>   iio: adc: lpc32xx: Sort headers
>   iio: adc: lpc32xx: Cleanup headers
>   iio: adc: lpc32xx: Add scale feature
>   dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply
> 
>  .../bindings/iio/adc/lpc32xx-adc.txt          |  5 ++
>  drivers/iio/adc/lpc32xx_adc.c                 | 59 +++++++++++++------
>  2 files changed, 47 insertions(+), 17 deletions(-)
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Rob Herring <robh+dt@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver
Date: Sat, 16 Mar 2019 17:16:58 +0000	[thread overview]
Message-ID: <20190316171658.327ab411@archlinux> (raw)
In-Reply-To: <20190315095231.17001-1-gregory.clement@bootlin.com>

On Fri, 15 Mar 2019 10:52:27 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:

> Hello,
> 
> This is the second version of a series adding the support of the scale
> feature to the lpc32xx ADC driver. In order to use it we need to have
> the voltage reference as a device tree property, however in order to
> be backward compatible, this property is optional and do not prevent
> to use the driver if missing.
> 
> I updated the binding documentation accordingly.
> 
> Gregory
> 
> Changelog:
> v1 -> v2:
> 
>  - "dt-bindings: iio: adc: move lpc32xx-adc out of staging" and
>    "iio:adc:lpc32xx use SPDX-License-Identifier" has been merged
> 
>  - split "iio:adc:lpc32xx use SPDX-License-Identifier" in 2 patches
>    one foe sorting and the second one for removal
Hohum. I'm reviewing cover letters now. Must have too much time on 
my hands ;)

This is talking about the wrong patch.

> 
>  - add reviewed-by from Rob Herring on the binding documentation patch
> 
>  - add default in the switch/case in lpc32xx_read_raw()
> 
>  - no more use scan_type.realbits and directly put the value in the
>    IIO_CHAN_INFO_SCALE case
> 
>  - keep the const for the struct iio_chan_spec and declare 2 of them.
> 
>  - remove the unrelated and bad whitespace change.
> 
> Gregory CLEMENT (4):
>   iio: adc: lpc32xx: Sort headers
>   iio: adc: lpc32xx: Cleanup headers
>   iio: adc: lpc32xx: Add scale feature
>   dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply
> 
>  .../bindings/iio/adc/lpc32xx-adc.txt          |  5 ++
>  drivers/iio/adc/lpc32xx_adc.c                 | 59 +++++++++++++------
>  2 files changed, 47 insertions(+), 17 deletions(-)
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Rob Herring <robh+dt@kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver
Date: Sat, 16 Mar 2019 17:16:58 +0000	[thread overview]
Message-ID: <20190316171658.327ab411@archlinux> (raw)
In-Reply-To: <20190315095231.17001-1-gregory.clement@bootlin.com>

On Fri, 15 Mar 2019 10:52:27 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:

> Hello,
> 
> This is the second version of a series adding the support of the scale
> feature to the lpc32xx ADC driver. In order to use it we need to have
> the voltage reference as a device tree property, however in order to
> be backward compatible, this property is optional and do not prevent
> to use the driver if missing.
> 
> I updated the binding documentation accordingly.
> 
> Gregory
> 
> Changelog:
> v1 -> v2:
> 
>  - "dt-bindings: iio: adc: move lpc32xx-adc out of staging" and
>    "iio:adc:lpc32xx use SPDX-License-Identifier" has been merged
> 
>  - split "iio:adc:lpc32xx use SPDX-License-Identifier" in 2 patches
>    one foe sorting and the second one for removal
Hohum. I'm reviewing cover letters now. Must have too much time on 
my hands ;)

This is talking about the wrong patch.

> 
>  - add reviewed-by from Rob Herring on the binding documentation patch
> 
>  - add default in the switch/case in lpc32xx_read_raw()
> 
>  - no more use scan_type.realbits and directly put the value in the
>    IIO_CHAN_INFO_SCALE case
> 
>  - keep the const for the struct iio_chan_spec and declare 2 of them.
> 
>  - remove the unrelated and bad whitespace change.
> 
> Gregory CLEMENT (4):
>   iio: adc: lpc32xx: Sort headers
>   iio: adc: lpc32xx: Cleanup headers
>   iio: adc: lpc32xx: Add scale feature
>   dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply
> 
>  .../bindings/iio/adc/lpc32xx-adc.txt          |  5 ++
>  drivers/iio/adc/lpc32xx_adc.c                 | 59 +++++++++++++------
>  2 files changed, 47 insertions(+), 17 deletions(-)
> 

  parent reply	other threads:[~2019-03-16 17:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  9:52 [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver Gregory CLEMENT
2019-03-15  9:52 ` Gregory CLEMENT
2019-03-15  9:52 ` Gregory CLEMENT
2019-03-15  9:52 ` [PATCH v2 1/4] iio: adc: lpc32xx: Sort headers Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-16 17:17   ` Jonathan Cameron
2019-03-16 17:17     ` Jonathan Cameron
2019-03-16 17:17     ` Jonathan Cameron
2019-03-15  9:52 ` [PATCH v2 2/4] iio: adc: lpc32xx: Cleanup headers Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-16 17:23   ` Jonathan Cameron
2019-03-16 17:23     ` Jonathan Cameron
2019-03-16 17:23     ` Jonathan Cameron
2019-03-15  9:52 ` [PATCH v2 3/4] iio: adc: lpc32xx: Add scale feature Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-16 17:26   ` Jonathan Cameron
2019-03-16 17:26     ` Jonathan Cameron
2019-03-16 17:26     ` Jonathan Cameron
2019-03-15  9:52 ` [PATCH v2 4/4] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-15  9:52   ` Gregory CLEMENT
2019-03-16 17:27   ` Jonathan Cameron
2019-03-16 17:27     ` Jonathan Cameron
2019-03-16 17:27     ` Jonathan Cameron
2019-03-16 17:16 ` Jonathan Cameron [this message]
2019-03-16 17:16   ` [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver Jonathan Cameron
2019-03-16 17:16   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190316171658.327ab411@archlinux \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=slemieux.tyco@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.