From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] iio: adc: lpc32xx: Cleanup headers
Date: Sat, 16 Mar 2019 17:23:27 +0000 [thread overview]
Message-ID: <20190316172327.2c1d7751@archlinux> (raw)
In-Reply-To: <20190315095231.17001-3-gregory.clement@bootlin.com>
On Fri, 15 Mar 2019 10:52:29 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> A few headers is useless: remove them.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> drivers/iio/adc/lpc32xx_adc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
> index 7084f804504e..f391c1e10136 100644
> --- a/drivers/iio/adc/lpc32xx_adc.c
> +++ b/drivers/iio/adc/lpc32xx_adc.c
> @@ -9,17 +9,11 @@
>
> #include <linux/clk.h>
> #include <linux/completion.h>
> -#include <linux/device.h>
> -#include <linux/err.h>
-EINVAL comes from asm/errno.h I believe. IS_ERR
is also in this header. Otherwise, they are fine, so
I'll just leave this one.
> #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/slab.h>
>
> /*
> * LPC32XX registers definitions
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Vladimir Zapolskiy <vz@mleia.com>,
Rob Herring <robh+dt@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] iio: adc: lpc32xx: Cleanup headers
Date: Sat, 16 Mar 2019 17:23:27 +0000 [thread overview]
Message-ID: <20190316172327.2c1d7751@archlinux> (raw)
In-Reply-To: <20190315095231.17001-3-gregory.clement@bootlin.com>
On Fri, 15 Mar 2019 10:52:29 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> A few headers is useless: remove them.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> drivers/iio/adc/lpc32xx_adc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
> index 7084f804504e..f391c1e10136 100644
> --- a/drivers/iio/adc/lpc32xx_adc.c
> +++ b/drivers/iio/adc/lpc32xx_adc.c
> @@ -9,17 +9,11 @@
>
> #include <linux/clk.h>
> #include <linux/completion.h>
> -#include <linux/device.h>
> -#include <linux/err.h>
-EINVAL comes from asm/errno.h I believe. IS_ERR
is also in this header. Otherwise, they are fine, so
I'll just leave this one.
> #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/slab.h>
>
> /*
> * LPC32XX registers definitions
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Vladimir Zapolskiy <vz@mleia.com>,
Rob Herring <robh+dt@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] iio: adc: lpc32xx: Cleanup headers
Date: Sat, 16 Mar 2019 17:23:27 +0000 [thread overview]
Message-ID: <20190316172327.2c1d7751@archlinux> (raw)
In-Reply-To: <20190315095231.17001-3-gregory.clement@bootlin.com>
On Fri, 15 Mar 2019 10:52:29 +0100
Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> A few headers is useless: remove them.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> drivers/iio/adc/lpc32xx_adc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc32xx_adc.c b/drivers/iio/adc/lpc32xx_adc.c
> index 7084f804504e..f391c1e10136 100644
> --- a/drivers/iio/adc/lpc32xx_adc.c
> +++ b/drivers/iio/adc/lpc32xx_adc.c
> @@ -9,17 +9,11 @@
>
> #include <linux/clk.h>
> #include <linux/completion.h>
> -#include <linux/device.h>
> -#include <linux/err.h>
-EINVAL comes from asm/errno.h I believe. IS_ERR
is also in this header. Otherwise, they are fine, so
I'll just leave this one.
> #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/slab.h>
>
> /*
> * LPC32XX registers definitions
next prev parent reply other threads:[~2019-03-16 17:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 9:52 [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` [PATCH v2 1/4] iio: adc: lpc32xx: Sort headers Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-16 17:17 ` Jonathan Cameron
2019-03-16 17:17 ` Jonathan Cameron
2019-03-16 17:17 ` Jonathan Cameron
2019-03-15 9:52 ` [PATCH v2 2/4] iio: adc: lpc32xx: Cleanup headers Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-16 17:23 ` Jonathan Cameron [this message]
2019-03-16 17:23 ` Jonathan Cameron
2019-03-16 17:23 ` Jonathan Cameron
2019-03-15 9:52 ` [PATCH v2 3/4] iio: adc: lpc32xx: Add scale feature Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-16 17:26 ` Jonathan Cameron
2019-03-16 17:26 ` Jonathan Cameron
2019-03-16 17:26 ` Jonathan Cameron
2019-03-15 9:52 ` [PATCH v2 4/4] dt-bindings: iio: adc: lpc32xx-adc: Document vref-supply Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-15 9:52 ` Gregory CLEMENT
2019-03-16 17:27 ` Jonathan Cameron
2019-03-16 17:27 ` Jonathan Cameron
2019-03-16 17:27 ` Jonathan Cameron
2019-03-16 17:16 ` [PATCH v2 0/4] Adding scale support to the lpc32xx ADC driver Jonathan Cameron
2019-03-16 17:16 ` Jonathan Cameron
2019-03-16 17:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190316172327.2c1d7751@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.