All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend
Date: Wed, 20 Mar 2019 20:42:22 +0800	[thread overview]
Message-ID: <20190320124221.GN4980@dragon> (raw)
In-Reply-To: <20190306140402.17122-1-aford173@gmail.com>

On Wed, Mar 06, 2019 at 08:03:59AM -0600, Adam Ford wrote:
> The LCD power sequencer is very finicky.  The backlight cannot
> be driven until after the sequencer is done.  Until now, the
> regulators were marked with 'regulator-always-on' to make sure
> it came up before the backlight.  This patch allows the LCD
> regulators to power down and prevent the backlight from being
> used again until the sequencer is ready.  This reduces
> standby power consumption by ~100mW.
> 
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic
> PD i.MX6QD EVM")

Fixes tag is more for regressions or serious bugs.  It looks the patch
is more like an improvement though.

Shawn

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> index 45eb0b7f75f8..d96ae54be338 100644
> --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> @@ -21,6 +21,8 @@
>  
>  	panel-lvds0 {
>  		compatible = "okaya,rs800480t-7x0gp";
> +		power-supply = <&reg_lcd_reset>;
> +		backlight = <&backlight>;
>  
>  		port {
>  			panel_in_lvds0: endpoint {
> @@ -38,7 +40,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_3v3>;
>  		startup-delay-us = <500000>;
>  	};
> @@ -52,7 +53,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_lcd>;
>  	};
>  };
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend
Date: Wed, 20 Mar 2019 20:42:22 +0800	[thread overview]
Message-ID: <20190320124221.GN4980@dragon> (raw)
In-Reply-To: <20190306140402.17122-1-aford173@gmail.com>

On Wed, Mar 06, 2019 at 08:03:59AM -0600, Adam Ford wrote:
> The LCD power sequencer is very finicky.  The backlight cannot
> be driven until after the sequencer is done.  Until now, the
> regulators were marked with 'regulator-always-on' to make sure
> it came up before the backlight.  This patch allows the LCD
> regulators to power down and prevent the backlight from being
> used again until the sequencer is ready.  This reduces
> standby power consumption by ~100mW.
> 
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic
> PD i.MX6QD EVM")

Fixes tag is more for regressions or serious bugs.  It looks the patch
is more like an improvement though.

Shawn

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> index 45eb0b7f75f8..d96ae54be338 100644
> --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> @@ -21,6 +21,8 @@
>  
>  	panel-lvds0 {
>  		compatible = "okaya,rs800480t-7x0gp";
> +		power-supply = <&reg_lcd_reset>;
> +		backlight = <&backlight>;
>  
>  		port {
>  			panel_in_lvds0: endpoint {
> @@ -38,7 +40,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_3v3>;
>  		startup-delay-us = <500000>;
>  	};
> @@ -52,7 +53,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_lcd>;
>  	};
>  };
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend
Date: Wed, 20 Mar 2019 20:42:22 +0800	[thread overview]
Message-ID: <20190320124221.GN4980@dragon> (raw)
In-Reply-To: <20190306140402.17122-1-aford173@gmail.com>

On Wed, Mar 06, 2019 at 08:03:59AM -0600, Adam Ford wrote:
> The LCD power sequencer is very finicky.  The backlight cannot
> be driven until after the sequencer is done.  Until now, the
> regulators were marked with 'regulator-always-on' to make sure
> it came up before the backlight.  This patch allows the LCD
> regulators to power down and prevent the backlight from being
> used again until the sequencer is ready.  This reduces
> standby power consumption by ~100mW.
> 
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic
> PD i.MX6QD EVM")

Fixes tag is more for regressions or serious bugs.  It looks the patch
is more like an improvement though.

Shawn

> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> index 45eb0b7f75f8..d96ae54be338 100644
> --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> @@ -21,6 +21,8 @@
>  
>  	panel-lvds0 {
>  		compatible = "okaya,rs800480t-7x0gp";
> +		power-supply = <&reg_lcd_reset>;
> +		backlight = <&backlight>;
>  
>  		port {
>  			panel_in_lvds0: endpoint {
> @@ -38,7 +40,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_3v3>;
>  		startup-delay-us = <500000>;
>  	};
> @@ -52,7 +53,6 @@
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
> -		regulator-always-on;
>  		vin-supply = <&reg_lcd>;
>  	};
>  };
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2019-03-20 12:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 14:03 [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Adam Ford
2019-03-06 14:03 ` Adam Ford
2019-03-06 14:04 ` [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start Adam Ford
2019-03-06 14:04   ` Adam Ford
2019-03-20 12:44   ` Shawn Guo
2019-03-20 12:44     ` Shawn Guo
2019-03-20 13:41     ` Adam Ford
2019-03-20 13:41       ` Adam Ford
2019-03-20 14:57       ` Shawn Guo
2019-03-20 14:57         ` Shawn Guo
2019-03-06 14:04 ` [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture Adam Ford
2019-03-06 14:04   ` Adam Ford
2019-03-20 12:46   ` Shawn Guo
2019-03-20 12:46     ` Shawn Guo
2019-03-20 12:42 ` Shawn Guo [this message]
2019-03-20 12:42   ` [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Shawn Guo
2019-03-20 12:42   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320124221.GN4980@dragon \
    --to=shawnguo@kernel.org \
    --cc=aford173@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.