From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture
Date: Wed, 20 Mar 2019 20:46:35 +0800 [thread overview]
Message-ID: <20190320124634.GP4980@dragon> (raw)
In-Reply-To: <20190306140402.17122-3-aford173@gmail.com>
On Wed, Mar 06, 2019 at 08:04:01AM -0600, Adam Ford wrote:
> The original submission had functional audio out and was based
> on reviewing other boards using the same wm8962 codec. However,
> the Logic PD board uses an analog microphone which was being
> disabled for a digital mic. This patch corrects that and
> explicitly sets the gpio-cfg pins all to 0x0000 which allows the
> analog microphone to capture audio.
>
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic PD
> i.MX6QD EVM")
If audio capture has never worked, the change is more like a "new feature"
than critical fix.
Shawn
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> index e31b6923cb72..db6b5b900826 100644
> --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> @@ -248,9 +248,9 @@
> gpio-cfg = <
> 0x0000 /* 0:Default */
> 0x0000 /* 1:Default */
> - 0x0013 /* 2:FN_DMICCLK */
> + 0x0000 /* 2:FN_DMICCLK */
> 0x0000 /* 3:Default */
> - 0x8014 /* 4:FN_DMICCDAT */
> + 0x0000 /* 4:FN_DMICCDAT */
> 0x0000 /* 5:Default */
> >;
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture
Date: Wed, 20 Mar 2019 20:46:35 +0800 [thread overview]
Message-ID: <20190320124634.GP4980@dragon> (raw)
In-Reply-To: <20190306140402.17122-3-aford173@gmail.com>
On Wed, Mar 06, 2019 at 08:04:01AM -0600, Adam Ford wrote:
> The original submission had functional audio out and was based
> on reviewing other boards using the same wm8962 codec. However,
> the Logic PD board uses an analog microphone which was being
> disabled for a digital mic. This patch corrects that and
> explicitly sets the gpio-cfg pins all to 0x0000 which allows the
> analog microphone to capture audio.
>
> Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic PD
> i.MX6QD EVM")
If audio capture has never worked, the change is more like a "new feature"
than critical fix.
Shawn
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> index e31b6923cb72..db6b5b900826 100644
> --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> @@ -248,9 +248,9 @@
> gpio-cfg = <
> 0x0000 /* 0:Default */
> 0x0000 /* 1:Default */
> - 0x0013 /* 2:FN_DMICCLK */
> + 0x0000 /* 2:FN_DMICCLK */
> 0x0000 /* 3:Default */
> - 0x8014 /* 4:FN_DMICCDAT */
> + 0x0000 /* 4:FN_DMICCDAT */
> 0x0000 /* 5:Default */
> >;
> };
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-03-20 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 14:03 [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Adam Ford
2019-03-06 14:03 ` Adam Ford
2019-03-06 14:04 ` [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start Adam Ford
2019-03-06 14:04 ` Adam Ford
2019-03-20 12:44 ` Shawn Guo
2019-03-20 12:44 ` Shawn Guo
2019-03-20 13:41 ` Adam Ford
2019-03-20 13:41 ` Adam Ford
2019-03-20 14:57 ` Shawn Guo
2019-03-20 14:57 ` Shawn Guo
2019-03-06 14:04 ` [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture Adam Ford
2019-03-06 14:04 ` Adam Ford
2019-03-20 12:46 ` Shawn Guo [this message]
2019-03-20 12:46 ` Shawn Guo
2019-03-20 12:42 ` [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Shawn Guo
2019-03-20 12:42 ` Shawn Guo
2019-03-20 12:42 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320124634.GP4980@dragon \
--to=shawnguo@kernel.org \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.