All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Sprickerhof <jochen@sprickerhof.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: usb: dwc3: Enable GBit Ethernet on Odroid XU4
Date: Wed, 20 Mar 2019 19:12:25 +0100	[thread overview]
Message-ID: <20190320181225.GA539@vis> (raw)

Hi Marek,

* Marek Szyprowski <m.szyprowski@samsung.com> [2019-03-11 12:11]:
>Hi Jochen,
>
>On 2019-02-08 20:35, Jochen Sprickerhof wrote:
>> Hi Marek,
>>
>> * Marek Szyprowski <m.szyprowski@samsung.com> [2019-02-08 13:36]:
>>>>>> On 21/01/19 16:02, Jochen Sprickerhof wrote:
>>>>> [..]
>>>>>>> I'm not sure why this it only works with the driver compiled into
>>>>>>> the
>>>>>>> kernel nor why it needs a hard reset or why it was the line was
>>>>>>> dropped
>>>>>>> when the patch was accepted. Would be great to get some feedback
>>>>>>> of the
>>>>>>> authors.
>>>>>> When XHCI driver is compiled into the kernel are the relevant PHY
>>>>>> drivers
>>>>>> compiled in as well?
>>>>> Only CONFIG_USB_PHY=y (I took the config from the
>>>>> linux-image-4.19.0-1-armmp_4.19.13-1_armhf.deb Debian package as a
>>>>> basis where this is the default).
>>>
>>> I confirm that on Odroid XU4 USB 3.0 works only when all related drivers
>>> (dwc3, xhci and exynos5 drd phy) are compiled into the kernel. If they
>>> are compiled as modules, USB 3.0 calibration doesn't work. The mentioned
>>> patch doesn't fix anything.
>>
>> I've just tried Linux v5.0-rc5 with the Debian config and
>> USB_XHCI_PLATFORM=y and it works, thanks!
>>
>> Is there a way to make it work with xhci compiled as a module, so it
>> would work in Debian out of the box?
>
>One more comment - 5000M mode will also work with everything compiled as
>modules (dwc3, exynos5 drd phy and xhci-plat) too. Just make sure that
>xhci-plat is loaded before dwc3. This would require some manual
>configuration, because autoloading will load xhci-plat after dwc3 probe
>and switch to host mode.

Thanks so much for the hint, this made it working :). I opened a bug 
with Debian:

https://bugs.debian.org/925167

Cheers Jochen

WARNING: multiple messages have this Message-ID (diff)
From: Jochen Sprickerhof <jochen@sprickerhof.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4
Date: Wed, 20 Mar 2019 19:12:25 +0100	[thread overview]
Message-ID: <20190320181225.GA539@vis> (raw)
In-Reply-To: <2b8d7801-26a5-201e-71d1-ccef3c99f728@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

Hi Marek,

* Marek Szyprowski <m.szyprowski@samsung.com> [2019-03-11 12:11]:
>Hi Jochen,
>
>On 2019-02-08 20:35, Jochen Sprickerhof wrote:
>> Hi Marek,
>>
>> * Marek Szyprowski <m.szyprowski@samsung.com> [2019-02-08 13:36]:
>>>>>> On 21/01/19 16:02, Jochen Sprickerhof wrote:
>>>>> [..]
>>>>>>> I'm not sure why this it only works with the driver compiled into
>>>>>>> the
>>>>>>> kernel nor why it needs a hard reset or why it was the line was
>>>>>>> dropped
>>>>>>> when the patch was accepted. Would be great to get some feedback
>>>>>>> of the
>>>>>>> authors.
>>>>>> When XHCI driver is compiled into the kernel are the relevant PHY
>>>>>> drivers
>>>>>> compiled in as well?
>>>>> Only CONFIG_USB_PHY=y (I took the config from the
>>>>> linux-image-4.19.0-1-armmp_4.19.13-1_armhf.deb Debian package as a
>>>>> basis where this is the default).
>>>
>>> I confirm that on Odroid XU4 USB 3.0 works only when all related drivers
>>> (dwc3, xhci and exynos5 drd phy) are compiled into the kernel. If they
>>> are compiled as modules, USB 3.0 calibration doesn't work. The mentioned
>>> patch doesn't fix anything.
>>
>> I've just tried Linux v5.0-rc5 with the Debian config and
>> USB_XHCI_PLATFORM=y and it works, thanks!
>>
>> Is there a way to make it work with xhci compiled as a module, so it
>> would work in Debian out of the box?
>
>One more comment - 5000M mode will also work with everything compiled as
>modules (dwc3, exynos5 drd phy and xhci-plat) too. Just make sure that
>xhci-plat is loaded before dwc3. This would require some manual
>configuration, because autoloading will load xhci-plat after dwc3 probe
>and switch to host mode.

Thanks so much for the hint, this made it working :). I opened a bug 
with Debian:

https://bugs.debian.org/925167

Cheers Jochen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2019-03-20 18:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 18:12 Jochen Sprickerhof [this message]
2019-03-20 18:12 ` [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4 Jochen Sprickerhof
  -- strict thread matches above, loose matches on Subject: below --
2019-03-11 11:11 Marek Szyprowski
2019-03-11 11:11 ` [PATCH] " Marek Szyprowski
2019-02-08 19:35 Jochen Sprickerhof
2019-02-08 19:35 ` [PATCH] " Jochen Sprickerhof
2019-02-08 12:52 Felipe Balbi
2019-02-08 12:52 ` [PATCH] " Felipe Balbi
2019-02-08 12:36 Marek Szyprowski
2019-02-08 12:36 ` [PATCH] " Marek Szyprowski
2019-02-06 10:17 Roger Quadros
2019-02-06 10:17 ` [PATCH] " Roger Quadros
2019-02-06  9:38 Jochen Sprickerhof
2019-02-06  9:38 ` [PATCH] " Jochen Sprickerhof
2019-02-06  8:41 Roger Quadros
2019-02-06  8:41 ` [PATCH] " Roger Quadros
2019-02-06  6:49 Felipe Balbi
2019-02-06  6:49 ` [PATCH] " Felipe Balbi
2019-01-21 14:02 Jochen Sprickerhof
2019-01-21 14:02 ` [PATCH] " Jochen Sprickerhof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320181225.GA539@vis \
    --to=jochen@sprickerhof.de \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.