From: Roger Quadros <rogerq@ti.com>
To: Jochen Sprickerhof <git@jochen.sprickerhof.de>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Vivek Gautam <gautam.vivek@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: usb: dwc3: Enable GBit Ethernet on Odroid XU4
Date: Wed, 6 Feb 2019 10:41:47 +0200 [thread overview]
Message-ID: <5C5A9DCB.8040507@ti.com> (raw)
Hi,
On 21/01/19 16:02, Jochen Sprickerhof wrote:
> Note that it only works with USB_XHCI_PLATFORM=y. Also it needs a hard
> reset when coming from an unpatched kernel.
>
> This was included in the original patch in
> https://patchwork.kernel.org/patch/9992809/ but got dropped when
> accepted in d8c80bb3b55b phy: exynos5-usbdrd: Calibrate LOS levels for
> exynos5420/5800.
>
> Old behaviour:
>
> $ lsusb -t
> /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
> |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
>
> New behaviour:
>
> $ lsusb -t
> /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
>
> Tested on Debian unstable using u-boot-exynos (2018.11+dfsg-2) and Linux
> 4.19.14.
>
> Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> ---
>
> Hi,
>
> I'm not sure why this it only works with the driver compiled into the
> kernel nor why it needs a hard reset or why it was the line was dropped
> when the patch was accepted. Would be great to get some feedback of the
> authors.
When XHCI driver is compiled into the kernel are the relevant PHY drivers
compiled in as well?
cheers,
-roger
>
> Cheers Jochen
>
> drivers/usb/dwc3/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index a1b126f90261..0008bccc30aa 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1169,7 +1169,8 @@ static int dwc3_core_init_mode(struct dwc3 *dwc)
> dev_err(dev, "failed to initialize host\n");
> return ret;
> }
> - phy_calibrate(dwc->usb2_generic_phy);
> + if (dwc->usb2_generic_phy)
> + phy_calibrate(dwc->usb2_generic_phy);
> break;
> case USB_DR_MODE_OTG:
> INIT_WORK(&dwc->drd_work, __dwc3_set_mode);
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Jochen Sprickerhof <git@jochen.sprickerhof.de>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Vivek Gautam <gautam.vivek@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4
Date: Wed, 6 Feb 2019 10:41:47 +0200 [thread overview]
Message-ID: <5C5A9DCB.8040507@ti.com> (raw)
In-Reply-To: <20190121140204.GA2360@vis>
Hi,
On 21/01/19 16:02, Jochen Sprickerhof wrote:
> Note that it only works with USB_XHCI_PLATFORM=y. Also it needs a hard
> reset when coming from an unpatched kernel.
>
> This was included in the original patch in
> https://patchwork.kernel.org/patch/9992809/ but got dropped when
> accepted in d8c80bb3b55b phy: exynos5-usbdrd: Calibrate LOS levels for
> exynos5420/5800.
>
> Old behaviour:
>
> $ lsusb -t
> /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
> |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
>
> New behaviour:
>
> $ lsusb -t
> /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
>
> Tested on Debian unstable using u-boot-exynos (2018.11+dfsg-2) and Linux
> 4.19.14.
>
> Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> ---
>
> Hi,
>
> I'm not sure why this it only works with the driver compiled into the
> kernel nor why it needs a hard reset or why it was the line was dropped
> when the patch was accepted. Would be great to get some feedback of the
> authors.
When XHCI driver is compiled into the kernel are the relevant PHY drivers
compiled in as well?
cheers,
-roger
>
> Cheers Jochen
>
> drivers/usb/dwc3/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index a1b126f90261..0008bccc30aa 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1169,7 +1169,8 @@ static int dwc3_core_init_mode(struct dwc3 *dwc)
> dev_err(dev, "failed to initialize host\n");
> return ret;
> }
> - phy_calibrate(dwc->usb2_generic_phy);
> + if (dwc->usb2_generic_phy)
> + phy_calibrate(dwc->usb2_generic_phy);
> break;
> case USB_DR_MODE_OTG:
> INIT_WORK(&dwc->drd_work, __dwc3_set_mode);
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2019-02-06 8:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 8:41 Roger Quadros [this message]
2019-02-06 8:41 ` [PATCH] usb: dwc3: Enable GBit Ethernet on Odroid XU4 Roger Quadros
-- strict thread matches above, loose matches on Subject: below --
2019-03-20 18:12 Jochen Sprickerhof
2019-03-20 18:12 ` [PATCH] " Jochen Sprickerhof
2019-03-11 11:11 Marek Szyprowski
2019-03-11 11:11 ` [PATCH] " Marek Szyprowski
2019-02-08 19:35 Jochen Sprickerhof
2019-02-08 19:35 ` [PATCH] " Jochen Sprickerhof
2019-02-08 12:52 Felipe Balbi
2019-02-08 12:52 ` [PATCH] " Felipe Balbi
2019-02-08 12:36 Marek Szyprowski
2019-02-08 12:36 ` [PATCH] " Marek Szyprowski
2019-02-06 10:17 Roger Quadros
2019-02-06 10:17 ` [PATCH] " Roger Quadros
2019-02-06 9:38 Jochen Sprickerhof
2019-02-06 9:38 ` [PATCH] " Jochen Sprickerhof
2019-02-06 6:49 Felipe Balbi
2019-02-06 6:49 ` [PATCH] " Felipe Balbi
2019-01-21 14:02 Jochen Sprickerhof
2019-01-21 14:02 ` [PATCH] " Jochen Sprickerhof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C5A9DCB.8040507@ti.com \
--to=rogerq@ti.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=git@jochen.sprickerhof.de \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.