From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jochen Sprickerhof <jochen@sprickerhof.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: usb: dwc3: Softdep for GBit Ethernet on Odroid XU4
Date: Sat, 23 Mar 2019 07:05:41 +0100 [thread overview]
Message-ID: <20190323060541.GA28292@kroah.com> (raw)
On Fri, Mar 22, 2019 at 09:41:57PM +0100, Jochen Sprickerhof wrote:
> Hi Greg,
>
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [2019-03-22 06:37]:
> > On Thu, Mar 21, 2019 at 09:23:03PM +0100, Jochen Sprickerhof wrote:
> > > This adds a soft dependency to the dwc3 module to load it after
> > > xhci-plat as proposed in:
> > >
> > > https://marc.info/?l=linux-usb&m=155230272022603&w=2
> > >
> > > Old behaviour:
> > >
> > > $ lsusb -t
> > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> > > /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
> > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
> > >
> > > New behaviour:
> > >
> > > $ lsusb -t
> > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
> > >
> > > Tested on Debian unstable using Linux 4.19.29.
> > >
> > > Note, this needs a hard reset when coming from an unpatched kernel.
> > >
> > > Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> > > ---
> > > drivers/usb/dwc3/core.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > > index 103807587dc6..9017e4ed9d99 100644
> > > --- a/drivers/usb/dwc3/core.c
> > > +++ b/drivers/usb/dwc3/core.c
> > > @@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
> > > MODULE_AUTHOR("Felipe Balbi <balbi@ti.com>");
> > > MODULE_LICENSE("GPL v2");
> > > MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
> > > +MODULE_SOFTDEP("pre: xhci_plat_hcd");
> >
> >
> > Your patch is corrupted and can not be applied :(
>
>
> I'm sorry to hear that. For me this works:
>
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> cd linux
> curl "https://lore.kernel.org/lkml/20190321202303.GA1399@vis/raw" | git am -
>
> But I found some archives that seems to have fiddled with the Content-Type
> of my signed mail, making it fail. Can you send more information about the
> corruption?
Maybe it works if I look at the raw email, but just from the above text,
your leading ' ' characters are dropped, so that's why I emailed you
this.
Let me go look at the message I received...
Ah, yeah, the raw message is correct, it just has a gpg signature which
messed with my email client's display somehow and dropped those leading
spaces.
Sorry for the noise, all is good.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jochen Sprickerhof <jochen@sprickerhof.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] usb: dwc3: Softdep for GBit Ethernet on Odroid XU4
Date: Sat, 23 Mar 2019 07:05:41 +0100 [thread overview]
Message-ID: <20190323060541.GA28292@kroah.com> (raw)
In-Reply-To: <20190322204157.GB474@vis>
On Fri, Mar 22, 2019 at 09:41:57PM +0100, Jochen Sprickerhof wrote:
> Hi Greg,
>
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [2019-03-22 06:37]:
> > On Thu, Mar 21, 2019 at 09:23:03PM +0100, Jochen Sprickerhof wrote:
> > > This adds a soft dependency to the dwc3 module to load it after
> > > xhci-plat as proposed in:
> > >
> > > https://marc.info/?l=linux-usb&m=155230272022603&w=2
> > >
> > > Old behaviour:
> > >
> > > $ lsusb -t
> > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> > > /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M
> > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M
> > >
> > > New behaviour:
> > >
> > > $ lsusb -t
> > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M
> > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M
> > >
> > > Tested on Debian unstable using Linux 4.19.29.
> > >
> > > Note, this needs a hard reset when coming from an unpatched kernel.
> > >
> > > Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
> > > ---
> > > drivers/usb/dwc3/core.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > > index 103807587dc6..9017e4ed9d99 100644
> > > --- a/drivers/usb/dwc3/core.c
> > > +++ b/drivers/usb/dwc3/core.c
> > > @@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3");
> > > MODULE_AUTHOR("Felipe Balbi <balbi@ti.com>");
> > > MODULE_LICENSE("GPL v2");
> > > MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
> > > +MODULE_SOFTDEP("pre: xhci_plat_hcd");
> >
> >
> > Your patch is corrupted and can not be applied :(
>
>
> I'm sorry to hear that. For me this works:
>
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> cd linux
> curl "https://lore.kernel.org/lkml/20190321202303.GA1399@vis/raw" | git am -
>
> But I found some archives that seems to have fiddled with the Content-Type
> of my signed mail, making it fail. Can you send more information about the
> corruption?
Maybe it works if I look at the raw email, but just from the above text,
your leading ' ' characters are dropped, so that's why I emailed you
this.
Let me go look at the message I received...
Ah, yeah, the raw message is correct, it just has a gpg signature which
messed with my email client's display somehow and dropped those leading
spaces.
Sorry for the noise, all is good.
greg k-h
next reply other threads:[~2019-03-23 6:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 6:05 Greg Kroah-Hartman [this message]
2019-03-23 6:05 ` [PATCH] usb: dwc3: Softdep for GBit Ethernet on Odroid XU4 Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2019-03-22 20:41 Jochen Sprickerhof
2019-03-22 20:41 ` [PATCH] " Jochen Sprickerhof
2019-03-22 5:37 Greg Kroah-Hartman
2019-03-22 5:37 ` [PATCH] " Greg Kroah-Hartman
2019-03-21 20:23 Jochen Sprickerhof
2019-03-21 20:23 ` [PATCH] " Jochen Sprickerhof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323060541.GA28292@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=jochen@sprickerhof.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.