From: Greg KH <gregkh@linuxfoundation.org>
To: Vatsala Narang <vatsalanarang@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.
Date: Sun, 24 Mar 2019 10:09:55 +0100 [thread overview]
Message-ID: <20190324090955.GA7359@kroah.com> (raw)
In-Reply-To: <20190324000832.12027-1-vatsalanarang@gmail.com>
On Sun, Mar 24, 2019 at 05:38:32AM +0530, Vatsala Narang wrote:
> Remove braces around single statement block to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 6009fe0e1d4f..f0e6b72eb054 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -853,14 +853,10 @@ static u8 parse_subframe(struct sk_buff *skb,
>
> if (skb->len != 0) {
> nPadding_Length = 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4);
> - if (nPadding_Length == 4) {
> + if (nPadding_Length == 4)
> nPadding_Length = 0;
> - }
> -
> - if (skb->len < nPadding_Length) {
> + if (skb->len < nPadding_Length)
> return 0;
> - }
> -
> skb_pull(skb, nPadding_Length);
> }
> }
> @@ -1313,9 +1309,8 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
>
> stats->rx_packets++;
> stats->rx_bytes += sub_skb->len;
> - if (is_multicast_ether_addr(dst)) {
> + if (is_multicast_ether_addr(dst))
> stats->multicast++;
> - }
ALWAYS run your patches through checkpatch.pl so you do not add new
errors to the file, like you did here :(
greg k-h
next prev parent reply other threads:[~2019-03-24 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 0:08 [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces Vatsala Narang
2019-03-24 9:09 ` Greg KH [this message]
2019-03-24 18:59 ` Vatsala Narang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324090955.GA7359@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.