[PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.

[PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.

[Vatsala Narang]

Remove braces around single statement block to get rid of checkpatch warning.

Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 6009fe0e1d4f..f0e6b72eb054 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -853,14 +853,10 @@ static u8 parse_subframe(struct sk_buff *skb,
 
 			if (skb->len != 0) {
 				nPadding_Length = 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4);
-				if (nPadding_Length == 4) {
+				if (nPadding_Length == 4) 
 					nPadding_Length = 0;
-				}
-
-				if (skb->len < nPadding_Length) {
+				if (skb->len < nPadding_Length) 
 					return 0;
-				}
-
 				skb_pull(skb, nPadding_Length);
 			}
 		}
@@ -1313,9 +1309,8 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
 
 				stats->rx_packets++;
 				stats->rx_bytes += sub_skb->len;
-				if (is_multicast_ether_addr(dst)) {
+				if (is_multicast_ether_addr(dst)) 
 					stats->multicast++;
-				}
 
 				/* Indicat the packets to upper layer */
 				sub_skb->protocol = eth_type_trans(sub_skb, dev);
-- 
2.17.1

Re: [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.

[Greg KH]

On Sun, Mar 24, 2019 at 05:38:32AM +0530, Vatsala Narang wrote:
> Remove braces around single statement block to get rid of checkpatch warning.
> 
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 6009fe0e1d4f..f0e6b72eb054 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -853,14 +853,10 @@ static u8 parse_subframe(struct sk_buff *skb,
>  
>  			if (skb->len != 0) {
>  				nPadding_Length = 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4);
> -				if (nPadding_Length == 4) {
> +				if (nPadding_Length == 4) 
>  					nPadding_Length = 0;
> -				}
> -
> -				if (skb->len < nPadding_Length) {
> +				if (skb->len < nPadding_Length) 
>  					return 0;
> -				}
> -
>  				skb_pull(skb, nPadding_Length);
>  			}
>  		}
> @@ -1313,9 +1309,8 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
>  
>  				stats->rx_packets++;
>  				stats->rx_bytes += sub_skb->len;
> -				if (is_multicast_ether_addr(dst)) {
> +				if (is_multicast_ether_addr(dst)) 
>  					stats->multicast++;
> -				}

ALWAYS run your patches through checkpatch.pl so you do not add new
errors to the file, like you did here :(

greg k-h

Re: [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.

[Vatsala Narang]

[-- Attachment #1.1: Type: text/plain, Size: 450 bytes --]

> -                                if (is_multicast_ether_addr(dst)) { 

> > +                                if (is_multicast_ether_addr(dst)) 
> >                                          stats->multicast++; 
> > -                                } 
>
> ALWAYS run your patches through checkpatch.pl so you do not add new 
> errors to the file, like you did here :( 
>
> greg k-h 
>
okay i will verify it again and send it correctly
thanks,
Vatsala

[-- Attachment #1.2: Type: text/html, Size: 1233 bytes --]