* [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.
@ 2019-03-24 0:08 Vatsala Narang
2019-03-24 9:09 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Vatsala Narang @ 2019-03-24 0:08 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Vatsala Narang
Remove braces around single statement block to get rid of checkpatch warning.
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 6009fe0e1d4f..f0e6b72eb054 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -853,14 +853,10 @@ static u8 parse_subframe(struct sk_buff *skb,
if (skb->len != 0) {
nPadding_Length = 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4);
- if (nPadding_Length == 4) {
+ if (nPadding_Length == 4)
nPadding_Length = 0;
- }
-
- if (skb->len < nPadding_Length) {
+ if (skb->len < nPadding_Length)
return 0;
- }
-
skb_pull(skb, nPadding_Length);
}
}
@@ -1313,9 +1309,8 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
stats->rx_packets++;
stats->rx_bytes += sub_skb->len;
- if (is_multicast_ether_addr(dst)) {
+ if (is_multicast_ether_addr(dst))
stats->multicast++;
- }
/* Indicat the packets to upper layer */
sub_skb->protocol = eth_type_trans(sub_skb, dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces.
2019-03-24 0:08 [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces Vatsala Narang
@ 2019-03-24 9:09 ` Greg KH
2019-03-24 18:59 ` Vatsala Narang
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-24 9:09 UTC (permalink / raw)
To: Vatsala Narang; +Cc: outreachy-kernel
On Sun, Mar 24, 2019 at 05:38:32AM +0530, Vatsala Narang wrote:
> Remove braces around single statement block to get rid of checkpatch warning.
>
> Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 6009fe0e1d4f..f0e6b72eb054 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -853,14 +853,10 @@ static u8 parse_subframe(struct sk_buff *skb,
>
> if (skb->len != 0) {
> nPadding_Length = 4 - ((nSubframe_Length + ETHERNET_HEADER_SIZE) % 4);
> - if (nPadding_Length == 4) {
> + if (nPadding_Length == 4)
> nPadding_Length = 0;
> - }
> -
> - if (skb->len < nPadding_Length) {
> + if (skb->len < nPadding_Length)
> return 0;
> - }
> -
> skb_pull(skb, nPadding_Length);
> }
> }
> @@ -1313,9 +1309,8 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
>
> stats->rx_packets++;
> stats->rx_bytes += sub_skb->len;
> - if (is_multicast_ether_addr(dst)) {
> + if (is_multicast_ether_addr(dst))
> stats->multicast++;
> - }
ALWAYS run your patches through checkpatch.pl so you do not add new
errors to the file, like you did here :(
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-24 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-24 0:08 [PATCH] staging: rtl8192u: ieee80211: Remove unnecessary braces Vatsala Narang
2019-03-24 9:09 ` Greg KH
2019-03-24 18:59 ` Vatsala Narang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.