From: Dan Carpenter <dan.carpenter@oracle.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wen Yang <wen.yang99@zte.com.cn>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init()
Date: Wed, 03 Apr 2019 15:31:15 +0000 [thread overview]
Message-ID: <20190403153115.GA22624@kadam> (raw)
In-Reply-To: <c0c9c429-a09f-41ba-611d-123b64e410c8@web.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 786 bytes --]
On Wed, Apr 03, 2019 at 04:23:54PM +0200, Markus Elfring wrote:
> > @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> >
> > cpu = of_get_cpu_node(policy->cpu, NULL);
> >
> > + of_node_put(cpu);
> > if (!cpu)
> > goto out;
>
> Can the statement “return -ENODEV†be nicer as exception handling
> in the if branch of this source code place?
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id¿97b82f37c6d90e16de001d0659644c57fa490d#n137
>
Why am I only receiving only one side of this conversation?
I don't know why you're responding to... It's not required to fix/change
unrelated style choices. If people want, they can just focus on their
own thing.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wen Yang <wen.yang99@zte.com.cn>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init()
Date: Wed, 3 Apr 2019 18:31:15 +0300 [thread overview]
Message-ID: <20190403153115.GA22624@kadam> (raw)
In-Reply-To: <c0c9c429-a09f-41ba-611d-123b64e410c8@web.de>
On Wed, Apr 03, 2019 at 04:23:54PM +0200, Markus Elfring wrote:
> > @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> >
> > cpu = of_get_cpu_node(policy->cpu, NULL);
> >
> > + of_node_put(cpu);
> > if (!cpu)
> > goto out;
>
> Can the statement “return -ENODEV” be nicer as exception handling
> in the if branch of this source code place?
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n137
>
Why am I only receiving only one side of this conversation?
I don't know why you're responding to... It's not required to fix/change
unrelated style choices. If people want, they can just focus on their
own thing.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Wen Yang <wen.yang99@zte.com.cn>
Subject: Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init()
Date: Wed, 3 Apr 2019 18:31:15 +0300 [thread overview]
Message-ID: <20190403153115.GA22624@kadam> (raw)
In-Reply-To: <c0c9c429-a09f-41ba-611d-123b64e410c8@web.de>
On Wed, Apr 03, 2019 at 04:23:54PM +0200, Markus Elfring wrote:
> > @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> >
> > cpu = of_get_cpu_node(policy->cpu, NULL);
> >
> > + of_node_put(cpu);
> > if (!cpu)
> > goto out;
>
> Can the statement “return -ENODEV” be nicer as exception handling
> in the if branch of this source code place?
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n137
>
Why am I only receiving only one side of this conversation?
I don't know why you're responding to... It's not required to fix/change
unrelated style choices. If people want, they can just focus on their
own thing.
regards,
dan carpenter
next prev parent reply other threads:[~2019-04-03 15:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 1:37 [PATCH 0/7] fix possible object reference leaks in cpufreq Wen Yang
2019-04-01 1:37 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-02 13:54 ` [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-08 10:21 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Viresh Kumar
2019-04-08 10:21 ` Viresh Kumar
2019-04-01 1:37 ` [PATCH 2/7] cpufreq: imx6q: " Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` [PATCH 3/7] cpufreq: kirkwood: " Wen Yang
2019-04-03 13:17 ` [3/7] " Markus Elfring
2019-04-03 13:17 ` Markus Elfring
2019-04-01 1:37 ` [PATCH 4/7] cpufreq: maple: " Wen Yang
2019-04-03 13:50 ` [4/7] cpufreq: maple: Checking implementation of maple_cpufreq_init() Markus Elfring
2019-04-03 13:50 ` Markus Elfring
2019-04-01 1:37 ` [PATCH 5/7] cpufreq/pasemi: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
2019-04-03 14:23 ` Markus Elfring
2019-04-03 14:23 ` Markus Elfring
2019-04-03 15:31 ` Dan Carpenter [this message]
2019-04-03 15:31 ` Dan Carpenter
2019-04-03 15:31 ` Dan Carpenter
2019-04-01 1:37 ` [PATCH 6/7] cpufreq: pmac32: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` [PATCH 7/7] cpufreq: ppc_cbe: " Wen Yang
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:50 ` Julia Lawall
2019-04-02 10:50 ` Julia Lawall
2019-04-02 12:50 ` Markus Elfring
2019-04-02 12:50 ` Markus Elfring
2019-04-02 13:15 ` Julia Lawall
2019-04-02 13:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403153115.GA22624@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.