From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>, kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH 7/7] cpufreq: ppc_cbe: fix possible object reference leak
Date: Tue, 02 Apr 2019 12:50:28 +0000 [thread overview]
Message-ID: <89ab8dd4-e997-1796-a522-863ff511bb58@web.de> (raw)
In-Reply-To: <1554082674-2049-8-git-send-email-wen.yang99@zte.com.cn>
> @@ -86,6 +86,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
> if (!cbe_get_cpu_pmd_regs(policy->cpu) ||
> !cbe_get_cpu_mic_tm_regs(policy->cpu)) {
> pr_info("invalid CBE regs pointers for cpufreq\n");
> + of_node_put(cpu);
> return -EINVAL;
> }
I have taken another look at the implementation of this function.
I find that the second statement “return -EINVAL” would need related
source code adjustments.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/ppc_cbe_cpufreq.c?id=05d08e2995cbe6efdb993482ee0d38a77040861a#n96
How do you think about to complete the exception handling here?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>, kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH 7/7] cpufreq: ppc_cbe: fix possible object reference leak
Date: Tue, 2 Apr 2019 14:50:28 +0200 [thread overview]
Message-ID: <89ab8dd4-e997-1796-a522-863ff511bb58@web.de> (raw)
In-Reply-To: <1554082674-2049-8-git-send-email-wen.yang99@zte.com.cn>
> @@ -86,6 +86,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
> if (!cbe_get_cpu_pmd_regs(policy->cpu) ||
> !cbe_get_cpu_mic_tm_regs(policy->cpu)) {
> pr_info("invalid CBE regs pointers for cpufreq\n");
> + of_node_put(cpu);
> return -EINVAL;
> }
I have taken another look at the implementation of this function.
I find that the second statement “return -EINVAL” would need related
source code adjustments.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/ppc_cbe_cpufreq.c?id=05d08e2995cbe6efdb993482ee0d38a77040861a#n96
How do you think about to complete the exception handling here?
Regards,
Markus
next prev parent reply other threads:[~2019-04-02 12:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 1:37 [PATCH 0/7] fix possible object reference leaks in cpufreq Wen Yang
2019-04-01 1:37 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-02 13:54 ` [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-08 10:21 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Viresh Kumar
2019-04-08 10:21 ` Viresh Kumar
2019-04-01 1:37 ` [PATCH 2/7] cpufreq: imx6q: " Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` [PATCH 3/7] cpufreq: kirkwood: " Wen Yang
2019-04-03 13:17 ` [3/7] " Markus Elfring
2019-04-03 13:17 ` Markus Elfring
2019-04-01 1:37 ` [PATCH 4/7] cpufreq: maple: " Wen Yang
2019-04-03 13:50 ` [4/7] cpufreq: maple: Checking implementation of maple_cpufreq_init() Markus Elfring
2019-04-03 13:50 ` Markus Elfring
2019-04-01 1:37 ` [PATCH 5/7] cpufreq/pasemi: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
2019-04-03 14:23 ` Markus Elfring
2019-04-03 14:23 ` Markus Elfring
2019-04-03 15:31 ` Dan Carpenter
2019-04-03 15:31 ` Dan Carpenter
2019-04-03 15:31 ` Dan Carpenter
2019-04-01 1:37 ` [PATCH 6/7] cpufreq: pmac32: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` Wen Yang
2019-04-01 1:37 ` [PATCH 7/7] cpufreq: ppc_cbe: " Wen Yang
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:50 ` Julia Lawall
2019-04-02 10:50 ` Julia Lawall
2019-04-02 12:50 ` Markus Elfring [this message]
2019-04-02 12:50 ` Markus Elfring
2019-04-02 13:15 ` Julia Lawall
2019-04-02 13:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ab8dd4-e997-1796-a522-863ff511bb58@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.