All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs
Date: Mon, 8 Apr 2019 19:07:47 +0200	[thread overview]
Message-ID: <20190408190747.12e3618b.cohuck@redhat.com> (raw)
In-Reply-To: <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com>

On Mon, 8 Apr 2019 13:02:12 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> On 03/01/2019 04:38 AM, Cornelia Huck wrote:
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call the cp accessors in
> > any case, so we can call them unconditionally.
> > 
> > While at it, also make sure that functions called from other parts
> > of the code return gracefully if the channel program structure
> > has not been initialized (even though that is a bug in the caller).
> > 
> > Reviewed-by: Eric Farman<farman@linux.ibm.com>
> > Signed-off-by: Cornelia Huck<cohuck@redhat.com>
> > ---  
> 
> Hi Connie,
> 
> My series of fixes for vfio-ccw depends on this patch as I would like to 
> call cp_free unconditionally :) (I had developed my code on top of your 
> patches).
> 
> Could we pick this patch up as well when/if you pick up my patch series? 
> I am in the process of sending out a v2.
> 
> Regarding this patch we could merge it as a stand alone patch, separate 
> from this series. And also the patch LGTM
> 
> Reviewed-by: Farhan Ali <alifm@linux.ibm.com>

Actually, I wanted to ask how people felt about merging this whole
series for the next release :) It would be one thing less on my plate...

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs
Date: Mon, 8 Apr 2019 19:07:47 +0200	[thread overview]
Message-ID: <20190408190747.12e3618b.cohuck@redhat.com> (raw)
In-Reply-To: <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com>

On Mon, 8 Apr 2019 13:02:12 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> On 03/01/2019 04:38 AM, Cornelia Huck wrote:
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call the cp accessors in
> > any case, so we can call them unconditionally.
> > 
> > While at it, also make sure that functions called from other parts
> > of the code return gracefully if the channel program structure
> > has not been initialized (even though that is a bug in the caller).
> > 
> > Reviewed-by: Eric Farman<farman@linux.ibm.com>
> > Signed-off-by: Cornelia Huck<cohuck@redhat.com>
> > ---  
> 
> Hi Connie,
> 
> My series of fixes for vfio-ccw depends on this patch as I would like to 
> call cp_free unconditionally :) (I had developed my code on top of your 
> patches).
> 
> Could we pick this patch up as well when/if you pick up my patch series? 
> I am in the process of sending out a v2.
> 
> Regarding this patch we could merge it as a stand alone patch, separate 
> from this series. And also the patch LGTM
> 
> Reviewed-by: Farhan Ali <alifm@linux.ibm.com>

Actually, I wanted to ask how people felt about merging this whole
series for the next release :) It would be one thing less on my plate...

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, Eric Farman <farman@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Halil Pasic <pasic@linux.ibm.com>,
	qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs
Date: Mon, 8 Apr 2019 19:07:47 +0200	[thread overview]
Message-ID: <20190408190747.12e3618b.cohuck@redhat.com> (raw)
Message-ID: <20190408170747.20wUYHBT0VqPR-xTOx2WbPVlBeU7JoJW_uv4uWofy-E@z> (raw)
In-Reply-To: <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com>

On Mon, 8 Apr 2019 13:02:12 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:

> On 03/01/2019 04:38 AM, Cornelia Huck wrote:
> > When we get a solicited interrupt, the start function may have
> > been cleared by a csch, but we still have a channel program
> > structure allocated. Make it safe to call the cp accessors in
> > any case, so we can call them unconditionally.
> > 
> > While at it, also make sure that functions called from other parts
> > of the code return gracefully if the channel program structure
> > has not been initialized (even though that is a bug in the caller).
> > 
> > Reviewed-by: Eric Farman<farman@linux.ibm.com>
> > Signed-off-by: Cornelia Huck<cohuck@redhat.com>
> > ---  
> 
> Hi Connie,
> 
> My series of fixes for vfio-ccw depends on this patch as I would like to 
> call cp_free unconditionally :) (I had developed my code on top of your 
> patches).
> 
> Could we pick this patch up as well when/if you pick up my patch series? 
> I am in the process of sending out a v2.
> 
> Regarding this patch we could merge it as a stand alone patch, separate 
> from this series. And also the patch LGTM
> 
> Reviewed-by: Farhan Ali <alifm@linux.ibm.com>

Actually, I wanted to ask how people felt about merging this whole
series for the next release :) It would be one thing less on my plate...


  reply	other threads:[~2019-04-08 17:07 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01  9:38 [PATCH v4 0/6] vfio-ccw: support hsch/csch (kernel part) Cornelia Huck
2019-03-01  9:38 ` [Qemu-devel] " Cornelia Huck
2019-03-01  9:38 ` [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs Cornelia Huck
2019-03-01  9:38   ` [Qemu-devel] " Cornelia Huck
2019-04-08 17:02   ` Farhan Ali
2019-04-08 17:02     ` [Qemu-devel] " Farhan Ali
2019-04-08 17:02     ` Farhan Ali
2019-04-08 17:07     ` Cornelia Huck [this message]
2019-04-08 17:07       ` Cornelia Huck
2019-04-08 17:07       ` Cornelia Huck
2019-04-08 17:19       ` Farhan Ali
2019-04-08 17:19         ` [Qemu-devel] " Farhan Ali
2019-04-08 17:19         ` Farhan Ali
2019-04-08 20:25       ` Eric Farman
2019-04-08 20:25         ` [Qemu-devel] " Eric Farman
2019-04-08 20:25         ` Eric Farman
2019-04-09 23:34       ` Halil Pasic
2019-04-09 23:34         ` Halil Pasic
2019-04-11  2:59         ` Eric Farman
2019-04-11  2:59           ` Eric Farman
2019-04-11 15:58           ` [qemu-s390x] " Halil Pasic
2019-04-11 15:58             ` [Qemu-devel] [qemu-s390x] " Halil Pasic
2019-04-11 15:58             ` Halil Pasic
2019-04-11 16:25             ` [qemu-s390x] [Qemu-devel] " Eric Farman
2019-04-11 16:25               ` [Qemu-devel] [qemu-s390x] " Eric Farman
2019-04-11 16:25               ` Eric Farman
2019-04-11 16:36               ` [qemu-s390x] [Qemu-devel] " Cornelia Huck
2019-04-11 16:36                 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2019-04-11 16:36                 ` Cornelia Huck
2019-04-11 18:07                 ` [qemu-s390x] [Qemu-devel] " Halil Pasic
2019-04-11 18:07                   ` [Qemu-devel] [qemu-s390x] " Halil Pasic
2019-04-11 18:07                   ` Halil Pasic
2019-04-11 21:27           ` [Qemu-devel] " Eric Farman
2019-04-11 21:27             ` Eric Farman
2019-04-12  8:14             ` Cornelia Huck
2019-04-12  8:14               ` Cornelia Huck
2019-03-01  9:38 ` [PATCH v4 2/6] vfio-ccw: rework ssch state handling Cornelia Huck
2019-03-01  9:38   ` [Qemu-devel] " Cornelia Huck
2019-03-08 22:18   ` Eric Farman
2019-03-08 22:18     ` [Qemu-devel] " Eric Farman
2019-03-11  9:47     ` Cornelia Huck
2019-03-11  9:47       ` [Qemu-devel] " Cornelia Huck
2019-03-01  9:38 ` [PATCH v4 3/6] vfio-ccw: protect the I/O region Cornelia Huck
2019-03-01  9:38   ` [Qemu-devel] " Cornelia Huck
2019-03-01  9:39 ` [PATCH v4 4/6] vfio-ccw: add capabilities chain Cornelia Huck
2019-03-01  9:39   ` [Qemu-devel] " Cornelia Huck
2019-04-15 14:40   ` Eric Farman
2019-04-15 14:40     ` [Qemu-devel] " Eric Farman
2019-04-15 14:40     ` Eric Farman
2019-04-15 15:24   ` Farhan Ali
2019-04-15 15:24     ` [Qemu-devel] " Farhan Ali
2019-04-15 15:24     ` Farhan Ali
2019-03-01  9:39 ` [PATCH v4 5/6] s390/cio: export hsch to modules Cornelia Huck
2019-03-01  9:39   ` [Qemu-devel] " Cornelia Huck
2019-03-01  9:39 ` [PATCH v4 6/6] vfio-ccw: add handling for async channel instructions Cornelia Huck
2019-03-01  9:39   ` [Qemu-devel] " Cornelia Huck
2019-04-15 14:56   ` Eric Farman
2019-04-15 14:56     ` [Qemu-devel] " Eric Farman
2019-04-15 14:56     ` Eric Farman
2019-04-15 15:25   ` Farhan Ali
2019-04-15 15:25     ` [Qemu-devel] " Farhan Ali
2019-04-15 15:25     ` Farhan Ali
2019-03-07 21:28 ` [PATCH v4 0/6] vfio-ccw: support hsch/csch (kernel part) Eric Farman
2019-03-07 21:28   ` [Qemu-devel] " Eric Farman
2019-03-12 14:31 ` Cornelia Huck
2019-04-15 11:51 ` Cornelia Huck
2019-04-15 11:51   ` [Qemu-devel] " Cornelia Huck
2019-04-15 11:51   ` Cornelia Huck
2019-04-15 16:43 ` Cornelia Huck
2019-04-15 16:43   ` [Qemu-devel] " Cornelia Huck
2019-04-15 16:43   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408190747.12e3618b.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=alifm@linux.ibm.com \
    --cc=farman@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.