* [PATCH] snd/hda: Only get/put display_power once
@ 2019-04-10 8:17 Chris Wilson
2019-04-10 8:22 ` Chris Wilson
` (8 more replies)
0 siblings, 9 replies; 15+ messages in thread
From: Chris Wilson @ 2019-04-10 8:17 UTC (permalink / raw)
To: intel-gfx; +Cc: Takashi Iwai
While we only allow a single display power reference, the current
acquisition/release is racy and a direct call may run concurrently with
a runtime-pm worker. Prevent the double unreference by atomically
tracking the display_power_active cookie.
Testcase: igt/i915_pm_rpm/module-reload #glk-dsi
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Imre Deak <imre.deak@intel.com>
---
sound/hda/hdac_component.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c
index 13915fdc6a54..f0fd0d83c90e 100644
--- a/sound/hda/hdac_component.c
+++ b/sound/hda/hdac_component.c
@@ -66,6 +66,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_set_codec_wakeup);
void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable)
{
struct drm_audio_component *acomp = bus->audio_component;
+ unsigned long cookie;
dev_dbg(bus->dev, "display power %s\n",
enable ? "enable" : "disable");
@@ -78,26 +79,22 @@ void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable)
return;
if (bus->display_power_status) {
- if (!bus->display_power_active) {
- unsigned long cookie = -1;
-
- if (acomp->ops->get_power)
- cookie = acomp->ops->get_power(acomp->dev);
+ cookie = -1;
+ if (acomp->ops->get_power)
+ cookie = acomp->ops->get_power(acomp->dev);
+ if (!cmpxchg(&bus->display_power_active, 0, cookie)) {
snd_hdac_set_codec_wakeup(bus, true);
snd_hdac_set_codec_wakeup(bus, false);
- bus->display_power_active = cookie;
+ cookie = 0;
}
} else {
- if (bus->display_power_active) {
- unsigned long cookie = bus->display_power_active;
+ cookie = xchg(&bus->display_power_active, 0);
+ }
- if (acomp->ops->put_power)
- acomp->ops->put_power(acomp->dev, cookie);
+ if (cookie && acomp->ops->put_power)
+ acomp->ops->put_power(acomp->dev, cookie);
- bus->display_power_active = 0;
- }
- }
}
EXPORT_SYMBOL_GPL(snd_hdac_display_power);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson @ 2019-04-10 8:22 ` Chris Wilson 2019-04-10 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork ` (7 subsequent siblings) 8 siblings, 0 replies; 15+ messages in thread From: Chris Wilson @ 2019-04-10 8:22 UTC (permalink / raw) To: intel-gfx; +Cc: Takashi Iwai Quoting Chris Wilson (2019-04-10 09:17:33) > While we only allow a single display power reference, the current > acquisition/release is racy and a direct call may run concurrently with > a runtime-pm worker. Prevent the double unreference by atomically > tracking the display_power_active cookie. I just get the feeling this is elaborate paper and the problem is that we shouldn't be doing a double-free in the first place. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.BAT: success for snd/hda: Only get/put display_power once 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson 2019-04-10 8:22 ` Chris Wilson @ 2019-04-10 9:24 ` Patchwork 2019-04-10 10:09 ` [PATCH] " Takashi Iwai ` (6 subsequent siblings) 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 9:24 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once URL : https://patchwork.freedesktop.org/series/59267/ State : success == Summary == CI Bug Log - changes from CI_DRM_5897 -> Patchwork_12749 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59267/revisions/1/mbox/ Known issues ------------ Here are the changes found in Patchwork_12749 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@query-info: - fi-glk-dsi: NOTRUN -> SKIP [fdo#109271] +17 * igt@amdgpu/amd_cs_nop@sync-fork-compute0: - fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17 * igt@gem_close_race@basic-threads: - fi-skl-6770hq: PASS -> DMESG-WARN [fdo#105541] * igt@gem_exec_basic@gtt-bsd1: - fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7 * igt@gem_exec_parse@basic-rejected: - fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1 * igt@gem_exec_store@basic-bsd1: - fi-kbl-r: NOTRUN -> SKIP [fdo#109271] +41 * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718] * igt@i915_selftest@live_contexts: - fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569] * igt@i915_selftest@live_evict: - fi-bsw-kefka: PASS -> DMESG-WARN [fdo#107709] * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720] * igt@i915_selftest@live_hangcheck: - fi-bxt-dsi: PASS -> INCOMPLETE [fdo#103927] * igt@kms_busy@basic-flip-a: - fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1 * igt@kms_busy@basic-flip-c: - fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_chamelium@hdmi-crc-fast: - fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62 - fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +52 * igt@kms_chamelium@hdmi-edid-read: - fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8 * igt@kms_force_connector_basic@prune-stale-modes: - fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3 * igt@kms_frontbuffer_tracking@basic: - fi-icl-u3: NOTRUN -> FAIL [fdo#103167] * igt@runner@aborted: - fi-bsw-kefka: NOTRUN -> FAIL [fdo#107709] - fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720] #### Possible fixes #### * igt@gem_ctx_exec@basic: - fi-icl-u3: INCOMPLETE [fdo#107713] -> PASS * igt@i915_pm_rpm@module-reload: - fi-glk-dsi: INCOMPLETE [fdo#103359] / [k.org#198133] -> PASS * igt@i915_selftest@live_contexts: - fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS - fi-skl-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (44 -> 42) ------------------------------ Additional (3): fi-byt-j1900 fi-kbl-r fi-bsw-n3050 Missing (5): fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-pnv-d510 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_5897 -> Patchwork_12749 CI_DRM_5897: 7d07e025e78603d6270bc115fdb6c1efea6e66a5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4934: dc4f45eb6874331daec870dc1e4cfc3ac5c49311 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12749: 8c1912f8707e3d4b7872e50990ae26598c974efa @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 8c1912f8707e snd/hda: Only get/put display_power once == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12749/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson 2019-04-10 8:22 ` Chris Wilson 2019-04-10 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-04-10 10:09 ` Takashi Iwai 2019-04-10 10:24 ` Chris Wilson 2019-04-10 10:38 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev2) Patchwork ` (5 subsequent siblings) 8 siblings, 1 reply; 15+ messages in thread From: Takashi Iwai @ 2019-04-10 10:09 UTC (permalink / raw) To: Chris Wilson; +Cc: Takashi Iwai, intel-gfx On Wed, 10 Apr 2019 10:17:33 +0200, Chris Wilson wrote: > > While we only allow a single display power reference, the current > acquisition/release is racy and a direct call may run concurrently with > a runtime-pm worker. Prevent the double unreference by atomically > tracking the display_power_active cookie. > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Takashi Iwai <tiwai@suse.de> > Cc: Imre Deak <imre.deak@intel.com> I rather prefer a more straightforward conversion, e.g. something like below. Checking the returned cookie as the state flag is not quite intuitive, so revive the boolean state flag, and handle it atomically. thanks, Takashi --- a/include/sound/hdaudio.h +++ b/include/sound/hdaudio.h @@ -367,7 +367,8 @@ struct hdac_bus { /* DRM component interface */ struct drm_audio_component *audio_component; long display_power_status; - unsigned long display_power_active; + bool display_power_active; + unsigned long display_cookie; /* parameters required for enhanced capabilities */ int num_streams; diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index 13915fdc6a54..da20f439578a 100644 --- a/sound/hda/hdac_component.c +++ b/sound/hda/hdac_component.c @@ -78,24 +78,19 @@ void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable) return; if (bus->display_power_status) { - if (!bus->display_power_active) { - unsigned long cookie = -1; - + if (!cmpxchg(&bus->display_power_active, false, true)) { if (acomp->ops->get_power) - cookie = acomp->ops->get_power(acomp->dev); + bus->display_cookie = + acomp->ops->get_power(acomp->dev); snd_hdac_set_codec_wakeup(bus, true); snd_hdac_set_codec_wakeup(bus, false); - bus->display_power_active = cookie; } } else { - if (bus->display_power_active) { - unsigned long cookie = bus->display_power_active; - + if (xchg(&bus->display_power_active, false)) { if (acomp->ops->put_power) - acomp->ops->put_power(acomp->dev, cookie); - - bus->display_power_active = 0; + acomp->ops->put_power(acomp->dev, + bus->display_cookie); } } } _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 10:09 ` [PATCH] " Takashi Iwai @ 2019-04-10 10:24 ` Chris Wilson 2019-04-10 10:44 ` Takashi Iwai 0 siblings, 1 reply; 15+ messages in thread From: Chris Wilson @ 2019-04-10 10:24 UTC (permalink / raw) Cc: Takashi Iwai, intel-gfx Quoting Takashi Iwai (2019-04-10 11:09:47) > On Wed, 10 Apr 2019 10:17:33 +0200, > Chris Wilson wrote: > > > > While we only allow a single display power reference, the current > > acquisition/release is racy and a direct call may run concurrently with > > a runtime-pm worker. Prevent the double unreference by atomically > > tracking the display_power_active cookie. > > > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Takashi Iwai <tiwai@suse.de> > > Cc: Imre Deak <imre.deak@intel.com> > > I rather prefer a more straightforward conversion, e.g. something like > below. Checking the returned cookie as the state flag is not quite > intuitive, so revive the boolean state flag, and handle it > atomically. Access to the cookie itself is not atomic there, and theoretically there could be a get/put/get running concurrently. Are you sure don't want a refcount and lock here? :) Your call. For the case CI is hitting, it should do the trick (as we are only seeing the race on put/put I think). CI will answer in a hour or two. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 10:24 ` Chris Wilson @ 2019-04-10 10:44 ` Takashi Iwai 2019-04-10 11:03 ` Takashi Iwai 0 siblings, 1 reply; 15+ messages in thread From: Takashi Iwai @ 2019-04-10 10:44 UTC (permalink / raw) To: Chris Wilson; +Cc: Takashi Iwai, intel-gfx On Wed, 10 Apr 2019 12:24:24 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > On Wed, 10 Apr 2019 10:17:33 +0200, > > Chris Wilson wrote: > > > > > > While we only allow a single display power reference, the current > > > acquisition/release is racy and a direct call may run concurrently with > > > a runtime-pm worker. Prevent the double unreference by atomically > > > tracking the display_power_active cookie. > > > > > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > Cc: Takashi Iwai <tiwai@suse.de> > > > Cc: Imre Deak <imre.deak@intel.com> > > > > I rather prefer a more straightforward conversion, e.g. something like > > below. Checking the returned cookie as the state flag is not quite > > intuitive, so revive the boolean state flag, and handle it > > atomically. > > Access to the cookie itself is not atomic there, and theoretically > there could be a get/put/get running concurrently. Are you sure don't > want a refcount and lock here? :) The refcount is what we want to reduce, so the suitable option would be a (yet another) mutex although the cmpxchg() should be enough for normal cases. > Your call. For the case CI is hitting, it should do the trick (as we are > only seeing the race on put/put I think). CI will answer in a hour or > two. OK, once when it seems working, I'll respin a patch with a mutex instead. We have already a one that is used for the link state change, and this can be reused. thanks, Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 10:44 ` Takashi Iwai @ 2019-04-10 11:03 ` Takashi Iwai 2019-04-10 13:07 ` Chris Wilson 0 siblings, 1 reply; 15+ messages in thread From: Takashi Iwai @ 2019-04-10 11:03 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx On Wed, 10 Apr 2019 12:44:49 +0200, Takashi Iwai wrote: > > On Wed, 10 Apr 2019 12:24:24 +0200, > Chris Wilson wrote: > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > Chris Wilson wrote: > > > > > > > > While we only allow a single display power reference, the current > > > > acquisition/release is racy and a direct call may run concurrently with > > > > a runtime-pm worker. Prevent the double unreference by atomically > > > > tracking the display_power_active cookie. > > > > > > > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > Cc: Takashi Iwai <tiwai@suse.de> > > > > Cc: Imre Deak <imre.deak@intel.com> > > > > > > I rather prefer a more straightforward conversion, e.g. something like > > > below. Checking the returned cookie as the state flag is not quite > > > intuitive, so revive the boolean state flag, and handle it > > > atomically. > > > > Access to the cookie itself is not atomic there, and theoretically > > there could be a get/put/get running concurrently. Are you sure don't > > want a refcount and lock here? :) > > The refcount is what we want to reduce, so the suitable option would > be a (yet another) mutex although the cmpxchg() should be enough for > normal cases. > > > Your call. For the case CI is hitting, it should do the trick (as we are > > only seeing the race on put/put I think). CI will answer in a hour or > > two. > > OK, once when it seems working, I'll respin a patch with a mutex > instead. We have already a one that is used for the link state > change, and this can be reused. It's even simpler, so maybe this is a better way to go... If this is confirmed to work, feel free to queue via drm tree. I can't apply this because this is on top of your recent cookie and sub-component changes that aren't on sound git tree (yet). thanks, Takashi -- 8< -- From: Takashi Iwai <tiwai@suse.de> Subject: [PATCH] ALSA: hda: Fix racy display power access snd_hdac_display_power() doesn't handle the concurrent calls carefully enough, and it may lead to the doubly get_power or put_power calls, when a runtime PM and an async work get called in racy way. This patch addresses it by reusing the bus->lock mutex that has been used for protecting the link state change in ext bus code, so that it can protect against racy display state changes. The initialization of bus->lock was moved from snd_hdac_ext_bus_init() to snd_hdac_bus_init() as well accordingly. Testcase: igt/i915_pm_rpm/module-reload #glk-dsi Reported-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/hda/ext/hdac_ext_bus.c | 1 - sound/hda/hdac_bus.c | 1 + sound/hda/hdac_component.c | 6 +++++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c index 9c37d9af3023..ec7715c6b0c0 100644 --- a/sound/hda/ext/hdac_ext_bus.c +++ b/sound/hda/ext/hdac_ext_bus.c @@ -107,7 +107,6 @@ int snd_hdac_ext_bus_init(struct hdac_bus *bus, struct device *dev, INIT_LIST_HEAD(&bus->hlink_list); bus->idx = idx++; - mutex_init(&bus->lock); bus->cmd_dma_state = true; return 0; diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c index 012305177f68..ad8eee08013f 100644 --- a/sound/hda/hdac_bus.c +++ b/sound/hda/hdac_bus.c @@ -38,6 +38,7 @@ int snd_hdac_bus_init(struct hdac_bus *bus, struct device *dev, INIT_WORK(&bus->unsol_work, snd_hdac_bus_process_unsol_events); spin_lock_init(&bus->reg_lock); mutex_init(&bus->cmd_mutex); + mutex_init(&bus->lock); bus->irq = -1; return 0; } diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index 13915fdc6a54..dfe7e755f594 100644 --- a/sound/hda/hdac_component.c +++ b/sound/hda/hdac_component.c @@ -69,13 +69,15 @@ void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable) dev_dbg(bus->dev, "display power %s\n", enable ? "enable" : "disable"); + + mutex_lock(&bus->lock); if (enable) set_bit(idx, &bus->display_power_status); else clear_bit(idx, &bus->display_power_status); if (!acomp || !acomp->ops) - return; + goto unlock; if (bus->display_power_status) { if (!bus->display_power_active) { @@ -98,6 +100,8 @@ void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable) bus->display_power_active = 0; } } + unlock: + mutex_unlock(&bus->lock); } EXPORT_SYMBOL_GPL(snd_hdac_display_power); -- 2.16.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 11:03 ` Takashi Iwai @ 2019-04-10 13:07 ` Chris Wilson 2019-04-10 13:24 ` Takashi Iwai 0 siblings, 1 reply; 15+ messages in thread From: Chris Wilson @ 2019-04-10 13:07 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx Quoting Takashi Iwai (2019-04-10 12:03:22) > On Wed, 10 Apr 2019 12:44:49 +0200, > Takashi Iwai wrote: > > > > On Wed, 10 Apr 2019 12:24:24 +0200, > > Chris Wilson wrote: > > > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > > Chris Wilson wrote: > > > > > > > > > > While we only allow a single display power reference, the current > > > > > acquisition/release is racy and a direct call may run concurrently with > > > > > a runtime-pm worker. Prevent the double unreference by atomically > > > > > tracking the display_power_active cookie. > > > > > > > > > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > Cc: Takashi Iwai <tiwai@suse.de> > > > > > Cc: Imre Deak <imre.deak@intel.com> > > > > > > > > I rather prefer a more straightforward conversion, e.g. something like > > > > below. Checking the returned cookie as the state flag is not quite > > > > intuitive, so revive the boolean state flag, and handle it > > > > atomically. > > > > > > Access to the cookie itself is not atomic there, and theoretically > > > there could be a get/put/get running concurrently. Are you sure don't > > > want a refcount and lock here? :) > > > > The refcount is what we want to reduce, so the suitable option would > > be a (yet another) mutex although the cmpxchg() should be enough for > > normal cases. > > > > > Your call. For the case CI is hitting, it should do the trick (as we are > > > only seeing the race on put/put I think). CI will answer in a hour or > > > two. > > > > OK, once when it seems working, I'll respin a patch with a mutex > > instead. We have already a one that is used for the link state > > change, and this can be reused. > > It's even simpler, so maybe this is a better way to go... > > If this is confirmed to work, feel free to queue via drm tree. > I can't apply this because this is on top of your recent cookie and > sub-component changes that aren't on sound git tree (yet). Success \o/ Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Ok, we'll plonk it in dinq, but I think it should apply to sound.git? Looks fairly separate. Anyway that can all be resolved in a later merge if required. Thanks, -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] snd/hda: Only get/put display_power once 2019-04-10 13:07 ` Chris Wilson @ 2019-04-10 13:24 ` Takashi Iwai 0 siblings, 0 replies; 15+ messages in thread From: Takashi Iwai @ 2019-04-10 13:24 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx On Wed, 10 Apr 2019 15:07:28 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 12:03:22) > > On Wed, 10 Apr 2019 12:44:49 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 10 Apr 2019 12:24:24 +0200, > > > Chris Wilson wrote: > > > > > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > > > Chris Wilson wrote: > > > > > > > > > > > > While we only allow a single display power reference, the current > > > > > > acquisition/release is racy and a direct call may run concurrently with > > > > > > a runtime-pm worker. Prevent the double unreference by atomically > > > > > > tracking the display_power_active cookie. > > > > > > > > > > > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > > > Cc: Takashi Iwai <tiwai@suse.de> > > > > > > Cc: Imre Deak <imre.deak@intel.com> > > > > > > > > > > I rather prefer a more straightforward conversion, e.g. something like > > > > > below. Checking the returned cookie as the state flag is not quite > > > > > intuitive, so revive the boolean state flag, and handle it > > > > > atomically. > > > > > > > > Access to the cookie itself is not atomic there, and theoretically > > > > there could be a get/put/get running concurrently. Are you sure don't > > > > want a refcount and lock here? :) > > > > > > The refcount is what we want to reduce, so the suitable option would > > > be a (yet another) mutex although the cmpxchg() should be enough for > > > normal cases. > > > > > > > Your call. For the case CI is hitting, it should do the trick (as we are > > > > only seeing the race on put/put I think). CI will answer in a hour or > > > > two. > > > > > > OK, once when it seems working, I'll respin a patch with a mutex > > > instead. We have already a one that is used for the link state > > > change, and this can be reused. > > > > It's even simpler, so maybe this is a better way to go... > > > > If this is confirmed to work, feel free to queue via drm tree. > > I can't apply this because this is on top of your recent cookie and > > sub-component changes that aren't on sound git tree (yet). > > Success \o/ > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > Ok, we'll plonk it in dinq, but I think it should apply to sound.git? > Looks fairly separate. Indeed, it's applicable, so I'm going to queue via sound tree. I thought it would conflict but that was about the previous version fiddling with cmpxchg(). This one is simpler, yeah. > Anyway that can all be resolved in a later merge if required. Sure, I guess it must be trivial, if any. Thanks! Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev2) 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (2 preceding siblings ...) 2019-04-10 10:09 ` [PATCH] " Takashi Iwai @ 2019-04-10 10:38 ` Patchwork 2019-04-10 11:08 ` ✓ Fi.CI.BAT: success " Patchwork ` (4 subsequent siblings) 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 10:38 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once (rev2) URL : https://patchwork.freedesktop.org/series/59267/ State : warning == Summary == $ dim checkpatch origin/drm-tip 156ac646b015 snd/hda: Only get/put display_power once -:76: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 0 checks, 39 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.BAT: success for snd/hda: Only get/put display_power once (rev2) 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (3 preceding siblings ...) 2019-04-10 10:38 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev2) Patchwork @ 2019-04-10 11:08 ` Patchwork 2019-04-10 12:29 ` ✗ Fi.CI.IGT: failure for snd/hda: Only get/put display_power once Patchwork ` (3 subsequent siblings) 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 11:08 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once (rev2) URL : https://patchwork.freedesktop.org/series/59267/ State : success == Summary == CI Bug Log - changes from CI_DRM_5898 -> Patchwork_12750 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59267/revisions/2/mbox/ Known issues ------------ Here are the changes found in Patchwork_12750 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@query-info: - fi-glk-dsi: NOTRUN -> SKIP [fdo#109271] +17 * igt@i915_module_load@reload: - fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718] * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720] * igt@kms_busy@basic-flip-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +29 * igt@runner@aborted: - fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720] #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS * igt@i915_pm_rpm@module-reload: - fi-glk-dsi: DMESG-WARN [fdo#105538] / [fdo#107732] / [fdo#109513] -> PASS #### Warnings #### * igt@i915_selftest@live_contexts: - fi-icl-y: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569] [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105538]: https://bugs.freedesktop.org/show_bug.cgi?id=105538 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513 [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 Participating hosts (49 -> 42) ------------------------------ Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_5898 -> Patchwork_12750 CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12750: 156ac646b01536626ddabe02a52624df9e300461 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 156ac646b015 snd/hda: Only get/put display_power once == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12750/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✗ Fi.CI.IGT: failure for snd/hda: Only get/put display_power once 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (4 preceding siblings ...) 2019-04-10 11:08 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-04-10 12:29 ` Patchwork 2019-04-10 12:34 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev3) Patchwork ` (2 subsequent siblings) 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 12:29 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once URL : https://patchwork.freedesktop.org/series/59267/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5897_full -> Patchwork_12749_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_12749_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_12749_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12749_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane_lowres@pipe-b-tiling-y: - shard-apl: NOTRUN -> DMESG-WARN Known issues ------------ Here are the changes found in Patchwork_12749_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_stolen@stolen-clear: - shard-iclb: NOTRUN -> SKIP [fdo#109277] +1 * igt@gem_workarounds@suspend-resume-context: - shard-apl: NOTRUN -> DMESG-WARN [fdo#108566] +4 * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-iclb: NOTRUN -> SKIP [fdo#109506] * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing: - shard-apl: NOTRUN -> FAIL [fdo#109660] * igt@kms_atomic_transition@6x-modeset-transitions: - shard-iclb: NOTRUN -> SKIP [fdo#109278] +1 * igt@kms_atomic_transition@6x-modeset-transitions-nonblocking: - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +24 * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-apl: PASS -> INCOMPLETE [fdo#103927] * igt@kms_chamelium@vga-edid-read: - shard-iclb: NOTRUN -> SKIP [fdo#109284] * igt@kms_color@pipe-b-legacy-gamma-reset: - shard-snb: PASS -> SKIP [fdo#109271] * igt@kms_content_protection@atomic: - shard-iclb: NOTRUN -> SKIP [fdo#109300] * igt@kms_content_protection@atomic-dpms: - shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] * igt@kms_crtc_background_color: - shard-iclb: NOTRUN -> SKIP [fdo#109305] * igt@kms_cursor_crc@cursor-64x21-random: - shard-glk: NOTRUN -> FAIL [fdo#103232] * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible: - shard-iclb: NOTRUN -> SKIP [fdo#109274] +2 * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: PASS -> FAIL [fdo#105363] * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt: - shard-iclb: PASS -> FAIL [fdo#103167] / [fdo#109960] +1 * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> SKIP [fdo#109271] +172 * igt@kms_frontbuffer_tracking@fbc-stridechange: - shard-iclb: PASS -> FAIL [fdo#103167] +5 * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-wc: - shard-iclb: PASS -> FAIL [fdo#109247] +6 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-skl: PASS -> FAIL [fdo#105682] / [fdo#108040] * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt: - shard-glk: NOTRUN -> SKIP [fdo#109271] +7 * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-gtt: - shard-iclb: NOTRUN -> SKIP [fdo#109280] +4 * igt@kms_lease@setcrtc_implicit_plane: - shard-apl: NOTRUN -> FAIL [fdo#110281] * igt@kms_panel_fitting@legacy: - shard-skl: NOTRUN -> FAIL [fdo#105456] * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +13 * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping: - shard-glk: PASS -> SKIP [fdo#109271] * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-apl: PASS -> DMESG-WARN [fdo#108566] +3 * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +1 * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-skl: NOTRUN -> FAIL [fdo#108145] +1 * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: PASS -> FAIL [fdo#108145] * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-apl: NOTRUN -> FAIL [fdo#108145] +7 * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: PASS -> FAIL [fdo#103166] * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping: - shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278] +1 * igt@kms_psr@psr2_cursor_render: - shard-iclb: PASS -> SKIP [fdo#109441] +1 * igt@kms_psr@sprite_render: - shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +1 * igt@kms_setmode@basic: - shard-apl: NOTRUN -> FAIL [fdo#99912] - shard-kbl: PASS -> FAIL [fdo#99912] * igt@kms_tv_load_detect@load-detect: - shard-iclb: NOTRUN -> SKIP [fdo#109309] * igt@perf_pmu@busy-accuracy-50-vcs1: - shard-iclb: NOTRUN -> SKIP [fdo#109276] +7 * igt@prime_vgem@sync-bsd1: - shard-apl: NOTRUN -> SKIP [fdo#109271] +314 #### Possible fixes #### * igt@gem_mmap_gtt@forked-big-copy-xy: - shard-iclb: TIMEOUT [fdo#109673] -> PASS * igt@gem_ppgtt@blt-vs-render-ctx0: - shard-iclb: INCOMPLETE [fdo#109801] -> PASS +1 * igt@i915_pm_rpm@system-suspend-execbuf: - shard-glk: DMESG-WARN [fdo#109513] -> PASS * igt@kms_cursor_crc@cursor-64x64-suspend: - shard-kbl: DMESG-WARN [fdo#108566] -> PASS * igt@kms_cursor_legacy@cursor-vs-flip-varying-size: - shard-iclb: FAIL [fdo#103355] -> PASS +2 * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: FAIL [fdo#102887] -> PASS * igt@kms_flip@flip-vs-expired-vblank: - shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS * igt@kms_flip@flip-vs-rmfb: - shard-iclb: INCOMPLETE [fdo#107713] -> PASS * igt@kms_flip@flip-vs-suspend: - shard-iclb: FAIL [fdo#103375] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt: - shard-iclb: FAIL [fdo#103167] -> PASS +1 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt: - shard-iclb: FAIL [fdo#109247] -> PASS +17 * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: FAIL [fdo#107815] -> PASS * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format: - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS * igt@kms_psr@cursor_plane_onoff: - shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS * igt@kms_psr@no_drrs: - shard-iclb: FAIL [fdo#108341] -> PASS * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: SKIP [fdo#109441] -> PASS +3 * igt@kms_rotation_crc@multiplane-rotation-cropping-top: - shard-kbl: FAIL [fdo#109016] -> PASS #### Warnings #### * igt@kms_rotation_crc@multiplane-rotation: - shard-kbl: FAIL [fdo#109016] -> DMESG-FAIL [fdo#105763] * igt@runner@aborted: - shard-glk: ( 2 FAIL ) [fdo#109373] / [k.org#202321] -> FAIL [fdo#109373] / [k.org#202321] [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105456]: https://bugs.freedesktop.org/show_bug.cgi?id=105456 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763 [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016 [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109305]: https://bugs.freedesktop.org/show_bug.cgi?id=109305 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513 [fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660 [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 [fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801 [fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960 [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215 [fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281 [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (10 -> 9) ------------------------------ Missing (1): shard-hsw Build changes ------------- * Linux: CI_DRM_5897 -> Patchwork_12749 CI_DRM_5897: 7d07e025e78603d6270bc115fdb6c1efea6e66a5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4934: dc4f45eb6874331daec870dc1e4cfc3ac5c49311 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12749: 8c1912f8707e3d4b7872e50990ae26598c974efa @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12749/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev3) 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (5 preceding siblings ...) 2019-04-10 12:29 ` ✗ Fi.CI.IGT: failure for snd/hda: Only get/put display_power once Patchwork @ 2019-04-10 12:34 ` Patchwork 2019-04-10 13:03 ` ✓ Fi.CI.BAT: success " Patchwork 2019-04-10 18:06 ` ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 12:34 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once (rev3) URL : https://patchwork.freedesktop.org/series/59267/ State : warning == Summary == $ dim checkpatch origin/drm-tip 95d66eed4e0b snd/hda: Only get/put display_power once -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: > > > > acquisition/release is racy and a direct call may run concurrently with total: 0 errors, 1 warnings, 0 checks, 38 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.BAT: success for snd/hda: Only get/put display_power once (rev3) 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (6 preceding siblings ...) 2019-04-10 12:34 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev3) Patchwork @ 2019-04-10 13:03 ` Patchwork 2019-04-10 18:06 ` ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 13:03 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once (rev3) URL : https://patchwork.freedesktop.org/series/59267/ State : success == Summary == CI Bug Log - changes from CI_DRM_5898 -> Patchwork_12752 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59267/revisions/3/mbox/ Known issues ------------ Here are the changes found in Patchwork_12752 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@query-info: - fi-glk-dsi: NOTRUN -> SKIP [fdo#109271] +17 * igt@gem_exec_basic@gtt-bsd2: - fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57 * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720] * igt@kms_busy@basic-flip-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] - fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_frontbuffer_tracking@basic: - fi-byt-clapper: NOTRUN -> FAIL [fdo#103167] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-c: - fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +48 * igt@kms_pipe_crc_basic@read-crc-pipe-a: - fi-byt-clapper: NOTRUN -> FAIL [fdo#107362] * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362] * igt@kms_psr@cursor_plane_move: - fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +37 * igt@runner@aborted: - fi-apl-guc: NOTRUN -> FAIL [fdo#108622] / [fdo#109720] #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS * igt@i915_pm_rpm@module-reload: - fi-glk-dsi: DMESG-WARN [fdo#105538] / [fdo#107732] / [fdo#109513] -> PASS * igt@i915_selftest@live_hangcheck: - fi-bxt-dsi: INCOMPLETE [fdo#103927] -> PASS #### Warnings #### * igt@i915_selftest@live_contexts: - fi-icl-y: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569] [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105538]: https://bugs.freedesktop.org/show_bug.cgi?id=105538 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513 [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 Participating hosts (49 -> 43) ------------------------------ Additional (2): fi-byt-clapper fi-skl-6260u Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_5898 -> Patchwork_12752 CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12752: 95d66eed4e0bad29cef567574e82e18dbb3a4d27 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 95d66eed4e0b snd/hda: Only get/put display_power once == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12752/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✓ Fi.CI.IGT: success for snd/hda: Only get/put display_power once (rev3) 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson ` (7 preceding siblings ...) 2019-04-10 13:03 ` ✓ Fi.CI.BAT: success " Patchwork @ 2019-04-10 18:06 ` Patchwork 8 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-04-10 18:06 UTC (permalink / raw) To: Takashi Iwai; +Cc: intel-gfx == Series Details == Series: snd/hda: Only get/put display_power once (rev3) URL : https://patchwork.freedesktop.org/series/59267/ State : success == Summary == CI Bug Log - changes from CI_DRM_5898_full -> Patchwork_12752_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_12752_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_pread@stolen-snoop: - shard-iclb: NOTRUN -> SKIP [fdo#109277] +2 * igt@gem_pwrite@huge-gtt-fbr: - shard-iclb: NOTRUN -> SKIP [fdo#109290] * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - shard-iclb: NOTRUN -> SKIP [fdo#109308] * igt@i915_pm_rpm@i2c: - shard-skl: PASS -> INCOMPLETE [fdo#107807] +1 * igt@i915_pm_rpm@pm-tiling: - shard-skl: NOTRUN -> INCOMPLETE [fdo#107807] * igt@i915_pm_rps@min-max-config-loaded: - shard-iclb: NOTRUN -> FAIL [fdo#108059] * igt@i915_selftest@live_workarounds: - shard-iclb: PASS -> DMESG-FAIL [fdo#108954] * igt@kms_atomic_transition@4x-modeset-transitions: - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16 * igt@kms_atomic_transition@plane-toggle-modeset-transition: - shard-apl: PASS -> INCOMPLETE [fdo#103927] * igt@kms_busy@extended-modeset-hang-oldfb-render-e: - shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3 * igt@kms_busy@extended-pageflip-hang-oldfb-render-d: - shard-iclb: NOTRUN -> SKIP [fdo#109278] +7 * igt@kms_chamelium@hdmi-cmp-nv61: - shard-iclb: NOTRUN -> SKIP [fdo#109284] +4 * igt@kms_color@pipe-a-ctm-max: - shard-iclb: NOTRUN -> FAIL [fdo#108147] * igt@kms_content_protection@legacy: - shard-iclb: NOTRUN -> SKIP [fdo#109300] - shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] * igt@kms_cursor_crc@cursor-512x512-sliding: - shard-iclb: NOTRUN -> SKIP [fdo#109279] * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy: - shard-iclb: NOTRUN -> SKIP [fdo#109274] +4 * igt@kms_fbcon_fbt@psr: - shard-iclb: NOTRUN -> FAIL [fdo#103833] * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: PASS -> FAIL [fdo#105363] * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: NOTRUN -> FAIL [fdo#105363] - shard-apl: PASS -> FAIL [fdo#102887] / [fdo#105363] * igt@kms_flip@flip-vs-suspend-interruptible: - shard-skl: PASS -> INCOMPLETE [fdo#109507] * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-iclb: PASS -> FAIL [fdo#103167] +1 * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: - shard-iclb: NOTRUN -> SKIP [fdo#109280] +24 * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move: - shard-apl: NOTRUN -> SKIP [fdo#109271] +90 * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt: - shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247] * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu: - shard-iclb: PASS -> FAIL [fdo#109247] +12 * igt@kms_lease@cursor_implicit_plane: - shard-apl: NOTRUN -> FAIL [fdo#110278] * igt@kms_pipe_crc_basic@hang-read-crc-pipe-e: - shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6 * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - shard-kbl: PASS -> DMESG-WARN [fdo#108566] +1 * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max: - shard-skl: NOTRUN -> FAIL [fdo#108145] +2 * igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb: - shard-apl: NOTRUN -> FAIL [fdo#108145] +1 * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: NOTRUN -> FAIL [fdo#107815] * igt@kms_psr2_su@frontbuffer: - shard-iclb: NOTRUN -> SKIP [fdo#109642] * igt@kms_psr@cursor_mmap_gtt: - shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +3 * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: NOTRUN -> SKIP [fdo#109441] +1 * igt@kms_rotation_crc@bad-pixel-format: - shard-iclb: NOTRUN -> SKIP [fdo#109289] +1 * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> FAIL [fdo#100047] * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-apl: PASS -> DMESG-WARN [fdo#108566] +7 * igt@perf_pmu@busy-accuracy-50-vcs1: - shard-skl: NOTRUN -> SKIP [fdo#109271] +78 * igt@perf_pmu@busy-check-all-vecs0: - shard-snb: NOTRUN -> SKIP [fdo#109271] +112 * igt@prime_busy@wait-after-bsd2: - shard-iclb: NOTRUN -> SKIP [fdo#109276] +17 * igt@prime_nv_api@nv_i915_import_twice_check_flink_name: - shard-iclb: NOTRUN -> SKIP [fdo#109291] +3 * igt@tools_test@tools_test: - shard-snb: PASS -> SKIP [fdo#109271] * igt@v3d_mmap@mmap-bad-handle: - shard-iclb: NOTRUN -> SKIP [fdo#109315] #### Possible fixes #### * igt@gem_softpin@noreloc-s3: - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-kbl: SKIP [fdo#109271] -> PASS * igt@i915_pm_rpm@i2c: - shard-iclb: DMESG-WARN [fdo#109982] -> PASS * igt@i915_suspend@debugfs-reader: - shard-apl: DMESG-WARN [fdo#108566] -> PASS +2 * igt@kms_cursor_crc@cursor-128x128-random: - shard-apl: FAIL [fdo#103232] -> PASS * igt@kms_cursor_crc@cursor-64x64-random: - shard-iclb: INCOMPLETE [fdo#109960] -> PASS * igt@kms_cursor_crc@cursor-64x64-suspend: - shard-skl: INCOMPLETE [fdo#104108] -> PASS +1 * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: FAIL [fdo#104873] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - shard-iclb: FAIL [fdo#103167] / [fdo#109960] -> PASS * igt@kms_frontbuffer_tracking@fbc-tilingchange: - shard-iclb: FAIL [fdo#103167] -> PASS +3 * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite: - shard-skl: FAIL [fdo#103167] -> PASS * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite: - shard-iclb: FAIL [fdo#109247] -> PASS +11 * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping: - shard-glk: SKIP [fdo#109271] -> PASS * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: FAIL [fdo#108145] -> PASS * igt@kms_psr@psr2_sprite_plane_onoff: - shard-iclb: SKIP [fdo#109441] / [fdo#109960] -> PASS * igt@kms_psr@sprite_mmap_cpu: - shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS * igt@kms_setmode@basic: - shard-apl: FAIL [fdo#99912] -> PASS * igt@kms_sysfs_edid_timing: - shard-iclb: FAIL [fdo#100047] -> PASS * igt@perf_pmu@cpu-hotplug: - shard-apl: INCOMPLETE [fdo#103927] -> PASS [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047 [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 [fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954 [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109960]: https://bugs.freedesktop.org/show_bug.cgi?id=109960 [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982 [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215 [fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278 [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321 [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 9) ------------------------------ Missing (1): shard-hsw Build changes ------------- * Linux: CI_DRM_5898 -> Patchwork_12752 CI_DRM_5898: b7ec63a9ba82930148c90769d04f957f10b6b6da @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4937: 256c6107ee127d2ff07d23dfeb3b8d828cb43b37 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12752: 95d66eed4e0bad29cef567574e82e18dbb3a4d27 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12752/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-04-10 18:06 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-10 8:17 [PATCH] snd/hda: Only get/put display_power once Chris Wilson 2019-04-10 8:22 ` Chris Wilson 2019-04-10 9:24 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-04-10 10:09 ` [PATCH] " Takashi Iwai 2019-04-10 10:24 ` Chris Wilson 2019-04-10 10:44 ` Takashi Iwai 2019-04-10 11:03 ` Takashi Iwai 2019-04-10 13:07 ` Chris Wilson 2019-04-10 13:24 ` Takashi Iwai 2019-04-10 10:38 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev2) Patchwork 2019-04-10 11:08 ` ✓ Fi.CI.BAT: success " Patchwork 2019-04-10 12:29 ` ✗ Fi.CI.IGT: failure for snd/hda: Only get/put display_power once Patchwork 2019-04-10 12:34 ` ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Only get/put display_power once (rev3) Patchwork 2019-04-10 13:03 ` ✓ Fi.CI.BAT: success " Patchwork 2019-04-10 18:06 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.