All of lore.kernel.org
 help / color / mirror / Atom feed
From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 1/2] nvme: fabrics: Make sure command struct size fixed
Date: Fri, 12 Apr 2019 00:18:31 +0900	[thread overview]
Message-ID: <20190411151832.26481-2-minwoo.im.dev@gmail.com> (raw)
In-Reply-To: <20190411151832.26481-1-minwoo.im.dev@gmail.com>

struct common_command provides a common structure for NVMe-oF command
format.  It also needs to be checked for unintended size growth.

Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/fabrics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index d4cb826f58ff..592d1e61ef7e 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1188,6 +1188,7 @@ static void __exit nvmf_exit(void)
 	class_destroy(nvmf_class);
 	nvmf_host_put(nvmf_default_host);
 
+	BUILD_BUG_ON(sizeof(struct nvmf_common_command) != 64);
 	BUILD_BUG_ON(sizeof(struct nvmf_connect_command) != 64);
 	BUILD_BUG_ON(sizeof(struct nvmf_property_get_command) != 64);
 	BUILD_BUG_ON(sizeof(struct nvmf_property_set_command) != 64);
-- 
2.17.1

  reply	other threads:[~2019-04-11 15:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 15:18 [PATCH 0/2] nvme: Check size of command structures Minwoo Im
2019-04-11 15:18 ` Minwoo Im [this message]
2019-04-11 22:50   ` [PATCH 1/2] nvme: fabrics: Make sure command struct size fixed Chaitanya Kulkarni
2019-04-24 16:36   ` Sagi Grimberg
2019-04-11 15:18 ` [PATCH 2/2] nvme: pci: " Minwoo Im
2019-04-11 22:54   ` Chaitanya Kulkarni
2019-04-24 16:36   ` Sagi Grimberg
2019-04-11 15:27 ` [PATCH 0/2] nvme: Check size of command structures Keith Busch
2019-04-11 15:34   ` Minwoo Im
2019-04-25 14:44 ` Christoph Hellwig
2019-04-25 14:51   ` Minwoo Im
2019-04-25 15:38   ` Bart Van Assche
2019-04-25 23:32     ` Minwoo Im
2019-04-30 15:31 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190411151832.26481-2-minwoo.im.dev@gmail.com \
    --to=minwoo.im.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.