All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH 0/2] nvme: Check size of command structures
Date: Thu, 11 Apr 2019 09:27:33 -0600	[thread overview]
Message-ID: <20190411152732.GA7312@localhost.localdomain> (raw)
In-Reply-To: <20190411151832.26481-1-minwoo.im.dev@gmail.com>

On Fri, Apr 12, 2019@12:18:30AM +0900, Minwoo Im wrote:
> Many command structures have been added in linux/nvme.h wihtout
> BUILD_BUG_ON() check.  It also needs to be assured to avoid unintended
> growth of structures.

We're already protected from accidentally increasing a command size since
'struct nvme_command' unionizes them all. Its size would be the largest
command in the union and we do check it's 64 bytes. Unintended shrinkage,
though, that would require individual command type checks, so okay.

  parent reply	other threads:[~2019-04-11 15:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 15:18 [PATCH 0/2] nvme: Check size of command structures Minwoo Im
2019-04-11 15:18 ` [PATCH 1/2] nvme: fabrics: Make sure command struct size fixed Minwoo Im
2019-04-11 22:50   ` Chaitanya Kulkarni
2019-04-24 16:36   ` Sagi Grimberg
2019-04-11 15:18 ` [PATCH 2/2] nvme: pci: " Minwoo Im
2019-04-11 22:54   ` Chaitanya Kulkarni
2019-04-24 16:36   ` Sagi Grimberg
2019-04-11 15:27 ` Keith Busch [this message]
2019-04-11 15:34   ` [PATCH 0/2] nvme: Check size of command structures Minwoo Im
2019-04-25 14:44 ` Christoph Hellwig
2019-04-25 14:51   ` Minwoo Im
2019-04-25 15:38   ` Bart Van Assche
2019-04-25 23:32     ` Minwoo Im
2019-04-30 15:31 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190411152732.GA7312@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.