From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 0/2] nvme: Check size of command structures
Date: Thu, 25 Apr 2019 16:44:08 +0200 [thread overview]
Message-ID: <20190425144408.GA17039@lst.de> (raw)
In-Reply-To: <20190411151832.26481-1-minwoo.im.dev@gmail.com>
I'm not sure we are going a little too crazy with all these
BUILD_BUG_ONs. It would be a lot easier if we could just throw
the assert into the struct defintion somehow, but that would need
compiler magic..
On Fri, Apr 12, 2019@12:18:30AM +0900, Minwoo Im wrote:
> Many command structures have been added in linux/nvme.h wihtout
> BUILD_BUG_ON() check. It also needs to be assured to avoid unintended
> growth of structures.
>
> Minwoo Im (2):
> nvme: fabrics: Make sure command struct size fixed
> nvme: pci: Make sure command struct size fixed
>
> drivers/nvme/host/fabrics.c | 1 +
> drivers/nvme/host/pci.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> --
> 2.17.1
---end quoted text---
next prev parent reply other threads:[~2019-04-25 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 15:18 [PATCH 0/2] nvme: Check size of command structures Minwoo Im
2019-04-11 15:18 ` [PATCH 1/2] nvme: fabrics: Make sure command struct size fixed Minwoo Im
2019-04-11 22:50 ` Chaitanya Kulkarni
2019-04-24 16:36 ` Sagi Grimberg
2019-04-11 15:18 ` [PATCH 2/2] nvme: pci: " Minwoo Im
2019-04-11 22:54 ` Chaitanya Kulkarni
2019-04-24 16:36 ` Sagi Grimberg
2019-04-11 15:27 ` [PATCH 0/2] nvme: Check size of command structures Keith Busch
2019-04-11 15:34 ` Minwoo Im
2019-04-25 14:44 ` Christoph Hellwig [this message]
2019-04-25 14:51 ` Minwoo Im
2019-04-25 15:38 ` Bart Van Assche
2019-04-25 23:32 ` Minwoo Im
2019-04-30 15:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425144408.GA17039@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.