From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] iommu/amd: remove the leftover of bypass support
Date: Thu, 11 Apr 2019 17:38:09 +0200 [thread overview]
Message-ID: <20190411153809.GG4518@8bytes.org> (raw)
In-Reply-To: <20190410165014.9932-1-hch-jcswGhMUV9g@public.gmane.org>
On Wed, Apr 10, 2019 at 06:50:14PM +0200, Christoph Hellwig wrote:
> The AMD iommu dma_ops are only attached on a per-device basis when an
> actual translation is needed. Remove the leftover bypass support which
> in parts was already broken (e.g. it always returns 0 from ->map_sg).
>
> Use the opportunity to remove a few local variables and move assignments
> into the declaration line where they were previously separated by the
> bypass check.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
> drivers/iommu/amd_iommu.c | 80 +++++++++------------------------------
> 1 file changed, 17 insertions(+), 63 deletions(-)
Nice cleanup, applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/amd: remove the leftover of bypass support
Date: Thu, 11 Apr 2019 17:38:09 +0200 [thread overview]
Message-ID: <20190411153809.GG4518@8bytes.org> (raw)
Message-ID: <20190411153809.gsBH0ZdznVxOphxzh-bGJNXdFe0CfGLi0ojqz0AjRSw@z> (raw)
In-Reply-To: <20190410165014.9932-1-hch@lst.de>
On Wed, Apr 10, 2019 at 06:50:14PM +0200, Christoph Hellwig wrote:
> The AMD iommu dma_ops are only attached on a per-device basis when an
> actual translation is needed. Remove the leftover bypass support which
> in parts was already broken (e.g. it always returns 0 from ->map_sg).
>
> Use the opportunity to remove a few local variables and move assignments
> into the declaration line where they were previously separated by the
> bypass check.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/iommu/amd_iommu.c | 80 +++++++++------------------------------
> 1 file changed, 17 insertions(+), 63 deletions(-)
Nice cleanup, applied, thanks!
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-04-11 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 16:50 [PATCH] iommu/amd: remove the leftover of bypass support Christoph Hellwig
2019-04-10 16:50 ` Christoph Hellwig
[not found] ` <20190410165014.9932-1-hch-jcswGhMUV9g@public.gmane.org>
2019-04-11 15:38 ` Joerg Roedel [this message]
2019-04-11 15:38 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411153809.GG4518@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.