All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	kbuild-all@01.org, dri-devel@lists.freedesktop.org
Subject: [drm:drm-legacy-cleanup 17/24] drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?
Date: Wed, 24 Apr 2019 17:10:09 +0300	[thread overview]
Message-ID: <20190424141008.GF14820@kadam> (raw)

tree:   git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup
head:   ee22f76306a68359c33809f8895eff603e71584b
commit: 058ca50ce3f1d40dac4d918a91684b0af4a0c468 [17/24] drm/legacy: move lock cleanup for master into lock file (v2)

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

git remote add drm git://people.freedesktop.org/~airlied/linux.git
git remote update drm
git checkout 058ca50ce3f1d40dac4d918a91684b0af4a0c468
vim +359 drivers/gpu/drm/drm_lock.c

058ca50c Dave Airlie 2019-04-23  350  
058ca50c Dave Airlie 2019-04-23  351  void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *master)
058ca50c Dave Airlie 2019-04-23  352  {
058ca50c Dave Airlie 2019-04-23  353  	if (!drm_core_check_feature(dev, DRIVER_LEGACY))
058ca50c Dave Airlie 2019-04-23  354  		return;
058ca50c Dave Airlie 2019-04-23  355  
058ca50c Dave Airlie 2019-04-23  356  	/*
058ca50c Dave Airlie 2019-04-23  357  	 * Since the master is disappearing, so is the
058ca50c Dave Airlie 2019-04-23  358  	 * possibility to lock.
058ca50c Dave Airlie 2019-04-23 @359  	 */	mutex_lock(&dev->struct_mutex);
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This should be moved to the next line.  At first I thought it was part
of the comment.

                 reply	other threads:[~2019-04-24 14:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424141008.GF14820@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    --cc=kbuild@01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.