* [drm:drm-legacy-cleanup 17/24] drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?
@ 2019-04-24 14:10 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-04-24 14:10 UTC (permalink / raw)
To: kbuild, Dave Airlie; +Cc: Daniel Vetter, kbuild-all, dri-devel
tree: git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup
head: ee22f76306a68359c33809f8895eff603e71584b
commit: 058ca50ce3f1d40dac4d918a91684b0af4a0c468 [17/24] drm/legacy: move lock cleanup for master into lock file (v2)
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?
git remote add drm git://people.freedesktop.org/~airlied/linux.git
git remote update drm
git checkout 058ca50ce3f1d40dac4d918a91684b0af4a0c468
vim +359 drivers/gpu/drm/drm_lock.c
058ca50c Dave Airlie 2019-04-23 350
058ca50c Dave Airlie 2019-04-23 351 void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *master)
058ca50c Dave Airlie 2019-04-23 352 {
058ca50c Dave Airlie 2019-04-23 353 if (!drm_core_check_feature(dev, DRIVER_LEGACY))
058ca50c Dave Airlie 2019-04-23 354 return;
058ca50c Dave Airlie 2019-04-23 355
058ca50c Dave Airlie 2019-04-23 356 /*
058ca50c Dave Airlie 2019-04-23 357 * Since the master is disappearing, so is the
058ca50c Dave Airlie 2019-04-23 358 * possibility to lock.
058ca50c Dave Airlie 2019-04-23 @359 */ mutex_lock(&dev->struct_mutex);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be moved to the next line. At first I thought it was part
of the comment.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-04-24 14:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-24 14:10 [drm:drm-legacy-cleanup 17/24] drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended? Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.