From: Will Deacon <will.deacon@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling
Date: Thu, 25 Apr 2019 15:03:01 +0100 [thread overview]
Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s>
On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote:
> On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote:
> > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is
> > failed to forward properly from host to guest, finally root caused this
> > issue is related with kvmtool cannot re-enable INTx mode properly.
> >
> > So the basic working flow to reproduce this issue is as below:
> >
> > Host Guest
> > ------------- --------------------
> > INTx mode
> > MSI enable failed in NIC driver
> > MSI disable in NIC driver
> > Switch back to INTx mode --> kvmtool doesn't support
> >
> > So this patch is to support INTx mode re-enabling; patch 0001 is one
> > minor fixing up for eventfd releasing; patch 0002 introduces a new
> > function vfio_pci_init_intx() which is used to finish INTx one-time
> > initialisation; patch 0003 is the core patch for support INTx mode
> > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx
> > mode.
> >
> > This patch set has been tested on Juno-r2 board.
> >
> > == Changes for V4 ==
> > * Removed the unnecessary comments in patch 0003 (Jean-Philippe).
> > * Added Jean-Philippe's review tags.
>
> Could you pick up these 3 patches and merge into kvmtool? All of them
> has been received reviewing tag from Jean-Philippe. Thanks.
Sorry, I've fallen behind on kvmtool patches recently. I'll make a note
to queue this lot up tomorrow.
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling
Date: Thu, 25 Apr 2019 15:03:01 +0100 [thread overview]
Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> (raw)
Message-ID: <20190425140301.qqHGd5XDHii2JruXKh70JNakfZ3E5Y6o6fymYcurHyU@z> (raw)
In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s>
On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote:
> On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote:
> > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is
> > failed to forward properly from host to guest, finally root caused this
> > issue is related with kvmtool cannot re-enable INTx mode properly.
> >
> > So the basic working flow to reproduce this issue is as below:
> >
> > Host Guest
> > ------------- --------------------
> > INTx mode
> > MSI enable failed in NIC driver
> > MSI disable in NIC driver
> > Switch back to INTx mode --> kvmtool doesn't support
> >
> > So this patch is to support INTx mode re-enabling; patch 0001 is one
> > minor fixing up for eventfd releasing; patch 0002 introduces a new
> > function vfio_pci_init_intx() which is used to finish INTx one-time
> > initialisation; patch 0003 is the core patch for support INTx mode
> > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx
> > mode.
> >
> > This patch set has been tested on Juno-r2 board.
> >
> > == Changes for V4 ==
> > * Removed the unnecessary comments in patch 0003 (Jean-Philippe).
> > * Added Jean-Philippe's review tags.
>
> Could you pick up these 3 patches and merge into kvmtool? All of them
> has been received reviewing tag from Jean-Philippe. Thanks.
Sorry, I've fallen behind on kvmtool patches recently. I'll make a note
to queue this lot up tomorrow.
Cheers,
Will
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Eric Auger <eric.auger@redhat.com>,
Robin Murphy <Robin.Murphy@arm.com>
Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling
Date: Thu, 25 Apr 2019 15:03:01 +0100 [thread overview]
Message-ID: <20190425140301.GD23796@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190424142127.GC8948@leoy-ThinkPad-X240s>
On Wed, Apr 24, 2019 at 10:21:27PM +0800, Leo Yan wrote:
> On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote:
> > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is
> > failed to forward properly from host to guest, finally root caused this
> > issue is related with kvmtool cannot re-enable INTx mode properly.
> >
> > So the basic working flow to reproduce this issue is as below:
> >
> > Host Guest
> > ------------- --------------------
> > INTx mode
> > MSI enable failed in NIC driver
> > MSI disable in NIC driver
> > Switch back to INTx mode --> kvmtool doesn't support
> >
> > So this patch is to support INTx mode re-enabling; patch 0001 is one
> > minor fixing up for eventfd releasing; patch 0002 introduces a new
> > function vfio_pci_init_intx() which is used to finish INTx one-time
> > initialisation; patch 0003 is the core patch for support INTx mode
> > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx
> > mode.
> >
> > This patch set has been tested on Juno-r2 board.
> >
> > == Changes for V4 ==
> > * Removed the unnecessary comments in patch 0003 (Jean-Philippe).
> > * Added Jean-Philippe's review tags.
>
> Could you pick up these 3 patches and merge into kvmtool? All of them
> has been received reviewing tag from Jean-Philippe. Thanks.
Sorry, I've fallen behind on kvmtool patches recently. I'll make a note
to queue this lot up tomorrow.
Cheers,
Will
next prev parent reply other threads:[~2019-04-25 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 1:27 [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Leo Yan
2019-04-08 1:27 ` Leo Yan
2019-04-08 1:27 ` [PATCH v4 1/3] vfio-pci: Release INTx's unmask eventfd properly Leo Yan
2019-04-08 1:27 ` Leo Yan
2019-04-08 1:27 ` [PATCH v4 2/3] vfio-pci: Add new function for INTx one-time initialisation Leo Yan
2019-04-08 1:27 ` Leo Yan
2019-04-08 1:27 ` [PATCH v4 3/3] vfio-pci: Re-enable INTx mode when disable MSI/MSIX Leo Yan
2019-04-08 1:27 ` Leo Yan
2019-04-24 14:21 ` [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Leo Yan
2019-04-24 14:21 ` Leo Yan
2019-04-25 14:03 ` Will Deacon [this message]
2019-04-25 14:03 ` Will Deacon
2019-04-25 14:03 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425140301.GD23796@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=leo.yan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.