From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, john.stultz@linaro.org,
suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [v6,03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform
Date: Thu, 25 Apr 2019 16:36:58 -0500 [thread overview]
Message-ID: <20190425213658.GB32028@bogus> (raw)
On Sat, Apr 20, 2019 at 02:40:09PM +0800, Yu Chen wrote:
> This patch adds support for the poweron and shutdown of dwc3 core
> on Hisilicon Soc Platform.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 4c2771c5e727..0ed09d876542 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -98,7 +98,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
> + of_device_is_compatible(np, "hisilicon,hi3660-dwc3"))
> simple->need_reset = true;
Fine, I guess, but really this flag should be moved to the match table
so we aren't doing compatible matching twice.
>
> if (of_device_is_compatible(np, "amlogic,meson-axg-dwc3") ||
> @@ -243,6 +244,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
> { .compatible = "amlogic,meson-axg-dwc3" },
> { .compatible = "amlogic,meson-gxl-dwc3" },
> { .compatible = "allwinner,sun50i-h6-dwc3" },
> + { .compatible = "hisilicon,hi3660-dwc3" },
> { /* Sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
> --
> 2.15.0-rc2
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yu Chen <chenyu56@huawei.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, john.stultz@linaro.org,
suzhuangluan@hisilicon.com, kongfei@hisilicon.com,
liuyu712@hisilicon.com, wanghu17@hisilicon.com,
butao@hisilicon.com, chenyao11@huawei.com,
fangshengzhou@hisilicon.com, lipengcheng8@huawei.com,
songxiaowei@hisilicon.com, xuyiping@hisilicon.com,
xuyoujun4@huawei.com, yudongbin@hisilicon.com,
zangleigang@hisilicon.com, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v6 03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform
Date: Thu, 25 Apr 2019 16:36:58 -0500 [thread overview]
Message-ID: <20190425213658.GB32028@bogus> (raw)
Message-ID: <20190425213658.ewur_ZgksV0SUhSwteSrgKCmZajxGmojfZ7OaE72yRA@z> (raw)
In-Reply-To: <20190420064019.57522-4-chenyu56@huawei.com>
On Sat, Apr 20, 2019 at 02:40:09PM +0800, Yu Chen wrote:
> This patch adds support for the poweron and shutdown of dwc3 core
> on Hisilicon Soc Platform.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Yu Chen <chenyu56@huawei.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 4c2771c5e727..0ed09d876542 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -98,7 +98,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
> + of_device_is_compatible(np, "hisilicon,hi3660-dwc3"))
> simple->need_reset = true;
Fine, I guess, but really this flag should be moved to the match table
so we aren't doing compatible matching twice.
>
> if (of_device_is_compatible(np, "amlogic,meson-axg-dwc3") ||
> @@ -243,6 +244,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
> { .compatible = "amlogic,meson-axg-dwc3" },
> { .compatible = "amlogic,meson-gxl-dwc3" },
> { .compatible = "allwinner,sun50i-h6-dwc3" },
> + { .compatible = "hisilicon,hi3660-dwc3" },
> { /* Sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
> --
> 2.15.0-rc2
>
next reply other threads:[~2019-04-25 21:36 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 21:36 Rob Herring [this message]
2019-04-25 21:36 ` [PATCH v6 03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-05-02 5:44 [v6,13/13] dts: hi3660: Add support for usb on Hikey960 shufan_lee(李書帆)
2019-05-02 5:44 ` [PATCH v6 13/13] " shufan_lee(李書帆)
2019-05-02 5:44 ` shufan_lee(李書帆)
2019-05-02 5:44 ` shufan_lee(李書帆)
2019-05-01 16:27 [v6,02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Rob Herring
2019-05-01 16:27 ` [PATCH v6 02/13] " Rob Herring
2019-04-30 7:15 [v6,13/13] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-04-30 7:15 ` [PATCH v6 13/13] " Chen Yu
2019-04-30 7:15 ` Chen Yu
2019-04-30 6:07 [v6,02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-04-30 6:07 ` [PATCH v6 02/13] " Chen Yu
2019-04-30 6:07 ` Chen Yu
2019-04-25 22:00 [v6,13/13] dts: hi3660: Add support for usb on Hikey960 Rob Herring
2019-04-25 22:00 ` [PATCH v6 13/13] " Rob Herring
2019-04-25 22:00 ` Rob Herring
2019-04-25 21:35 [v6,02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Rob Herring
2019-04-25 21:35 ` [PATCH v6 02/13] " Rob Herring
2019-04-20 6:40 [v6,13/13] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-04-20 6:40 ` [PATCH v6 13/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,12/13] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-04-20 6:40 ` [PATCH v6 12/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,11/13] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-04-20 6:40 ` [PATCH v6 11/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,10/13] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-04-20 6:40 ` [PATCH v6 10/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,09/13] usb: roles: Add usb role switch notifier Yu Chen
2019-04-20 6:40 ` [PATCH v6 09/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,08/13] usb: roles: Introduce stubs for the exiting functions in role.h Yu Chen
2019-04-20 6:40 ` [PATCH v6 08/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,07/13] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-04-20 6:40 ` [PATCH v6 07/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,06/13] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-04-20 6:40 ` [PATCH v6 06/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,05/13] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for Hisilicon Kirin Soc Yu Chen
2019-04-20 6:40 ` [PATCH v6 05/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-04-20 6:40 ` [PATCH v6 03/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-04-20 6:40 ` [PATCH v6 02/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [v6,01/13] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-04-20 6:40 ` [PATCH v6 01/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 [PATCH v6 00/13] Add support for usb on Hikey960 Yu Chen
2019-04-20 6:40 ` Yu Chen
2019-04-20 6:40 ` [v6,04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc Yu Chen
2019-04-20 6:40 ` [PATCH v6 04/13] " Yu Chen
2019-04-20 6:40 ` Yu Chen
2020-09-07 13:06 ` Mauro Carvalho Chehab
2020-09-07 14:04 ` Felipe Balbi
2020-09-07 14:50 ` Mauro Carvalho Chehab
2020-09-08 6:09 ` Felipe Balbi
2020-09-08 6:49 ` Mauro Carvalho Chehab
2020-09-08 17:40 ` Thinh Nguyen
2020-09-08 6:42 ` Mauro Carvalho Chehab
2019-04-29 15:42 ` [PATCH v6 00/13] Add support for usb on Hikey960 Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425213658.GB32028@bogus \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=butao@hisilicon.com \
--cc=chenyao11@huawei.com \
--cc=chenyu56@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=fangshengzhou@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liuyu712@hisilicon.com \
--cc=songxiaowei@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wanghu17@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyoujun4@huawei.com \
--cc=yudongbin@hisilicon.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.