From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Qemu-block <qemu-block@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
hch@lst.de
Subject: Re: [Qemu-devel] Failing qemu-iotest 005 with raw
Date: Fri, 26 Apr 2019 12:53:01 +0200 [thread overview]
Message-ID: <20190426105301.GA20769@localhost.localdomain> (raw)
In-Reply-To: <dd85fab0-52df-9c2d-e402-28d7ce9867f1@redhat.com>
Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben:
>
> When running iotest 005 with raw, the test currently fails for me:
>
> 005 - output mismatch (see 005.out.bad)
> --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23
> 16:43:11.000000000 +0200
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad 2019-04-26
> 11:34:11.000000000 +0200
> @@ -1,13 +1,12 @@
> QA output created by 005
>
> creating large image
> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
> format 'IMGFMT'
> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
> [...]
>
> Could this be fixed somehow, or should the test rather be skipped for
> IMGFMT=raw?
The test passes for me on XFS. Looks like the raw driver can handle
large image files, but your host filesystem can't.
We would have to check whether the host filesystem can support large
files and skip the test if it can't. I'm not sure how to do that. But
actually, this isn't testing anything interesting for raw, so just
unconditionally disabling the test for raw could be reasonable enough.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: hch@lst.de, QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] Failing qemu-iotest 005 with raw
Date: Fri, 26 Apr 2019 12:53:01 +0200 [thread overview]
Message-ID: <20190426105301.GA20769@localhost.localdomain> (raw)
Message-ID: <20190426105301.bpFaT8GwBiKMmXww-99wW1f_382wcX5e7Ty5z7Djq-o@z> (raw)
In-Reply-To: <dd85fab0-52df-9c2d-e402-28d7ce9867f1@redhat.com>
Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben:
>
> When running iotest 005 with raw, the test currently fails for me:
>
> 005 - output mismatch (see 005.out.bad)
> --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out 2019-04-23
> 16:43:11.000000000 +0200
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad 2019-04-26
> 11:34:11.000000000 +0200
> @@ -1,13 +1,12 @@
> QA output created by 005
>
> creating large image
> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
> format 'IMGFMT'
> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
> [...]
>
> Could this be fixed somehow, or should the test rather be skipped for
> IMGFMT=raw?
The test passes for me on XFS. Looks like the raw driver can handle
large image files, but your host filesystem can't.
We would have to check whether the host filesystem can support large
files and skip the test if it can't. I'm not sure how to do that. But
actually, this isn't testing anything interesting for raw, so just
unconditionally disabling the test for raw could be reasonable enough.
Kevin
next prev parent reply other threads:[~2019-04-26 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 9:41 [Qemu-devel] Failing qemu-iotest 005 with raw Thomas Huth
2019-04-26 9:41 ` Thomas Huth
2019-04-26 10:53 ` Kevin Wolf [this message]
2019-04-26 10:53 ` Kevin Wolf
2019-04-28 2:36 ` Eric Blake
2019-04-28 2:36 ` Eric Blake
2019-04-28 13:32 ` Thomas Huth
2019-04-28 13:32 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426105301.GA20769@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.