From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v6 1/4] iomap: Clean up __generic_write_end calling
Date: Mon, 29 Apr 2019 21:42:27 +0200 [thread overview]
Message-ID: <20190429194227.GA6138@lst.de> (raw)
In-Reply-To: <CAHc6FU5jgGGsHS9xRDMmssOH3rzDWoRYvrnDM5mHK1ASKc60yA@mail.gmail.com>
On Mon, Apr 29, 2019 at 07:46:29PM +0200, Andreas Gruenbacher wrote:
> On Mon, 29 Apr 2019 at 18:32, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Move the call to __generic_write_end into iomap_write_end instead of
> > duplicating it in each of the three branches. This requires open coding
> > the generic_write_end for the buffer_head case.
>
> Wouldn't it make sense to turn __generic_write_end into a void
> function? Right now, it just oddly return its copied argument.
Yes, we could remove the return value. That should be a separate patch
after this one, though.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel <cluster-devel@redhat.com>,
"Christoph Hellwig" <hch@lst.de>,
"Bob Peterson" <rpeterso@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Dave Chinner" <david@fromorbit.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Mark Syms" <Mark.Syms@citrix.com>,
"Edwin Török" <edvin.torok@citrix.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v6 1/4] iomap: Clean up __generic_write_end calling
Date: Mon, 29 Apr 2019 21:42:27 +0200 [thread overview]
Message-ID: <20190429194227.GA6138@lst.de> (raw)
In-Reply-To: <CAHc6FU5jgGGsHS9xRDMmssOH3rzDWoRYvrnDM5mHK1ASKc60yA@mail.gmail.com>
On Mon, Apr 29, 2019 at 07:46:29PM +0200, Andreas Gruenbacher wrote:
> On Mon, 29 Apr 2019 at 18:32, Andreas Gruenbacher <agruenba@redhat.com> wrote:
> > From: Christoph Hellwig <hch@lst.de>
> >
> > Move the call to __generic_write_end into iomap_write_end instead of
> > duplicating it in each of the three branches. This requires open coding
> > the generic_write_end for the buffer_head case.
>
> Wouldn't it make sense to turn __generic_write_end into a void
> function? Right now, it just oddly return its copied argument.
Yes, we could remove the return value. That should be a separate patch
after this one, though.
next prev parent reply other threads:[~2019-04-29 19:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 16:32 [Cluster-devel] [PATCH v6 1/4] iomap: Clean up __generic_write_end calling Andreas Gruenbacher
2019-04-29 16:32 ` Andreas Gruenbacher
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 2/4] iomap: Fix use-after-free error in page_done callback Andreas Gruenbacher
2019-04-29 16:32 ` Andreas Gruenbacher
2019-04-29 19:43 ` [Cluster-devel] " Christoph Hellwig
2019-04-29 19:43 ` Christoph Hellwig
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback Andreas Gruenbacher
2019-04-29 16:32 ` Andreas Gruenbacher
2019-04-29 19:44 ` [Cluster-devel] " Christoph Hellwig
2019-04-29 19:44 ` Christoph Hellwig
2019-04-29 21:41 ` [Cluster-devel] " Jan Kara
2019-04-29 21:41 ` Jan Kara
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 4/4] gfs2: Fix iomap write page reclaim deadlock Andreas Gruenbacher
2019-04-29 16:32 ` Andreas Gruenbacher
2019-04-29 17:46 ` [Cluster-devel] [PATCH v6 1/4] iomap: Clean up __generic_write_end calling Andreas Gruenbacher
2019-04-29 17:46 ` Andreas Gruenbacher
2019-04-29 19:42 ` Christoph Hellwig [this message]
2019-04-29 19:42 ` Christoph Hellwig
2019-04-29 21:44 ` [Cluster-devel] " Jan Kara
2019-04-29 21:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429194227.GA6138@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.