All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback
Date: Mon, 29 Apr 2019 21:44:03 +0200	[thread overview]
Message-ID: <20190429194403.GC6138@lst.de> (raw)
In-Reply-To: <20190429163239.4874-3-agruenba@redhat.com>

> +static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos,
> +				   unsigned len, struct iomap *iomap)
> +{
> +	return 0;
> +}

Now that we check for each callback there is no need to add a dummy
one in this patch.

But given that that won't change the end result:

Reviewed-by: Christoph Hellwig <hch@lst.de>



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, "Christoph Hellwig" <hch@lst.de>,
	"Bob Peterson" <rpeterso@redhat.com>, "Jan Kara" <jack@suse.cz>,
	"Dave Chinner" <david@fromorbit.com>,
	"Ross Lagerwall" <ross.lagerwall@citrix.com>,
	"Mark Syms" <Mark.Syms@citrix.com>,
	"Edwin Török" <edvin.torok@citrix.com>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v6 3/4] iomap: Add a page_prepare callback
Date: Mon, 29 Apr 2019 21:44:03 +0200	[thread overview]
Message-ID: <20190429194403.GC6138@lst.de> (raw)
In-Reply-To: <20190429163239.4874-3-agruenba@redhat.com>

> +static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos,
> +				   unsigned len, struct iomap *iomap)
> +{
> +	return 0;
> +}

Now that we check for each callback there is no need to add a dummy
one in this patch.

But given that that won't change the end result:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2019-04-29 19:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 16:32 [Cluster-devel] [PATCH v6 1/4] iomap: Clean up __generic_write_end calling Andreas Gruenbacher
2019-04-29 16:32 ` Andreas Gruenbacher
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 2/4] iomap: Fix use-after-free error in page_done callback Andreas Gruenbacher
2019-04-29 16:32   ` Andreas Gruenbacher
2019-04-29 19:43   ` [Cluster-devel] " Christoph Hellwig
2019-04-29 19:43     ` Christoph Hellwig
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback Andreas Gruenbacher
2019-04-29 16:32   ` Andreas Gruenbacher
2019-04-29 19:44   ` Christoph Hellwig [this message]
2019-04-29 19:44     ` Christoph Hellwig
2019-04-29 21:41   ` [Cluster-devel] " Jan Kara
2019-04-29 21:41     ` Jan Kara
2019-04-29 16:32 ` [Cluster-devel] [PATCH v6 4/4] gfs2: Fix iomap write page reclaim deadlock Andreas Gruenbacher
2019-04-29 16:32   ` Andreas Gruenbacher
2019-04-29 17:46 ` [Cluster-devel] [PATCH v6 1/4] iomap: Clean up __generic_write_end calling Andreas Gruenbacher
2019-04-29 17:46   ` Andreas Gruenbacher
2019-04-29 19:42   ` [Cluster-devel] " Christoph Hellwig
2019-04-29 19:42     ` Christoph Hellwig
2019-04-29 21:44 ` [Cluster-devel] " Jan Kara
2019-04-29 21:44   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190429194403.GC6138@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.