All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dragan Cvetic <draganc@xilinx.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Michal Simek <michals@xilinx.com>,
	Derek Kiernan <dkiernan@xilinx.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
Date: Sat, 4 May 2019 11:02:03 +0200	[thread overview]
Message-ID: <20190504090203.GD13840@kroah.com> (raw)
In-Reply-To: <BL0PR02MB5681F4C4AF4786AC6241DDA1CB350@BL0PR02MB5681.namprd02.prod.outlook.com>

On Fri, May 03, 2019 at 04:44:57PM +0000, Dragan Cvetic wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday 2 May 2019 18:23
> > To: Dragan Cvetic <draganc@xilinx.com>
> > Cc: arnd@arndb.de; Michal Simek <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org;
> > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan <dkiernan@xilinx.com>
> > Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
> > 
> > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote:
> > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> > > +{
> > > +	struct xsdfec_dev *xsdfec;
> > > +
> > > +	xsdfec = container_of(iptr->i_cdev, struct xsdfec_dev, xsdfec_cdev);
> > > +
> > > +	if (!atomic_dec_and_test(&xsdfec->open_count)) {
> > 
> > Why do you care about this?
> > 
> > And do you really think it matters?  What are you trying to protect from
> > here?
> 
> There is a request to increase the driver security. 

How does this affect "security" in any way?

> It is acceptable for us for now, even with non-perfections (will not
> be protected if opened twice with dup() or fork()).  This is covered
> in the documentation.

As this really "does nothing", no need to bother the kernel with trying
to keep this logic working properly.  So please just drop it.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Dragan Cvetic <draganc@xilinx.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
	Michal Simek <michals@xilinx.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Derek Kiernan <dkiernan@xilinx.com>
Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
Date: Sat, 4 May 2019 11:02:03 +0200	[thread overview]
Message-ID: <20190504090203.GD13840@kroah.com> (raw)
In-Reply-To: <BL0PR02MB5681F4C4AF4786AC6241DDA1CB350@BL0PR02MB5681.namprd02.prod.outlook.com>

On Fri, May 03, 2019 at 04:44:57PM +0000, Dragan Cvetic wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday 2 May 2019 18:23
> > To: Dragan Cvetic <draganc@xilinx.com>
> > Cc: arnd@arndb.de; Michal Simek <michals@xilinx.com>; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org;
> > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan <dkiernan@xilinx.com>
> > Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
> > 
> > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote:
> > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr)
> > > +{
> > > +	struct xsdfec_dev *xsdfec;
> > > +
> > > +	xsdfec = container_of(iptr->i_cdev, struct xsdfec_dev, xsdfec_cdev);
> > > +
> > > +	if (!atomic_dec_and_test(&xsdfec->open_count)) {
> > 
> > Why do you care about this?
> > 
> > And do you really think it matters?  What are you trying to protect from
> > here?
> 
> There is a request to increase the driver security. 

How does this affect "security" in any way?

> It is acceptable for us for now, even with non-perfections (will not
> be protected if opened twice with dup() or fork()).  This is covered
> in the documentation.

As this really "does nothing", no need to bother the kernel with trying
to keep this logic working properly.  So please just drop it.

thanks,

greg k-h

  reply	other threads:[~2019-05-04  9:02 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 22:04 [PATCH V3 00/12] misc: xilinx sd-fec drive Dragan Cvetic
2019-04-27 22:04 ` Dragan Cvetic
2019-04-27 22:04 ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-01 19:47   ` Rob Herring
2019-05-01 19:47     ` Rob Herring
2019-05-02 11:04     ` Dragan Cvetic
2019-05-02 11:04       ` Dragan Cvetic
2019-05-02 20:15       ` Rob Herring
2019-05-02 20:15         ` Rob Herring
2019-05-03 17:04         ` Dragan Cvetic
2019-05-03 17:04           ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 02/12] misc: xilinx-sdfec: add core driver Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-02 17:20   ` Greg KH
2019-05-02 17:20     ` Greg KH
2019-05-03 16:41     ` Dragan Cvetic
2019-05-03 16:41       ` Dragan Cvetic
2019-05-04  7:55       ` Greg KH
2019-05-04  7:55         ` Greg KH
2019-05-04  7:55         ` Greg KH
2019-05-06 12:23         ` Dragan Cvetic
2019-05-06 12:23           ` Dragan Cvetic
2019-05-06 12:34           ` Greg KH
2019-05-06 12:34             ` Greg KH
2019-05-07  8:48             ` Dragan Cvetic
2019-05-07  8:48               ` Dragan Cvetic
2019-05-07  8:48               ` Dragan Cvetic
2019-05-07  9:39               ` Greg KH
2019-05-07  9:39                 ` Greg KH
2019-05-07 11:55                 ` Dragan Cvetic
2019-05-07 11:55                   ` Dragan Cvetic
2019-05-07 12:21                   ` Greg KH
2019-05-07 12:21                     ` Greg KH
2019-05-07 13:15                     ` Dragan Cvetic
2019-05-07 13:15                       ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 03/12] misc: xilinx_sdfec: Add CCF support Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-02 17:23   ` Greg KH
2019-05-02 17:23     ` Greg KH
2019-05-03 16:44     ` Dragan Cvetic
2019-05-03 16:44       ` Dragan Cvetic
2019-05-04  9:02       ` Greg KH [this message]
2019-05-04  9:02         ` Greg KH
2019-05-02 17:23   ` Greg KH
2019-05-02 17:23     ` Greg KH
2019-05-03 16:46     ` Dragan Cvetic
2019-05-03 16:46       ` Dragan Cvetic
2019-05-04  9:01       ` Greg KH
2019-05-04  9:01         ` Greg KH
2019-05-04 14:35     ` Arnd Bergmann
2019-05-04 14:35       ` Arnd Bergmann
2019-05-04 14:41       ` Greg KH
2019-05-04 14:41         ` Greg KH
2019-04-27 22:04 ` [PATCH V3 05/12] misc: xilinx_sdfec: Store driver config and state Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 06/12] misc: xilinx_sdfec: Add ability to configure turbo Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 07/12] misc: xilinx_sdfec: Add ability to configure LDPC Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-05-02 17:27   ` Greg KH
2019-05-02 17:27     ` Greg KH
2019-05-03 16:49     ` Dragan Cvetic
2019-05-03 16:49       ` Dragan Cvetic
2019-05-04  9:00       ` Greg KH
2019-05-04  9:00         ` Greg KH
2019-05-04  9:00         ` Greg KH
2019-04-27 22:05 ` [PATCH V3 08/12] misc: xilinx_sdfec: Add ability to get/set config Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 09/12] misc: xilinx_sdfec: Support poll file operation Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 10/12] misc: xilinx_sdfec: Add stats & status ioctls Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 11/12] Docs: misc: xilinx_sdfec: Add documentation Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 12/12] MAINTAINERS: add maintainer for SD-FEC Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190504090203.GD13840@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dkiernan@xilinx.com \
    --cc=draganc@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michals@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.