All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	DTML <devicetree@vger.kernel.org>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Derek Kiernan <derek.kiernan@xilinx.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
Date: Sat, 4 May 2019 16:41:28 +0200	[thread overview]
Message-ID: <20190504144128.GA13454@kroah.com> (raw)
In-Reply-To: <CAK8P3a2EKXrg4amHDi5zVvOQ8AM+u6EAhBc=T8Hk_tU20xSV4w@mail.gmail.com>

On Sat, May 04, 2019 at 10:35:02AM -0400, Arnd Bergmann wrote:
> On Thu, May 2, 2019 at 1:23 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote:
> > > Add char device interface per DT node present and support
> > > file operations:
> > > - open(),
> > > - close(),
> > > - unlocked_ioctl(),
> > > - compat_ioctl().
> >
> > Why do you need compat_ioctl() at all?  Any "new" driver should never
> > need it.  Just create your structures properly.
> 
> The function he added was the version that is needed when the structures
> are compatible. I submitted a series to add a generic 'compat_ptr_ioctl'
> implementation that would save a few lines here doing the same thing,
> but it's not merged yet.
> 
> Generally speaking, every driver that has a .ioctl() function should also
> have a .compat_ioctl(), and ideally it should be exactly this trivial
> version.

Ok, for some reason I thought if there was no need for a compat ioctl
(i.e. no pointer mess), then no need for a callback at all.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dragan Cvetic <dragan.cvetic@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Derek Kiernan <derek.kiernan@xilinx.com>
Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl
Date: Sat, 4 May 2019 16:41:28 +0200	[thread overview]
Message-ID: <20190504144128.GA13454@kroah.com> (raw)
In-Reply-To: <CAK8P3a2EKXrg4amHDi5zVvOQ8AM+u6EAhBc=T8Hk_tU20xSV4w@mail.gmail.com>

On Sat, May 04, 2019 at 10:35:02AM -0400, Arnd Bergmann wrote:
> On Thu, May 2, 2019 at 1:23 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote:
> > > Add char device interface per DT node present and support
> > > file operations:
> > > - open(),
> > > - close(),
> > > - unlocked_ioctl(),
> > > - compat_ioctl().
> >
> > Why do you need compat_ioctl() at all?  Any "new" driver should never
> > need it.  Just create your structures properly.
> 
> The function he added was the version that is needed when the structures
> are compatible. I submitted a series to add a generic 'compat_ptr_ioctl'
> implementation that would save a few lines here doing the same thing,
> but it's not merged yet.
> 
> Generally speaking, every driver that has a .ioctl() function should also
> have a .compat_ioctl(), and ideally it should be exactly this trivial
> version.

Ok, for some reason I thought if there was no need for a compat ioctl
(i.e. no pointer mess), then no need for a callback at all.

thanks,

greg k-h

  reply	other threads:[~2019-05-04 14:41 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 22:04 [PATCH V3 00/12] misc: xilinx sd-fec drive Dragan Cvetic
2019-04-27 22:04 ` Dragan Cvetic
2019-04-27 22:04 ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-01 19:47   ` Rob Herring
2019-05-01 19:47     ` Rob Herring
2019-05-02 11:04     ` Dragan Cvetic
2019-05-02 11:04       ` Dragan Cvetic
2019-05-02 20:15       ` Rob Herring
2019-05-02 20:15         ` Rob Herring
2019-05-03 17:04         ` Dragan Cvetic
2019-05-03 17:04           ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 02/12] misc: xilinx-sdfec: add core driver Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-02 17:20   ` Greg KH
2019-05-02 17:20     ` Greg KH
2019-05-03 16:41     ` Dragan Cvetic
2019-05-03 16:41       ` Dragan Cvetic
2019-05-04  7:55       ` Greg KH
2019-05-04  7:55         ` Greg KH
2019-05-04  7:55         ` Greg KH
2019-05-06 12:23         ` Dragan Cvetic
2019-05-06 12:23           ` Dragan Cvetic
2019-05-06 12:34           ` Greg KH
2019-05-06 12:34             ` Greg KH
2019-05-07  8:48             ` Dragan Cvetic
2019-05-07  8:48               ` Dragan Cvetic
2019-05-07  8:48               ` Dragan Cvetic
2019-05-07  9:39               ` Greg KH
2019-05-07  9:39                 ` Greg KH
2019-05-07 11:55                 ` Dragan Cvetic
2019-05-07 11:55                   ` Dragan Cvetic
2019-05-07 12:21                   ` Greg KH
2019-05-07 12:21                     ` Greg KH
2019-05-07 13:15                     ` Dragan Cvetic
2019-05-07 13:15                       ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 03/12] misc: xilinx_sdfec: Add CCF support Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-05-02 17:23   ` Greg KH
2019-05-02 17:23     ` Greg KH
2019-05-03 16:44     ` Dragan Cvetic
2019-05-03 16:44       ` Dragan Cvetic
2019-05-04  9:02       ` Greg KH
2019-05-04  9:02         ` Greg KH
2019-05-02 17:23   ` Greg KH
2019-05-02 17:23     ` Greg KH
2019-05-03 16:46     ` Dragan Cvetic
2019-05-03 16:46       ` Dragan Cvetic
2019-05-04  9:01       ` Greg KH
2019-05-04  9:01         ` Greg KH
2019-05-04 14:35     ` Arnd Bergmann
2019-05-04 14:35       ` Arnd Bergmann
2019-05-04 14:41       ` Greg KH [this message]
2019-05-04 14:41         ` Greg KH
2019-04-27 22:04 ` [PATCH V3 05/12] misc: xilinx_sdfec: Store driver config and state Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:04   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 06/12] misc: xilinx_sdfec: Add ability to configure turbo Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 07/12] misc: xilinx_sdfec: Add ability to configure LDPC Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-05-02 17:27   ` Greg KH
2019-05-02 17:27     ` Greg KH
2019-05-03 16:49     ` Dragan Cvetic
2019-05-03 16:49       ` Dragan Cvetic
2019-05-04  9:00       ` Greg KH
2019-05-04  9:00         ` Greg KH
2019-05-04  9:00         ` Greg KH
2019-04-27 22:05 ` [PATCH V3 08/12] misc: xilinx_sdfec: Add ability to get/set config Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 09/12] misc: xilinx_sdfec: Support poll file operation Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 10/12] misc: xilinx_sdfec: Add stats & status ioctls Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 11/12] Docs: misc: xilinx_sdfec: Add documentation Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 12/12] MAINTAINERS: add maintainer for SD-FEC Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic
2019-04-27 22:05   ` Dragan Cvetic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190504144128.GA13454@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.