From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-loop: Fix race between completions and shutdown
Date: Mon, 6 May 2019 08:53:27 -0600 [thread overview]
Message-ID: <20190506145327.GA2164@localhost.localdomain> (raw)
In-Reply-To: <20190506145203.2851-1-minwoo.im.dev@gmail.com>
On Mon, May 06, 2019@11:52:03PM +0900, Minwoo Im wrote:
> static void nvme_loop_shutdown_ctrl(struct nvme_loop_ctrl *ctrl)
> {
> if (ctrl->ctrl.queue_count > 1) {
> + nvme_start_freeze(&ctrl->ctrl);
> + nvme_wait_freeze(&ctrl->ctrl);
> +
> nvme_stop_queues(&ctrl->ctrl);
> blk_mq_tagset_busy_iter(&ctrl->tag_set,
> nvme_cancel_request, &ctrl->ctrl);
> nvme_loop_destroy_io_queues(ctrl);
> +
> + nvme_unfreeze(&ctrl->ctrl);
> }
nvme_stop_queues() and blk_mq_tagset_busy_iter() really don't make sense
to call on frozen queues.
next prev parent reply other threads:[~2019-05-06 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:52 [PATCH] nvme-loop: Fix race between completions and shutdown Minwoo Im
2019-05-06 14:53 ` Keith Busch [this message]
2019-05-06 15:07 ` Minwoo Im
2019-05-06 15:17 ` Keith Busch
2019-05-06 15:46 ` Minwoo Im
2019-05-06 15:52 ` Minwoo Im
2019-05-06 15:56 ` Keith Busch
2019-05-06 16:25 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506145327.GA2164@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.