All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-loop: Fix race between completions and shutdown
Date: Mon, 6 May 2019 09:17:27 -0600	[thread overview]
Message-ID: <20190506151727.GB2164@localhost.localdomain> (raw)
In-Reply-To: <0db7e312-0ff2-45f2-8ee1-7ad7b6fd3e5a@gmail.com>

On Tue, May 07, 2019@12:07:47AM +0900, Minwoo Im wrote:
> 
> If don't mind, can I ask how can blk_mq_tagset_busy_iter() make sure that no
> more requests are coming into this request_queue during this iteration ?

If a queue is frozen, there can't be any allocated tags, so calling
blk_mq_tagset_busy_iter for such a queue is a no-op.

I'm not sure you actually want to freeze in this path though. That may
block forever if a request needs to be requeued.

  reply	other threads:[~2019-05-06 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 14:52 [PATCH] nvme-loop: Fix race between completions and shutdown Minwoo Im
2019-05-06 14:53 ` Keith Busch
2019-05-06 15:07   ` Minwoo Im
2019-05-06 15:17     ` Keith Busch [this message]
2019-05-06 15:46       ` Minwoo Im
2019-05-06 15:52       ` Minwoo Im
2019-05-06 15:56         ` Keith Busch
2019-05-06 16:25           ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190506151727.GB2164@localhost.localdomain \
    --to=kbusch@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.