From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH] nvme-loop: Fix race between completions and shutdown
Date: Mon, 6 May 2019 09:56:32 -0600 [thread overview]
Message-ID: <20190506155632.GA2219@localhost.localdomain> (raw)
In-Reply-To: <1ced3919-af4a-7899-8d49-026b9cc82e2b@gmail.com>
On Tue, May 07, 2019@12:52:34AM +0900, Minwoo Im wrote:
>
> I think it's possible to happen in nvme-pci also. When a CPU is handling a
> request completed with nvme_complete_rq(), the controller reset by sysfs can
> occur. In this case, blk_mq_tagset_busy_iter() will iterate over the
> requests allocated in nvme_dev_disable().
>
> Does nvme-pci host driver handle this kind of situation ?
Yes, we have barriers that ensure no other thread can be operating on
a completion queue entry at the point we iterate the tagset.
next prev parent reply other threads:[~2019-05-06 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 14:52 [PATCH] nvme-loop: Fix race between completions and shutdown Minwoo Im
2019-05-06 14:53 ` Keith Busch
2019-05-06 15:07 ` Minwoo Im
2019-05-06 15:17 ` Keith Busch
2019-05-06 15:46 ` Minwoo Im
2019-05-06 15:52 ` Minwoo Im
2019-05-06 15:56 ` Keith Busch [this message]
2019-05-06 16:25 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506155632.GA2219@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.