All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
	alex.bennee@linaro.org, armbru@redhat.com, eblake@redhat.com,
	Dave.Martin@arm.com, abologna@redhat.com
Subject: [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map
Date: Sun, 12 May 2019 10:36:24 +0200	[thread overview]
Message-ID: <20190512083624.8916-14-drjones@redhat.com> (raw)
In-Reply-To: <20190512083624.8916-1-drjones@redhat.com>

Allow the host cpu type to enable SVE in guests with the sve-vls-map
cpu property.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 target/arm/cpu.c   |  1 +
 target/arm/cpu.h   |  2 ++
 target/arm/cpu64.c | 12 +++++++++---
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index ea0e24bba8b6..a5c01ff42c78 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2222,6 +2222,7 @@ static void arm_host_initfn(Object *obj)
     ARMCPU *cpu = ARM_CPU(obj);
 
     kvm_arm_set_cpu_features_from_host(cpu);
+    aarch64_add_sve_vls_map_property(obj);
     arm_cpu_post_init(obj);
 }
 
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index f0d0ce759ba8..13731ccb39f3 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -976,11 +976,13 @@ int aarch64_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
 void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq);
 void aarch64_sve_change_el(CPUARMState *env, int old_el,
                            int new_el, bool el0_a64);
+void aarch64_add_sve_vls_map_property(Object *obj);
 #else
 static inline void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq) { }
 static inline void aarch64_sve_change_el(CPUARMState *env, int o,
                                          int n, bool a)
 { }
+void aarch64_add_sve_vls_map_property(Object *obj) { }
 #endif
 
 target_ulong do_arm_semihosting(CPUARMState *env);
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 94f3dd5b51e5..3b0b900a4d97 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -310,7 +310,8 @@ static void cpu_set_sve_vls_map(Object *obj, Visitor *v, const char *name,
             error_setg(&err, "SVE vector length map has unsupported lengths");
             error_append_hint(&err, "Valid vector lengths in range [1-%d]\n",
                               ARM_MAX_VQ);
-        } else if (cpu->sve_max_vq != ARM_MAX_VQ && cpu->sve_max_vq != -1 &&
+        } else if (cpu->sve_max_vq && cpu->sve_max_vq != ARM_MAX_VQ &&
+                   cpu->sve_max_vq != -1 &&
                    cpu->sve_max_vq != arm_cpu_fls64(cpu->sve_vls_map)) {
             /*
              * If the user provides both sve-max-vq and sve-vls-map, with
@@ -340,6 +341,12 @@ static void cpu_set_sve_vls_map(Object *obj, Visitor *v, const char *name,
     error_propagate(errp, err);
 }
 
+void aarch64_add_sve_vls_map_property(Object *obj)
+{
+    object_property_add(obj, "sve-vls-map", "uint64", cpu_get_sve_vls_map,
+                        cpu_set_sve_vls_map, NULL, NULL, &error_fatal);
+}
+
 /* -cpu max: if KVM is enabled, like -cpu host (best possible with this host);
  * otherwise, a CPU with as many features enabled as our emulation supports.
  * The version of '-cpu max' for qemu-system-arm is defined in cpu.c;
@@ -437,8 +444,7 @@ static void aarch64_max_initfn(Object *obj)
 
     object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_vq,
                         cpu_max_set_sve_vq, NULL, NULL, &error_fatal);
-    object_property_add(obj, "sve-vls-map", "uint64", cpu_get_sve_vls_map,
-                        cpu_set_sve_vls_map, NULL, NULL, &error_fatal);
+    aarch64_add_sve_vls_map_property(obj);
 }
 
 struct ARMCPUInfo {
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
	armbru@redhat.com, abologna@redhat.com, alex.bennee@linaro.org,
	Dave.Martin@arm.com
Subject: [Qemu-devel] [PATCH 13/13] target/arm/kvm: host cpu: Add support for sve-vls-map
Date: Sun, 12 May 2019 10:36:24 +0200	[thread overview]
Message-ID: <20190512083624.8916-14-drjones@redhat.com> (raw)
In-Reply-To: <20190512083624.8916-1-drjones@redhat.com>

Allow the host cpu type to enable SVE in guests with the sve-vls-map
cpu property.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 target/arm/cpu.c   |  1 +
 target/arm/cpu.h   |  2 ++
 target/arm/cpu64.c | 12 +++++++++---
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index ea0e24bba8b6..a5c01ff42c78 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -2222,6 +2222,7 @@ static void arm_host_initfn(Object *obj)
     ARMCPU *cpu = ARM_CPU(obj);
 
     kvm_arm_set_cpu_features_from_host(cpu);
+    aarch64_add_sve_vls_map_property(obj);
     arm_cpu_post_init(obj);
 }
 
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index f0d0ce759ba8..13731ccb39f3 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -976,11 +976,13 @@ int aarch64_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
 void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq);
 void aarch64_sve_change_el(CPUARMState *env, int old_el,
                            int new_el, bool el0_a64);
+void aarch64_add_sve_vls_map_property(Object *obj);
 #else
 static inline void aarch64_sve_narrow_vq(CPUARMState *env, unsigned vq) { }
 static inline void aarch64_sve_change_el(CPUARMState *env, int o,
                                          int n, bool a)
 { }
+void aarch64_add_sve_vls_map_property(Object *obj) { }
 #endif
 
 target_ulong do_arm_semihosting(CPUARMState *env);
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 94f3dd5b51e5..3b0b900a4d97 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -310,7 +310,8 @@ static void cpu_set_sve_vls_map(Object *obj, Visitor *v, const char *name,
             error_setg(&err, "SVE vector length map has unsupported lengths");
             error_append_hint(&err, "Valid vector lengths in range [1-%d]\n",
                               ARM_MAX_VQ);
-        } else if (cpu->sve_max_vq != ARM_MAX_VQ && cpu->sve_max_vq != -1 &&
+        } else if (cpu->sve_max_vq && cpu->sve_max_vq != ARM_MAX_VQ &&
+                   cpu->sve_max_vq != -1 &&
                    cpu->sve_max_vq != arm_cpu_fls64(cpu->sve_vls_map)) {
             /*
              * If the user provides both sve-max-vq and sve-vls-map, with
@@ -340,6 +341,12 @@ static void cpu_set_sve_vls_map(Object *obj, Visitor *v, const char *name,
     error_propagate(errp, err);
 }
 
+void aarch64_add_sve_vls_map_property(Object *obj)
+{
+    object_property_add(obj, "sve-vls-map", "uint64", cpu_get_sve_vls_map,
+                        cpu_set_sve_vls_map, NULL, NULL, &error_fatal);
+}
+
 /* -cpu max: if KVM is enabled, like -cpu host (best possible with this host);
  * otherwise, a CPU with as many features enabled as our emulation supports.
  * The version of '-cpu max' for qemu-system-arm is defined in cpu.c;
@@ -437,8 +444,7 @@ static void aarch64_max_initfn(Object *obj)
 
     object_property_add(obj, "sve-max-vq", "uint32", cpu_max_get_sve_vq,
                         cpu_max_set_sve_vq, NULL, NULL, &error_fatal);
-    object_property_add(obj, "sve-vls-map", "uint64", cpu_get_sve_vls_map,
-                        cpu_set_sve_vls_map, NULL, NULL, &error_fatal);
+    aarch64_add_sve_vls_map_property(obj);
 }
 
 struct ARMCPUInfo {
-- 
2.20.1



  parent reply	other threads:[~2019-05-12  8:37 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-12  8:36 [PATCH 00/13] target/arm/kvm: enable SVE in guests Andrew Jones
2019-05-12  8:36 ` [Qemu-devel] " Andrew Jones
2019-05-12  8:36 ` [PATCH 01/13] target/arm/kvm64: fix error returns Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-06-05  7:20   ` Auger Eric
2019-05-12  8:36 ` [PATCH 02/13] update-linux-headers: Add sve_context.h to asm-arm64 Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-06-05  7:21   ` Auger Eric
2019-06-05  7:30     ` Andrew Jones
2019-06-05  7:30       ` Andrew Jones
2019-05-12  8:36 ` [PATCH 03/13] HACK: linux header update Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-12  8:36 ` [PATCH 04/13] target/arm/kvm: Move the get/put of fpsimd registers out Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-06-05  7:15   ` Auger Eric
2019-06-05  7:27     ` Andrew Jones
2019-06-05  7:27       ` Andrew Jones
2019-05-12  8:36 ` [PATCH 05/13] target/arm/kvm: Add kvm_arch_get/put_sve Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-13 12:31   ` Dave Martin
2019-05-13 12:31     ` [Qemu-devel] " Dave Martin
2019-05-13 13:55     ` Andrew Jones
2019-05-13 13:55       ` Andrew Jones
2019-05-13 15:31       ` Dave Martin
2019-05-13 15:31         ` Dave Martin
2019-05-13 15:40         ` Peter Maydell
2019-05-13 15:40           ` Peter Maydell
2019-05-13 16:05           ` Dave Martin
2019-05-13 16:05             ` Dave Martin
2019-05-13 16:40     ` Richard Henderson
2019-05-13 16:40       ` [Qemu-devel] " Richard Henderson
2019-05-13 18:14       ` Andrew Jones
2019-05-13 18:14         ` [Qemu-devel] " Andrew Jones
2019-05-13 18:31         ` Richard Henderson
2019-05-13 18:31           ` [Qemu-devel] " Richard Henderson
2019-05-13 12:43   ` Dave Martin
2019-05-13 12:43     ` [Qemu-devel] " Dave Martin
2019-05-13 14:07     ` Andrew Jones
2019-05-13 14:07       ` Andrew Jones
2019-05-13 14:39       ` Dave Martin
2019-05-13 14:39         ` Dave Martin
2019-05-13 16:58         ` Richard Henderson
2019-05-13 16:58           ` Richard Henderson
2019-05-14  9:10           ` Dave Martin
2019-05-14  9:10             ` Dave Martin
2019-05-12  8:36 ` [PATCH 06/13] target/arm/kvm: max cpu: Enable SVE when available Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-06-05  9:09   ` Auger Eric
2019-06-05 11:04     ` Andrew Jones
2019-06-05 11:04       ` Andrew Jones
2019-05-12  8:36 ` [PATCH 07/13] target/arm/kvm: max cpu: Allow sve max vector length setting Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-13 17:19   ` Richard Henderson
2019-05-13 17:19     ` [Qemu-devel] " Richard Henderson
2019-05-13 18:19     ` Andrew Jones
2019-05-13 18:19       ` Andrew Jones
2019-06-06  8:30   ` Auger Eric
2019-06-06  8:53     ` Andrew Jones
2019-06-06  8:53       ` Andrew Jones
2019-05-12  8:36 ` [PATCH 08/13] target/arm/monitor: Add query-sve-vector-lengths Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-13 16:12   ` Markus Armbruster
2019-05-13 16:12     ` Markus Armbruster
2019-05-13 18:30     ` Andrew Jones
2019-05-13 18:30       ` Andrew Jones
2019-05-14  5:32       ` Markus Armbruster
2019-05-12  8:36 ` [PATCH 09/13] target/arm/kvm: Export kvm_arm_get_sve_vls Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-12  8:36 ` [PATCH 10/13] target/arm/monitor: kvm: only return valid sve vector sets Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-12  8:36 ` [PATCH 11/13] target/arm/cpu64: max cpu: Introduce sve-vls-map Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-13 11:26   ` Dave Martin
2019-05-13 11:26     ` [Qemu-devel] " Dave Martin
2019-05-13 12:30     ` Andrew Jones
2019-05-13 12:30       ` Andrew Jones
2019-05-13 12:41       ` Dave Martin
2019-05-13 12:41         ` Dave Martin
2019-05-13 12:57         ` Andrew Jones
2019-05-13 12:57           ` Andrew Jones
2019-05-13 13:12           ` Dave Martin
2019-05-13 13:12             ` Dave Martin
2019-05-13 13:45             ` Andrew Jones
2019-05-13 13:45               ` Andrew Jones
2019-05-13 14:35               ` Dave Martin
2019-05-13 14:35                 ` Dave Martin
2019-05-13 15:25   ` Markus Armbruster
2019-05-13 15:25     ` Markus Armbruster
2019-05-13 18:31     ` Andrew Jones
2019-05-13 18:31       ` Andrew Jones
2019-05-12  8:36 ` [PATCH 12/13] target/arm/kvm: max cpu: Add support for sve-vls-map Andrew Jones
2019-05-12  8:36   ` [Qemu-devel] " Andrew Jones
2019-05-12  8:36 ` Andrew Jones [this message]
2019-05-12  8:36   ` [Qemu-devel] [PATCH 13/13] target/arm/kvm: host " Andrew Jones
2019-05-13 15:37   ` Markus Armbruster
2019-05-13 15:37     ` Markus Armbruster
2019-05-13 18:33     ` Andrew Jones
2019-05-13 18:33       ` Andrew Jones
2019-05-13  9:32 ` [PATCH 00/13] target/arm/kvm: enable SVE in guests Andrea Bolognani
2019-05-13  9:32   ` [Qemu-devel] " Andrea Bolognani
2019-05-13 11:15   ` Dave Martin
2019-05-13 11:15     ` [Qemu-devel] " Dave Martin
2019-05-13 12:38     ` Andrew Jones
2019-05-13 12:38       ` [Qemu-devel] " Andrew Jones
2019-05-13 12:50       ` Dave Martin
2019-05-13 12:50         ` [Qemu-devel] " Dave Martin
2019-05-13 12:36   ` Andrew Jones
2019-05-13 12:36     ` Andrew Jones
2019-05-14 12:29     ` Andrea Bolognani
2019-05-14 12:29       ` Andrea Bolognani
2019-05-14 12:53       ` Andrew Jones
2019-05-14 16:03         ` Andrea Bolognani
2019-05-14 20:14           ` Richard Henderson
2019-05-15  8:03             ` Andrea Bolognani
2019-05-15 11:14               ` Dave Martin
2019-05-15 11:14                 ` Dave Martin
2019-05-15 11:28                 ` Andrea Bolognani
2019-05-15 11:28                   ` Andrea Bolognani
2019-05-15 12:47                   ` Dave Martin
2019-05-15 12:47                     ` Dave Martin
2019-05-15  9:15           ` Andrew Jones
2019-05-13  9:52 ` Peter Maydell
2019-05-13  9:52   ` [Qemu-devel] " Peter Maydell
2019-05-13 12:43   ` Andrew Jones
2019-05-13 12:43     ` Andrew Jones
2019-05-13 18:46 ` Richard Henderson
2019-05-13 18:46   ` [Qemu-devel] " Richard Henderson
2019-05-13 19:16   ` Andrew Jones
2019-05-13 19:16     ` [Qemu-devel] " Andrew Jones
2019-05-14  9:05   ` Peter Maydell
2019-05-14  9:05     ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190512083624.8916-14-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=Dave.Martin@arm.com \
    --cc=abologna@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.