All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Amelie Delaunay <amelie.delaunay@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mfd: stmfx: Fix macro definition spelling
Date: Tue, 14 May 2019 19:54:04 +0100	[thread overview]
Message-ID: <20190514185404.GP4319@dell> (raw)
In-Reply-To: <20190514183900.GA7559@archlinux-i9>

On Tue, 14 May 2019, Nathan Chancellor wrote:

> On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote:
> > On Fri, 10 May 2019, Nathan Chancellor wrote:
> > 
> > > Clang warns:
> > > 
> > > In file included from drivers/mfd/stmfx.c:13:
> > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> > > header guard here, followed by #define of a different macro
> > > [-Wheader-guard]
> > > 
> > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/475
> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > > ---
> > >  include/linux/mfd/stmfx.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Applied, thanks.
> > 
> 
> Hi Lee,
> 
> Thanks for picking it up. It seems this didn't make it into your MFD
> pull request for 5.2, was that intentional? It would be nice to avoid
> this warning.

Hmm... no it was not intentional.  Not sure what happened there.

I will pick it up for the -rcs.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Amelie Delaunay <amelie.delaunay@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] mfd: stmfx: Fix macro definition spelling
Date: Tue, 14 May 2019 19:54:04 +0100	[thread overview]
Message-ID: <20190514185404.GP4319@dell> (raw)
In-Reply-To: <20190514183900.GA7559@archlinux-i9>

On Tue, 14 May 2019, Nathan Chancellor wrote:

> On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote:
> > On Fri, 10 May 2019, Nathan Chancellor wrote:
> > 
> > > Clang warns:
> > > 
> > > In file included from drivers/mfd/stmfx.c:13:
> > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> > > header guard here, followed by #define of a different macro
> > > [-Wheader-guard]
> > > 
> > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/475
> > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > > ---
> > >  include/linux/mfd/stmfx.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Applied, thanks.
> > 
> 
> Hi Lee,
> 
> Thanks for picking it up. It seems this didn't make it into your MFD
> pull request for 5.2, was that intentional? It would be nice to avoid
> this warning.

Hmm... no it was not intentional.  Not sure what happened there.

I will pick it up for the -rcs.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2019-05-14 18:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-11  1:23 [PATCH] mfd: stmfx: Fix macro definition spelling Nathan Chancellor
2019-05-11  1:23 ` Nathan Chancellor
2019-05-13  7:10 ` Amelie DELAUNAY
2019-05-13  7:10   ` Amelie DELAUNAY
2019-05-13  7:30 ` Lee Jones
2019-05-13  7:30   ` Lee Jones
2019-05-14 18:39   ` Nathan Chancellor
2019-05-14 18:39     ` Nathan Chancellor
2019-05-14 18:54     ` Lee Jones [this message]
2019-05-14 18:54       ` Lee Jones
2019-05-14 19:45       ` Nathan Chancellor
2019-05-14 19:45         ` Nathan Chancellor
2019-06-14  3:57       ` Nathan Chancellor
2019-06-14  3:57         ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190514185404.GP4319@dell \
    --to=lee.jones@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=amelie.delaunay@st.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=natechancellor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.