All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH v1] libxl: fix device_model_version related assert
Date: Fri, 17 May 2019 10:24:45 +0200	[thread overview]
Message-ID: <20190517102445.709835c8.olaf@aepfle.de> (raw)
In-Reply-To: <20190516133013.GG2798@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

Am Thu, 16 May 2019 14:30:13 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> @@ -457,6 +457,12 @@ int libxl_domain_need_memory(libxl_ctx *ctx,
> +    if (!b_info->device_model_version)
> +       b_info->device_model_version = LIBXL_DEVICE_MODEL_XXX;

I think this will work and should be applied to unbreak staging.

The proposed libxl_domain_config_finalyze(libxl_domain_config*) in the
other thread about the regression will most likely be ugly. Something
more elegant has to be found.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH v1] libxl: fix device_model_version related assert
Date: Fri, 17 May 2019 10:24:45 +0200	[thread overview]
Message-ID: <20190517102445.709835c8.olaf@aepfle.de> (raw)
Message-ID: <20190517082445.OBTUUMDnixzSGh6X10QW_BLZvmyRWdqw0sXpX7QLN6I@z> (raw)
In-Reply-To: <20190516133013.GG2798@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

Am Thu, 16 May 2019 14:30:13 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> @@ -457,6 +457,12 @@ int libxl_domain_need_memory(libxl_ctx *ctx,
> +    if (!b_info->device_model_version)
> +       b_info->device_model_version = LIBXL_DEVICE_MODEL_XXX;

I think this will work and should be applied to unbreak staging.

The proposed libxl_domain_config_finalyze(libxl_domain_config*) in the
other thread about the regression will most likely be ugly. Something
more elegant has to be found.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-17  8:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 12:50 [PATCH v1] libxl: fix device_model_version related assert Olaf Hering
2019-05-16 12:50 ` [Xen-devel] " Olaf Hering
2019-05-16 13:30 ` Wei Liu
2019-05-16 13:30   ` [Xen-devel] " Wei Liu
2019-05-16 13:36   ` Olaf Hering
2019-05-16 13:36     ` [Xen-devel] " Olaf Hering
2019-05-16 13:46     ` Wei Liu
2019-05-16 13:46       ` [Xen-devel] " Wei Liu
2019-05-16 13:54       ` Olaf Hering
2019-05-16 13:54         ` [Xen-devel] " Olaf Hering
2019-05-16 15:03         ` Wei Liu
2019-05-16 15:03           ` [Xen-devel] " Wei Liu
2019-05-16 15:09           ` Olaf Hering
2019-05-16 15:09             ` [Xen-devel] " Olaf Hering
2019-05-17  8:24   ` Olaf Hering [this message]
2019-05-17  8:24     ` Olaf Hering
2019-05-17 16:42     ` Wei Liu
2019-05-17 16:42       ` [Xen-devel] " Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517102445.709835c8.olaf@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.