* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514215315.19228-1-lede@allycomm.com> @ 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-14 21:53 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-14 21:53 ` Jeff Kletsky @ 2019-05-15 6:17 ` Marek Vasut -1 siblings, 0 replies; 25+ messages in thread From: Marek Vasut @ 2019-05-15 6:17 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd, linux-kernel On 5/14/19 11:53 PM, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> That #define in $subject is called a macro. Seems this patch adds a lot of almost duplicate code, can it be somehow de-duplicated ? > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > -- Best regards, Marek Vasut ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-15 6:17 ` Marek Vasut 0 siblings, 0 replies; 25+ messages in thread From: Marek Vasut @ 2019-05-15 6:17 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd, linux-kernel On 5/14/19 11:53 PM, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> That #define in $subject is called a macro. Seems this patch adds a lot of almost duplicate code, can it be somehow de-duplicated ? > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > -- Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-15 6:17 ` Marek Vasut @ 2019-05-15 6:49 ` Schrempf Frieder -1 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:49 UTC (permalink / raw) To: Marek Vasut, Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 15.05.19 08:17, Marek Vasut wrote: > On 5/14/19 11:53 PM, Jeff Kletsky wrote: >> From: Jeff Kletsky <git-commits@allycomm.com> > > That #define in $subject is called a macro. > > Seems this patch adds a lot of almost duplicate code, can it be somehow > de-duplicated ? We could add another parameter naddr or addrlen to the SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. This would cause one more argument to each of the macro calls in all chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm not sure if this really would make things easier and also this is "only" preprocessor code. So anyways, I would be fine with both approaches, Jeff's current one or one with another parameter for the address length. By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will just reply again to add the tags. > >> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >> for its page-read ops. >> >> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >> >> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >> --- >> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index b92e2aa955b6..05fe98eebe27 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -68,30 +68,60 @@ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 1)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 2), \ >> SPI_MEM_OP_DUMMY(ndummy, 2), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 2), \ >> + SPI_MEM_OP_DUMMY(ndummy, 2), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 4), \ >> SPI_MEM_OP_DUMMY(ndummy, 4), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 4), \ >> + SPI_MEM_OP_DUMMY(ndummy, 4), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PROG_EXEC_OP(addr) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ >> SPI_MEM_OP_ADDR(3, addr, 1), \ >> > > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-15 6:49 ` Schrempf Frieder 0 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:49 UTC (permalink / raw) To: Marek Vasut, Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 15.05.19 08:17, Marek Vasut wrote: > On 5/14/19 11:53 PM, Jeff Kletsky wrote: >> From: Jeff Kletsky <git-commits@allycomm.com> > > That #define in $subject is called a macro. > > Seems this patch adds a lot of almost duplicate code, can it be somehow > de-duplicated ? We could add another parameter naddr or addrlen to the SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. This would cause one more argument to each of the macro calls in all chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm not sure if this really would make things easier and also this is "only" preprocessor code. So anyways, I would be fine with both approaches, Jeff's current one or one with another parameter for the address length. By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will just reply again to add the tags. > >> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >> for its page-read ops. >> >> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >> >> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >> --- >> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index b92e2aa955b6..05fe98eebe27 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -68,30 +68,60 @@ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 1)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 1), \ >> SPI_MEM_OP_DUMMY(ndummy, 1), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 1), \ >> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 2), \ >> SPI_MEM_OP_DUMMY(ndummy, 2), \ >> SPI_MEM_OP_DATA_IN(len, buf, 2)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 2), \ >> + SPI_MEM_OP_DUMMY(ndummy, 2), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 2)) >> + >> #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> SPI_MEM_OP_ADDR(2, addr, 4), \ >> SPI_MEM_OP_DUMMY(ndummy, 4), \ >> SPI_MEM_OP_DATA_IN(len, buf, 4)) >> >> +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ >> + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ >> + SPI_MEM_OP_ADDR(3, addr, 4), \ >> + SPI_MEM_OP_DUMMY(ndummy, 4), \ >> + SPI_MEM_OP_DATA_IN(len, buf, 4)) >> + >> #define SPINAND_PROG_EXEC_OP(addr) \ >> SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ >> SPI_MEM_OP_ADDR(3, addr, 1), \ >> > > ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-15 6:49 ` Schrempf Frieder @ 2019-05-19 20:27 ` Jeff Kletsky -1 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-19 20:27 UTC (permalink / raw) To: Schrempf Frieder, Marek Vasut, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 5/14/19 11:49 PM, Schrempf Frieder wrote: > On 15.05.19 08:17, Marek Vasut wrote: >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: >>> From: Jeff Kletsky <git-commits@allycomm.com> >> That #define in $subject is called a macro. >> >> Seems this patch adds a lot of almost duplicate code, can it be somehow >> de-duplicated ? > We could add another parameter naddr or addrlen to the > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > This would cause one more argument to each of the macro calls in all > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > not sure if this really would make things easier and also this is "only" > preprocessor code. > > So anyways, I would be fine with both approaches, Jeff's current one or > one with another parameter for the address length. > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > just reply again to add the tags. > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >>> for its page-read ops. >>> >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >>> >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >>> --- >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >>> index b92e2aa955b6..05fe98eebe27 100644 >>> --- a/include/linux/mtd/spinand.h >>> +++ b/include/linux/mtd/spinand.h >>> @@ -68,30 +68,60 @@ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> + >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >>> SPI_MEM_OP_ADDR(2, addr, 1), \ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) >>> >>> [ _3A addition repeated three more times for similar ops ... ] It's easy enough to change the wording, and will do so on the next revision. However, it's not clear to me that there is consensus on if the present set of macros is acceptable/preferred over definition of a set of ones that accept an additional parameter. At least from my perspective and as Schrempf Frieder has hinted at, these macros are syntactic sugar and all result in equivalent C code. Either should compile to the same run-time size and performance (assuming reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). Adding an additional parameter, at least for me, wouldn't improve readability of the code and is offset by the need to refactor four other files. Even though it should be a simple/trivial refactor, I do not have any examples of the four other manufacturers' chips to be able to confirm proper operation. I'll prepare a reworded set of patches with the present macro structure. If there is strong feeling for refactoring the macro set, please let me know. Jeff ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-19 20:27 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-19 20:27 UTC (permalink / raw) To: Schrempf Frieder, Marek Vasut, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 5/14/19 11:49 PM, Schrempf Frieder wrote: > On 15.05.19 08:17, Marek Vasut wrote: >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: >>> From: Jeff Kletsky <git-commits@allycomm.com> >> That #define in $subject is called a macro. >> >> Seems this patch adds a lot of almost duplicate code, can it be somehow >> de-duplicated ? > We could add another parameter naddr or addrlen to the > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > This would cause one more argument to each of the macro calls in all > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > not sure if this really would make things easier and also this is "only" > preprocessor code. > > So anyways, I would be fine with both approaches, Jeff's current one or > one with another parameter for the address length. > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > just reply again to add the tags. > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses >>> for its page-read ops. >>> >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >>> >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> >>> --- >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >>> index b92e2aa955b6..05fe98eebe27 100644 >>> --- a/include/linux/mtd/spinand.h >>> +++ b/include/linux/mtd/spinand.h >>> @@ -68,30 +68,60 @@ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) >>> + >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ >>> SPI_MEM_OP_ADDR(2, addr, 1), \ >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) >>> >>> [ _3A addition repeated three more times for similar ops ... ] It's easy enough to change the wording, and will do so on the next revision. However, it's not clear to me that there is consensus on if the present set of macros is acceptable/preferred over definition of a set of ones that accept an additional parameter. At least from my perspective and as Schrempf Frieder has hinted at, these macros are syntactic sugar and all result in equivalent C code. Either should compile to the same run-time size and performance (assuming reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). Adding an additional parameter, at least for me, wouldn't improve readability of the code and is offset by the need to refactor four other files. Even though it should be a simple/trivial refactor, I do not have any examples of the four other manufacturers' chips to be able to confirm proper operation. I'll prepare a reworded set of patches with the present macro structure. If there is strong feeling for refactoring the macro set, please let me know. Jeff ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-19 20:27 ` Jeff Kletsky @ 2019-05-20 12:16 ` Miquel Raynal -1 siblings, 0 replies; 25+ messages in thread From: Miquel Raynal @ 2019-05-20 12:16 UTC (permalink / raw) To: Jeff Kletsky Cc: Boris Brezillon, Richard Weinberger, linux-kernel@vger.kernel.org, Schrempf Frieder, Marek Vasut, linux-mtd@lists.infradead.org, Brian Norris, David Woodhouse Hi Jeff, Jeff Kletsky <lede@allycomm.com> wrote on Sun, 19 May 2019 13:27:58 -0700: > On 5/14/19 11:49 PM, Schrempf Frieder wrote: > > > On 15.05.19 08:17, Marek Vasut wrote: > >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: > >>> From: Jeff Kletsky <git-commits@allycomm.com> > >> That #define in $subject is called a macro. > >> > >> Seems this patch adds a lot of almost duplicate code, can it be somehow > >> de-duplicated ? > > We could add another parameter naddr or addrlen to the > > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > > > This would cause one more argument to each of the macro calls in all > > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > > not sure if this really would make things easier and also this is "only" > > preprocessor code. > > > > So anyways, I would be fine with both approaches, Jeff's current one or > > one with another parameter for the address length. > > > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > > just reply again to add the tags. > > > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > >>> for its page-read ops. > >>> > >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > >>> > >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > >>> --- > >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > >>> 1 file changed, 30 insertions(+) > >>> > >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > >>> index b92e2aa955b6..05fe98eebe27 100644 > >>> --- a/include/linux/mtd/spinand.h > >>> +++ b/include/linux/mtd/spinand.h > >>> @@ -68,30 +68,60 @@ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ > >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> + > >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > >>> SPI_MEM_OP_ADDR(2, addr, 1), \ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) > >>> >>> [ _3A addition repeated three more times for similar ops ... ] > > It's easy enough to change the wording, and will do so on the next revision. > > However, it's not clear to me that there is consensus on if the present > set of macros is acceptable/preferred over definition of a set of ones > that accept an additional parameter. > > At least from my perspective and as Schrempf Frieder has hinted at, > these macros are syntactic sugar and all result in equivalent C code. > > Either should compile to the same run-time size and performance (assuming > reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). > > Adding an additional parameter, at least for me, wouldn't improve readability > of the code and is offset by the need to refactor four other files. Even > though it should be a simple/trivial refactor, I do not have any examples > of the four other manufacturers' chips to be able to confirm proper operation. > > I'll prepare a reworded set of patches with the present macro structure. > > If there is strong feeling for refactoring the macro set, please let me know. On my side I would rather not add this extra argument, I know it is not very conventional to add so much macros but once you've read one you read all of them and I think it improves the readability of the code using it. Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-20 12:16 ` Miquel Raynal 0 siblings, 0 replies; 25+ messages in thread From: Miquel Raynal @ 2019-05-20 12:16 UTC (permalink / raw) To: Jeff Kletsky Cc: Schrempf Frieder, Marek Vasut, Boris Brezillon, Richard Weinberger, David Woodhouse, Brian Norris, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Hi Jeff, Jeff Kletsky <lede@allycomm.com> wrote on Sun, 19 May 2019 13:27:58 -0700: > On 5/14/19 11:49 PM, Schrempf Frieder wrote: > > > On 15.05.19 08:17, Marek Vasut wrote: > >> On 5/14/19 11:53 PM, Jeff Kletsky wrote: > >>> From: Jeff Kletsky <git-commits@allycomm.com> > >> That #define in $subject is called a macro. > >> > >> Seems this patch adds a lot of almost duplicate code, can it be somehow > >> de-duplicated ? > > We could add another parameter naddr or addrlen to the > > SPINAND_PAGE_READ_FROM_CACHE_XX_OPs and pass the value 2 for all > > existing chips except for GD5F1GQ4UFxxG which needs 3 bytes address length. > > > > This would cause one more argument to each of the macro calls in all > > chip drivers. As long as there are only two flavors (2 and 3 bytes) I'm > > not sure if this really would make things easier and also this is "only" > > preprocessor code. > > > > So anyways, I would be fine with both approaches, Jeff's current one or > > one with another parameter for the address length. > > > > By the way: Jeff, you didn't carry my Reviewed-by tag to v2. So I will > > just reply again to add the tags. > > > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > >>> for its page-read ops. > >>> > >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > >>> > >>> Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> > >>> --- > >>> include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > >>> 1 file changed, 30 insertions(+) > >>> > >>> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > >>> index b92e2aa955b6..05fe98eebe27 100644 > >>> --- a/include/linux/mtd/spinand.h > >>> +++ b/include/linux/mtd/spinand.h > >>> @@ -68,30 +68,60 @@ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> >>> +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > >>> + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > >>> + SPI_MEM_OP_ADDR(3, addr, 1), \ > >>> + SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> + SPI_MEM_OP_DATA_IN(len, buf, 1)) > >>> + > >>> #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > >>> SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > >>> SPI_MEM_OP_ADDR(2, addr, 1), \ > >>> SPI_MEM_OP_DUMMY(ndummy, 1), \ > >>> SPI_MEM_OP_DATA_IN(len, buf, 2)) > >>> >>> [ _3A addition repeated three more times for similar ops ... ] > > It's easy enough to change the wording, and will do so on the next revision. > > However, it's not clear to me that there is consensus on if the present > set of macros is acceptable/preferred over definition of a set of ones > that accept an additional parameter. > > At least from my perspective and as Schrempf Frieder has hinted at, > these macros are syntactic sugar and all result in equivalent C code. > > Either should compile to the same run-time size and performance (assuming > reasonably that a construct like `true ? 0x0b : 0x03` is optimized out). > > Adding an additional parameter, at least for me, wouldn't improve readability > of the code and is offset by the need to refactor four other files. Even > though it should be a simple/trivial refactor, I do not have any examples > of the four other manufacturers' chips to be able to confirm proper operation. > > I'll prepare a reworded set of patches with the present macro structure. > > If there is strong feeling for refactoring the macro set, please let me know. On my side I would rather not add this extra argument, I know it is not very conventional to add so much macros but once you've read one you read all of them and I think it improves the readability of the code using it. Thanks, Miquèl ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses 2019-05-14 21:53 ` Jeff Kletsky @ 2019-05-15 6:51 ` Schrempf Frieder -1 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:51 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-15 6:51 ` Schrempf Frieder 0 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:51 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses > for its page-read ops. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index b92e2aa955b6..05fe98eebe27 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -68,30 +68,60 @@ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 1)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 1)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > SPI_MEM_OP_ADDR(2, addr, 1), \ > SPI_MEM_OP_DUMMY(ndummy, 1), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 1), \ > + SPI_MEM_OP_DUMMY(ndummy, 1), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 2), \ > SPI_MEM_OP_DUMMY(ndummy, 2), \ > SPI_MEM_OP_DATA_IN(len, buf, 2)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 2), \ > + SPI_MEM_OP_DUMMY(ndummy, 2), \ > + SPI_MEM_OP_DATA_IN(len, buf, 2)) > + > #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > SPI_MEM_OP_ADDR(2, addr, 4), \ > SPI_MEM_OP_DUMMY(ndummy, 4), \ > SPI_MEM_OP_DATA_IN(len, buf, 4)) > > +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ > + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ > + SPI_MEM_OP_ADDR(3, addr, 4), \ > + SPI_MEM_OP_DUMMY(ndummy, 4), \ > + SPI_MEM_OP_DATA_IN(len, buf, 4)) > + > #define SPINAND_PROG_EXEC_OP(addr) \ > SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ > SPI_MEM_OP_ADDR(3, addr, 1), \ > ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 2/3] mtd: spinand: Add support for two-byte device IDs [not found] <20190514215315.19228-1-lede@allycomm.com> @ 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes two-byte device IDs. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- drivers/mtd/nand/spi/core.c | 2 +- include/linux/mtd/spinand.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index fa87ae28cdfe..a13154785dad 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -853,7 +853,7 @@ spinand_select_op_variant(struct spinand_device *spinand, */ int spinand_match_and_init(struct spinand_device *spinand, const struct spinand_info *table, - unsigned int table_size, u8 devid) + unsigned int table_size, u16 devid) { struct nand_device *nand = spinand_to_nand(spinand); unsigned int i; diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index 05fe98eebe27..8901ba272538 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -290,7 +290,7 @@ struct spinand_ecc_info { */ struct spinand_info { const char *model; - u8 devid; + u16 devid; u32 flags; struct nand_memory_organization memorg; struct nand_ecc_req eccreq; @@ -445,7 +445,7 @@ static inline void spinand_set_of_node(struct spinand_device *spinand, int spinand_match_and_init(struct spinand_device *dev, const struct spinand_info *table, - unsigned int table_size, u8 devid); + unsigned int table_size, u16 devid); int spinand_upd_cfg(struct spinand_device *spinand, u8 mask, u8 val); int spinand_select_target(struct spinand_device *spinand, unsigned int target); -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 2/3] mtd: spinand: Add support for two-byte device IDs @ 2019-05-14 21:53 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes two-byte device IDs. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- drivers/mtd/nand/spi/core.c | 2 +- include/linux/mtd/spinand.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index fa87ae28cdfe..a13154785dad 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -853,7 +853,7 @@ spinand_select_op_variant(struct spinand_device *spinand, */ int spinand_match_and_init(struct spinand_device *spinand, const struct spinand_info *table, - unsigned int table_size, u8 devid) + unsigned int table_size, u16 devid) { struct nand_device *nand = spinand_to_nand(spinand); unsigned int i; diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index 05fe98eebe27..8901ba272538 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -290,7 +290,7 @@ struct spinand_ecc_info { */ struct spinand_info { const char *model; - u8 devid; + u16 devid; u32 flags; struct nand_memory_organization memorg; struct nand_ecc_req eccreq; @@ -445,7 +445,7 @@ static inline void spinand_set_of_node(struct spinand_device *spinand, int spinand_match_and_init(struct spinand_device *dev, const struct spinand_info *table, - unsigned int table_size, u8 devid); + unsigned int table_size, u16 devid); int spinand_upd_cfg(struct spinand_device *spinand, u8 mask, u8 val); int spinand_select_target(struct spinand_device *spinand, unsigned int target); -- 2.20.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 2/3] mtd: spinand: Add support for two-byte device IDs 2019-05-14 21:53 ` Jeff Kletsky @ 2019-05-15 6:52 ` Schrempf Frieder -1 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:52 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes two-byte device IDs. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > drivers/mtd/nand/spi/core.c | 2 +- > include/linux/mtd/spinand.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index fa87ae28cdfe..a13154785dad 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -853,7 +853,7 @@ spinand_select_op_variant(struct spinand_device *spinand, > */ > int spinand_match_and_init(struct spinand_device *spinand, > const struct spinand_info *table, > - unsigned int table_size, u8 devid) > + unsigned int table_size, u16 devid) > { > struct nand_device *nand = spinand_to_nand(spinand); > unsigned int i; > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 05fe98eebe27..8901ba272538 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -290,7 +290,7 @@ struct spinand_ecc_info { > */ > struct spinand_info { > const char *model; > - u8 devid; > + u16 devid; > u32 flags; > struct nand_memory_organization memorg; > struct nand_ecc_req eccreq; > @@ -445,7 +445,7 @@ static inline void spinand_set_of_node(struct spinand_device *spinand, > > int spinand_match_and_init(struct spinand_device *dev, > const struct spinand_info *table, > - unsigned int table_size, u8 devid); > + unsigned int table_size, u16 devid); > > int spinand_upd_cfg(struct spinand_device *spinand, u8 mask, u8 val); > int spinand_select_target(struct spinand_device *spinand, unsigned int target); > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 2/3] mtd: spinand: Add support for two-byte device IDs @ 2019-05-15 6:52 ` Schrempf Frieder 0 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:52 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes two-byte device IDs. > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > drivers/mtd/nand/spi/core.c | 2 +- > include/linux/mtd/spinand.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index fa87ae28cdfe..a13154785dad 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -853,7 +853,7 @@ spinand_select_op_variant(struct spinand_device *spinand, > */ > int spinand_match_and_init(struct spinand_device *spinand, > const struct spinand_info *table, > - unsigned int table_size, u8 devid) > + unsigned int table_size, u16 devid) > { > struct nand_device *nand = spinand_to_nand(spinand); > unsigned int i; > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 05fe98eebe27..8901ba272538 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -290,7 +290,7 @@ struct spinand_ecc_info { > */ > struct spinand_info { > const char *model; > - u8 devid; > + u16 devid; > u32 flags; > struct nand_memory_organization memorg; > struct nand_ecc_req eccreq; > @@ -445,7 +445,7 @@ static inline void spinand_set_of_node(struct spinand_device *spinand, > > int spinand_match_and_init(struct spinand_device *dev, > const struct spinand_info *table, > - unsigned int table_size, u8 devid); > + unsigned int table_size, u16 devid); > > int spinand_upd_cfg(struct spinand_device *spinand, u8 mask, u8 val); > int spinand_select_target(struct spinand_device *spinand, unsigned int target); > ^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG [not found] <20190514215315.19228-1-lede@allycomm.com> @ 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2019-05-14 21:53 ` Jeff Kletsky 2 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices and, while it has the same logical layout as the E-series devices, it differs in the SPI interfacing in significant ways. This support is contingent on previous commits to: * Add support for two-byte device IDs * Add #define-s for page-read ops with three-byte addresses http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- drivers/mtd/nand/spi/gigadevice.c | 79 +++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/spi/gigadevice.c b/drivers/mtd/nand/spi/gigadevice.c index 0b49d8264bef..d6497ac4c5d8 100644 --- a/drivers/mtd/nand/spi/gigadevice.c +++ b/drivers/mtd/nand/spi/gigadevice.c @@ -9,11 +9,17 @@ #include <linux/mtd/spinand.h> #define SPINAND_MFR_GIGADEVICE 0xC8 + #define GD5FXGQ4XA_STATUS_ECC_1_7_BITFLIPS (1 << 4) #define GD5FXGQ4XA_STATUS_ECC_8_BITFLIPS (3 << 4) #define GD5FXGQ4UEXXG_REG_STATUS2 0xf0 +#define GD5FXGQ4UXFXXG_STATUS_ECC_MASK (7 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS (0 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS (1 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR (7 << 4) + static SPINAND_OP_VARIANTS(read_cache_variants, SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), @@ -22,6 +28,14 @@ static SPINAND_OP_VARIANTS(read_cache_variants, SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); +static SPINAND_OP_VARIANTS(read_cache_variants_f, + SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(true, 0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(false, 0, 0, NULL, 0)); + static SPINAND_OP_VARIANTS(write_cache_variants, SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), SPINAND_PROG_LOAD(true, 0, NULL, 0)); @@ -59,6 +73,11 @@ static int gd5fxgq4xa_ooblayout_free(struct mtd_info *mtd, int section, return 0; } +static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { + .ecc = gd5fxgq4xa_ooblayout_ecc, + .free = gd5fxgq4xa_ooblayout_free, +}; + static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, u8 status) { @@ -83,7 +102,7 @@ static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, return -EINVAL; } -static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, +static int gd5fxgq4_variant2_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { if (section) @@ -95,7 +114,7 @@ static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, return 0; } -static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, +static int gd5fxgq4_variant2_ooblayout_free(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { if (section) @@ -108,6 +127,11 @@ static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, return 0; } +static const struct mtd_ooblayout_ops gd5fxgq4_variant2_ooblayout = { + .ecc = gd5fxgq4_variant2_ooblayout_ecc, + .free = gd5fxgq4_variant2_ooblayout_free, +}; + static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, u8 status) { @@ -150,15 +174,25 @@ static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, return -EINVAL; } -static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { - .ecc = gd5fxgq4xa_ooblayout_ecc, - .free = gd5fxgq4xa_ooblayout_free, -}; +static int gd5fxgq4ufxxg_ecc_get_status(struct spinand_device *spinand, + u8 status) +{ + switch (status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) { + case GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS: + return 0; -static const struct mtd_ooblayout_ops gd5fxgq4uexxg_ooblayout = { - .ecc = gd5fxgq4uexxg_ooblayout_ecc, - .free = gd5fxgq4uexxg_ooblayout_free, -}; + case GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS: + return 3; + + case GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR: + return -EBADMSG; + + default: /* (2 << 4) through (6 << 4) are 4-8 corrected errors */ + return ((status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) >> 4) + 2; + } + + return -EINVAL; +} static const struct spinand_info gigadevice_spinand_table[] = { SPINAND_INFO("GD5F1GQ4xA", 0xF1, @@ -195,25 +229,40 @@ static const struct spinand_info gigadevice_spinand_table[] = { &write_cache_variants, &update_cache_variants), 0, - SPINAND_ECCINFO(&gd5fxgq4uexxg_ooblayout, + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, gd5fxgq4uexxg_ecc_get_status)), + SPINAND_INFO("GD5F1GQ4UFxxG", 0xb148, + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants_f, + &write_cache_variants, + &update_cache_variants), + 0, + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, + gd5fxgq4ufxxg_ecc_get_status)), }; static int gigadevice_spinand_detect(struct spinand_device *spinand) { u8 *id = spinand->id.data; + u16 did; int ret; /* - * For GD NANDs, There is an address byte needed to shift in before IDs - * are read out, so the first byte in raw_id is dummy. + * Earlier GDF5-series devices (A,E) return [0][MID][DID] + * Later (F) devices return [MID][DID1][DID2] */ - if (id[1] != SPINAND_MFR_GIGADEVICE) + + if (id[0] == SPINAND_MFR_GIGADEVICE) + did = (id[1] << 8) + id[2]; + else if (id[0] == 0 && id[1] == SPINAND_MFR_GIGADEVICE) + did = id[2]; + else return 0; ret = spinand_match_and_init(spinand, gigadevice_spinand_table, ARRAY_SIZE(gigadevice_spinand_table), - id[2]); + did); if (ret) return ret; -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG @ 2019-05-14 21:53 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:53 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices and, while it has the same logical layout as the E-series devices, it differs in the SPI interfacing in significant ways. This support is contingent on previous commits to: * Add support for two-byte device IDs * Add #define-s for page-read ops with three-byte addresses http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- drivers/mtd/nand/spi/gigadevice.c | 79 +++++++++++++++++++++++++------ 1 file changed, 64 insertions(+), 15 deletions(-) diff --git a/drivers/mtd/nand/spi/gigadevice.c b/drivers/mtd/nand/spi/gigadevice.c index 0b49d8264bef..d6497ac4c5d8 100644 --- a/drivers/mtd/nand/spi/gigadevice.c +++ b/drivers/mtd/nand/spi/gigadevice.c @@ -9,11 +9,17 @@ #include <linux/mtd/spinand.h> #define SPINAND_MFR_GIGADEVICE 0xC8 + #define GD5FXGQ4XA_STATUS_ECC_1_7_BITFLIPS (1 << 4) #define GD5FXGQ4XA_STATUS_ECC_8_BITFLIPS (3 << 4) #define GD5FXGQ4UEXXG_REG_STATUS2 0xf0 +#define GD5FXGQ4UXFXXG_STATUS_ECC_MASK (7 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS (0 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS (1 << 4) +#define GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR (7 << 4) + static SPINAND_OP_VARIANTS(read_cache_variants, SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), @@ -22,6 +28,14 @@ static SPINAND_OP_VARIANTS(read_cache_variants, SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); +static SPINAND_OP_VARIANTS(read_cache_variants_f, + SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(true, 0, 1, NULL, 0), + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(false, 0, 0, NULL, 0)); + static SPINAND_OP_VARIANTS(write_cache_variants, SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), SPINAND_PROG_LOAD(true, 0, NULL, 0)); @@ -59,6 +73,11 @@ static int gd5fxgq4xa_ooblayout_free(struct mtd_info *mtd, int section, return 0; } +static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { + .ecc = gd5fxgq4xa_ooblayout_ecc, + .free = gd5fxgq4xa_ooblayout_free, +}; + static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, u8 status) { @@ -83,7 +102,7 @@ static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, return -EINVAL; } -static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, +static int gd5fxgq4_variant2_ooblayout_ecc(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { if (section) @@ -95,7 +114,7 @@ static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, return 0; } -static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, +static int gd5fxgq4_variant2_ooblayout_free(struct mtd_info *mtd, int section, struct mtd_oob_region *region) { if (section) @@ -108,6 +127,11 @@ static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, return 0; } +static const struct mtd_ooblayout_ops gd5fxgq4_variant2_ooblayout = { + .ecc = gd5fxgq4_variant2_ooblayout_ecc, + .free = gd5fxgq4_variant2_ooblayout_free, +}; + static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, u8 status) { @@ -150,15 +174,25 @@ static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, return -EINVAL; } -static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { - .ecc = gd5fxgq4xa_ooblayout_ecc, - .free = gd5fxgq4xa_ooblayout_free, -}; +static int gd5fxgq4ufxxg_ecc_get_status(struct spinand_device *spinand, + u8 status) +{ + switch (status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) { + case GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS: + return 0; -static const struct mtd_ooblayout_ops gd5fxgq4uexxg_ooblayout = { - .ecc = gd5fxgq4uexxg_ooblayout_ecc, - .free = gd5fxgq4uexxg_ooblayout_free, -}; + case GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS: + return 3; + + case GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR: + return -EBADMSG; + + default: /* (2 << 4) through (6 << 4) are 4-8 corrected errors */ + return ((status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) >> 4) + 2; + } + + return -EINVAL; +} static const struct spinand_info gigadevice_spinand_table[] = { SPINAND_INFO("GD5F1GQ4xA", 0xF1, @@ -195,25 +229,40 @@ static const struct spinand_info gigadevice_spinand_table[] = { &write_cache_variants, &update_cache_variants), 0, - SPINAND_ECCINFO(&gd5fxgq4uexxg_ooblayout, + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, gd5fxgq4uexxg_ecc_get_status)), + SPINAND_INFO("GD5F1GQ4UFxxG", 0xb148, + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), + NAND_ECCREQ(8, 512), + SPINAND_INFO_OP_VARIANTS(&read_cache_variants_f, + &write_cache_variants, + &update_cache_variants), + 0, + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, + gd5fxgq4ufxxg_ecc_get_status)), }; static int gigadevice_spinand_detect(struct spinand_device *spinand) { u8 *id = spinand->id.data; + u16 did; int ret; /* - * For GD NANDs, There is an address byte needed to shift in before IDs - * are read out, so the first byte in raw_id is dummy. + * Earlier GDF5-series devices (A,E) return [0][MID][DID] + * Later (F) devices return [MID][DID1][DID2] */ - if (id[1] != SPINAND_MFR_GIGADEVICE) + + if (id[0] == SPINAND_MFR_GIGADEVICE) + did = (id[1] << 8) + id[2]; + else if (id[0] == 0 && id[1] == SPINAND_MFR_GIGADEVICE) + did = id[2]; + else return 0; ret = spinand_match_and_init(spinand, gigadevice_spinand_table, ARRAY_SIZE(gigadevice_spinand_table), - id[2]); + did); if (ret) return ret; -- 2.20.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG 2019-05-14 21:53 ` Jeff Kletsky @ 2019-05-15 6:53 ` Schrempf Frieder -1 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:53 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices > and, while it has the same logical layout as the E-series devices, > it differs in the SPI interfacing in significant ways. > > This support is contingent on previous commits to: > > * Add support for two-byte device IDs > * Add #define-s for page-read ops with three-byte addresses > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > drivers/mtd/nand/spi/gigadevice.c | 79 +++++++++++++++++++++++++------ > 1 file changed, 64 insertions(+), 15 deletions(-) > > diff --git a/drivers/mtd/nand/spi/gigadevice.c b/drivers/mtd/nand/spi/gigadevice.c > index 0b49d8264bef..d6497ac4c5d8 100644 > --- a/drivers/mtd/nand/spi/gigadevice.c > +++ b/drivers/mtd/nand/spi/gigadevice.c > @@ -9,11 +9,17 @@ > #include <linux/mtd/spinand.h> > > #define SPINAND_MFR_GIGADEVICE 0xC8 > + > #define GD5FXGQ4XA_STATUS_ECC_1_7_BITFLIPS (1 << 4) > #define GD5FXGQ4XA_STATUS_ECC_8_BITFLIPS (3 << 4) > > #define GD5FXGQ4UEXXG_REG_STATUS2 0xf0 > > +#define GD5FXGQ4UXFXXG_STATUS_ECC_MASK (7 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS (0 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS (1 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR (7 << 4) > + > static SPINAND_OP_VARIANTS(read_cache_variants, > SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > @@ -22,6 +28,14 @@ static SPINAND_OP_VARIANTS(read_cache_variants, > SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); > > +static SPINAND_OP_VARIANTS(read_cache_variants_f, > + SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(false, 0, 0, NULL, 0)); > + > static SPINAND_OP_VARIANTS(write_cache_variants, > SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), > SPINAND_PROG_LOAD(true, 0, NULL, 0)); > @@ -59,6 +73,11 @@ static int gd5fxgq4xa_ooblayout_free(struct mtd_info *mtd, int section, > return 0; > } > > +static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { > + .ecc = gd5fxgq4xa_ooblayout_ecc, > + .free = gd5fxgq4xa_ooblayout_free, > +}; > + > static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > @@ -83,7 +102,7 @@ static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, > return -EINVAL; > } > > -static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, > +static int gd5fxgq4_variant2_ooblayout_ecc(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section) > @@ -95,7 +114,7 @@ static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, > return 0; > } > > -static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, > +static int gd5fxgq4_variant2_ooblayout_free(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section) > @@ -108,6 +127,11 @@ static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, > return 0; > } > > +static const struct mtd_ooblayout_ops gd5fxgq4_variant2_ooblayout = { > + .ecc = gd5fxgq4_variant2_ooblayout_ecc, > + .free = gd5fxgq4_variant2_ooblayout_free, > +}; > + > static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > @@ -150,15 +174,25 @@ static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, > return -EINVAL; > } > > -static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { > - .ecc = gd5fxgq4xa_ooblayout_ecc, > - .free = gd5fxgq4xa_ooblayout_free, > -}; > +static int gd5fxgq4ufxxg_ecc_get_status(struct spinand_device *spinand, > + u8 status) > +{ > + switch (status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) { > + case GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS: > + return 0; > > -static const struct mtd_ooblayout_ops gd5fxgq4uexxg_ooblayout = { > - .ecc = gd5fxgq4uexxg_ooblayout_ecc, > - .free = gd5fxgq4uexxg_ooblayout_free, > -}; > + case GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS: > + return 3; > + > + case GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR: > + return -EBADMSG; > + > + default: /* (2 << 4) through (6 << 4) are 4-8 corrected errors */ > + return ((status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) >> 4) + 2; > + } > + > + return -EINVAL; > +} > > static const struct spinand_info gigadevice_spinand_table[] = { > SPINAND_INFO("GD5F1GQ4xA", 0xF1, > @@ -195,25 +229,40 @@ static const struct spinand_info gigadevice_spinand_table[] = { > &write_cache_variants, > &update_cache_variants), > 0, > - SPINAND_ECCINFO(&gd5fxgq4uexxg_ooblayout, > + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, > gd5fxgq4uexxg_ecc_get_status)), > + SPINAND_INFO("GD5F1GQ4UFxxG", 0xb148, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants_f, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, > + gd5fxgq4ufxxg_ecc_get_status)), > }; > > static int gigadevice_spinand_detect(struct spinand_device *spinand) > { > u8 *id = spinand->id.data; > + u16 did; > int ret; > > /* > - * For GD NANDs, There is an address byte needed to shift in before IDs > - * are read out, so the first byte in raw_id is dummy. > + * Earlier GDF5-series devices (A,E) return [0][MID][DID] > + * Later (F) devices return [MID][DID1][DID2] > */ > - if (id[1] != SPINAND_MFR_GIGADEVICE) > + > + if (id[0] == SPINAND_MFR_GIGADEVICE) > + did = (id[1] << 8) + id[2]; > + else if (id[0] == 0 && id[1] == SPINAND_MFR_GIGADEVICE) > + did = id[2]; > + else > return 0; > > ret = spinand_match_and_init(spinand, gigadevice_spinand_table, > ARRAY_SIZE(gigadevice_spinand_table), > - id[2]); > + did); > if (ret) > return ret; > > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG @ 2019-05-15 6:53 ` Schrempf Frieder 0 siblings, 0 replies; 25+ messages in thread From: Schrempf Frieder @ 2019-05-15 6:53 UTC (permalink / raw) To: Jeff Kletsky, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org On 14.05.19 23:53, Jeff Kletsky wrote: > From: Jeff Kletsky <git-commits@allycomm.com> > > The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices > and, while it has the same logical layout as the E-series devices, > it differs in the SPI interfacing in significant ways. > > This support is contingent on previous commits to: > > * Add support for two-byte device IDs > * Add #define-s for page-read ops with three-byte addresses > > http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > > Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > drivers/mtd/nand/spi/gigadevice.c | 79 +++++++++++++++++++++++++------ > 1 file changed, 64 insertions(+), 15 deletions(-) > > diff --git a/drivers/mtd/nand/spi/gigadevice.c b/drivers/mtd/nand/spi/gigadevice.c > index 0b49d8264bef..d6497ac4c5d8 100644 > --- a/drivers/mtd/nand/spi/gigadevice.c > +++ b/drivers/mtd/nand/spi/gigadevice.c > @@ -9,11 +9,17 @@ > #include <linux/mtd/spinand.h> > > #define SPINAND_MFR_GIGADEVICE 0xC8 > + > #define GD5FXGQ4XA_STATUS_ECC_1_7_BITFLIPS (1 << 4) > #define GD5FXGQ4XA_STATUS_ECC_8_BITFLIPS (3 << 4) > > #define GD5FXGQ4UEXXG_REG_STATUS2 0xf0 > > +#define GD5FXGQ4UXFXXG_STATUS_ECC_MASK (7 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS (0 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS (1 << 4) > +#define GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR (7 << 4) > + > static SPINAND_OP_VARIANTS(read_cache_variants, > SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > @@ -22,6 +28,14 @@ static SPINAND_OP_VARIANTS(read_cache_variants, > SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); > > +static SPINAND_OP_VARIANTS(read_cache_variants_f, > + SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP_3A(false, 0, 0, NULL, 0)); > + > static SPINAND_OP_VARIANTS(write_cache_variants, > SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), > SPINAND_PROG_LOAD(true, 0, NULL, 0)); > @@ -59,6 +73,11 @@ static int gd5fxgq4xa_ooblayout_free(struct mtd_info *mtd, int section, > return 0; > } > > +static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { > + .ecc = gd5fxgq4xa_ooblayout_ecc, > + .free = gd5fxgq4xa_ooblayout_free, > +}; > + > static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > @@ -83,7 +102,7 @@ static int gd5fxgq4xa_ecc_get_status(struct spinand_device *spinand, > return -EINVAL; > } > > -static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, > +static int gd5fxgq4_variant2_ooblayout_ecc(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section) > @@ -95,7 +114,7 @@ static int gd5fxgq4uexxg_ooblayout_ecc(struct mtd_info *mtd, int section, > return 0; > } > > -static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, > +static int gd5fxgq4_variant2_ooblayout_free(struct mtd_info *mtd, int section, > struct mtd_oob_region *region) > { > if (section) > @@ -108,6 +127,11 @@ static int gd5fxgq4uexxg_ooblayout_free(struct mtd_info *mtd, int section, > return 0; > } > > +static const struct mtd_ooblayout_ops gd5fxgq4_variant2_ooblayout = { > + .ecc = gd5fxgq4_variant2_ooblayout_ecc, > + .free = gd5fxgq4_variant2_ooblayout_free, > +}; > + > static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, > u8 status) > { > @@ -150,15 +174,25 @@ static int gd5fxgq4uexxg_ecc_get_status(struct spinand_device *spinand, > return -EINVAL; > } > > -static const struct mtd_ooblayout_ops gd5fxgq4xa_ooblayout = { > - .ecc = gd5fxgq4xa_ooblayout_ecc, > - .free = gd5fxgq4xa_ooblayout_free, > -}; > +static int gd5fxgq4ufxxg_ecc_get_status(struct spinand_device *spinand, > + u8 status) > +{ > + switch (status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) { > + case GD5FXGQ4UXFXXG_STATUS_ECC_NO_BITFLIPS: > + return 0; > > -static const struct mtd_ooblayout_ops gd5fxgq4uexxg_ooblayout = { > - .ecc = gd5fxgq4uexxg_ooblayout_ecc, > - .free = gd5fxgq4uexxg_ooblayout_free, > -}; > + case GD5FXGQ4UXFXXG_STATUS_ECC_1_3_BITFLIPS: > + return 3; > + > + case GD5FXGQ4UXFXXG_STATUS_ECC_UNCOR_ERROR: > + return -EBADMSG; > + > + default: /* (2 << 4) through (6 << 4) are 4-8 corrected errors */ > + return ((status & GD5FXGQ4UXFXXG_STATUS_ECC_MASK) >> 4) + 2; > + } > + > + return -EINVAL; > +} > > static const struct spinand_info gigadevice_spinand_table[] = { > SPINAND_INFO("GD5F1GQ4xA", 0xF1, > @@ -195,25 +229,40 @@ static const struct spinand_info gigadevice_spinand_table[] = { > &write_cache_variants, > &update_cache_variants), > 0, > - SPINAND_ECCINFO(&gd5fxgq4uexxg_ooblayout, > + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, > gd5fxgq4uexxg_ecc_get_status)), > + SPINAND_INFO("GD5F1GQ4UFxxG", 0xb148, > + NAND_MEMORG(1, 2048, 128, 64, 1024, 1, 1, 1), > + NAND_ECCREQ(8, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants_f, > + &write_cache_variants, > + &update_cache_variants), > + 0, > + SPINAND_ECCINFO(&gd5fxgq4_variant2_ooblayout, > + gd5fxgq4ufxxg_ecc_get_status)), > }; > > static int gigadevice_spinand_detect(struct spinand_device *spinand) > { > u8 *id = spinand->id.data; > + u16 did; > int ret; > > /* > - * For GD NANDs, There is an address byte needed to shift in before IDs > - * are read out, so the first byte in raw_id is dummy. > + * Earlier GDF5-series devices (A,E) return [0][MID][DID] > + * Later (F) devices return [MID][DID1][DID2] > */ > - if (id[1] != SPINAND_MFR_GIGADEVICE) > + > + if (id[0] == SPINAND_MFR_GIGADEVICE) > + did = (id[1] << 8) + id[2]; > + else if (id[0] == 0 && id[1] == SPINAND_MFR_GIGADEVICE) > + did = id[2]; > + else > return 0; > > ret = spinand_match_and_init(spinand, gigadevice_spinand_table, > ARRAY_SIZE(gigadevice_spinand_table), > - id[2]); > + did); > if (ret) > return ret; > > ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG 2019-05-14 21:53 ` Jeff Kletsky (?) (?) @ 2019-05-20 19:53 ` Jeff Kletsky -1 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-20 19:53 UTC (permalink / raw) To: linux-mtd This series, https://patchwork.ozlabs.org/project/linux-mtd/list/?series=107874 superseded by https://patchwork.ozlabs.org/project/linux-mtd/list/?series=108868 mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG <https://patchwork.ozlabs.org/project/linux-mtd/list/?series=108868> and marked as "superseded" in Patchwork Jeff ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <20190514212941.18794-1-lede@allycomm.com>]
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514212941.18794-1-lede@allycomm.com> @ 2019-05-14 21:29 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:29 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-14 21:29 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:29 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
[parent not found: <20190514212751.18684-1-lede@allycomm.com>]
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses [not found] <20190514212751.18684-1-lede@allycomm.com> @ 2019-05-14 21:27 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:27 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses @ 2019-05-14 21:27 ` Jeff Kletsky 0 siblings, 0 replies; 25+ messages in thread From: Jeff Kletsky @ 2019-05-14 21:27 UTC (permalink / raw) To: Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut Cc: linux-mtd, linux-kernel From: Jeff Kletsky <git-commits@allycomm.com> The GigaDevice GD5F1GQ4UFxxG SPI NAND utilizes three-byte addresses for its page-read ops. http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ Signed-off-by: Jeff Kletsky <git-commits@allycomm.com> --- include/linux/mtd/spinand.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index b92e2aa955b6..05fe98eebe27 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -68,30 +68,60 @@ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 1)) +#define SPINAND_PAGE_READ_FROM_CACHE_OP_3A(fast, addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(fast ? 0x0b : 0x03, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 1)) + #define SPINAND_PAGE_READ_FROM_CACHE_X2_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_X2_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x3b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_X4_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ SPI_MEM_OP_ADDR(2, addr, 1), \ SPI_MEM_OP_DUMMY(ndummy, 1), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_X4_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x6b, 1), \ + SPI_MEM_OP_ADDR(3, addr, 1), \ + SPI_MEM_OP_DUMMY(ndummy, 1), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ SPI_MEM_OP_ADDR(2, addr, 2), \ SPI_MEM_OP_DUMMY(ndummy, 2), \ SPI_MEM_OP_DATA_IN(len, buf, 2)) +#define SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xbb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 2), \ + SPI_MEM_OP_DUMMY(ndummy, 2), \ + SPI_MEM_OP_DATA_IN(len, buf, 2)) + #define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(addr, ndummy, buf, len) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ SPI_MEM_OP_ADDR(2, addr, 4), \ SPI_MEM_OP_DUMMY(ndummy, 4), \ SPI_MEM_OP_DATA_IN(len, buf, 4)) +#define SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP_3A(addr, ndummy, buf, len) \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0xeb, 1), \ + SPI_MEM_OP_ADDR(3, addr, 4), \ + SPI_MEM_OP_DUMMY(ndummy, 4), \ + SPI_MEM_OP_DATA_IN(len, buf, 4)) + #define SPINAND_PROG_EXEC_OP(addr) \ SPI_MEM_OP(SPI_MEM_OP_CMD(0x10, 1), \ SPI_MEM_OP_ADDR(3, addr, 1), \ -- 2.20.1 ^ permalink raw reply related [flat|nested] 25+ messages in thread
end of thread, other threads:[~2019-05-20 19:53 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190514215315.19228-1-lede@allycomm.com>
2019-05-14 21:53 ` [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses Jeff Kletsky
2019-05-14 21:53 ` Jeff Kletsky
2019-05-15 6:17 ` Marek Vasut
2019-05-15 6:17 ` Marek Vasut
2019-05-15 6:49 ` Schrempf Frieder
2019-05-15 6:49 ` Schrempf Frieder
2019-05-19 20:27 ` Jeff Kletsky
2019-05-19 20:27 ` Jeff Kletsky
2019-05-20 12:16 ` Miquel Raynal
2019-05-20 12:16 ` Miquel Raynal
2019-05-15 6:51 ` Schrempf Frieder
2019-05-15 6:51 ` Schrempf Frieder
2019-05-14 21:53 ` [PATCH v2 2/3] mtd: spinand: Add support for two-byte device IDs Jeff Kletsky
2019-05-14 21:53 ` Jeff Kletsky
2019-05-15 6:52 ` Schrempf Frieder
2019-05-15 6:52 ` Schrempf Frieder
2019-05-14 21:53 ` [PATCH v2 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG Jeff Kletsky
2019-05-14 21:53 ` Jeff Kletsky
2019-05-15 6:53 ` Schrempf Frieder
2019-05-15 6:53 ` Schrempf Frieder
2019-05-20 19:53 ` Jeff Kletsky
[not found] <20190514212941.18794-1-lede@allycomm.com>
2019-05-14 21:29 ` [PATCH v2 1/3] mtd: spinand: Add #define-s for page-read ops with three-byte addresses Jeff Kletsky
2019-05-14 21:29 ` Jeff Kletsky
[not found] <20190514212751.18684-1-lede@allycomm.com>
2019-05-14 21:27 ` Jeff Kletsky
2019-05-14 21:27 ` Jeff Kletsky
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.