grub.git fails to compiler after gnulib upgrade due to gettext

grub.git fails to compiler after gnulib upgrade due to gettext

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Since the upgrade of gnulib grub.git#master fails to compile if gettext is "too old". This also happens with configure --disable-nls:

+ bash bootstrap --gnulib-srcdir=./grub-core/lib/gnulib --skip-po --no-git --no-bootstrap-sync
bootstrap: Error: 'gettext' version == 0.17 is too old
bootstrap:        'gettext' version >= 0.18.3 is required

Is there a way to fix this before release?

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Daniel Kiper]

Hi Olaf,

On Mon, May 20, 2019 at 09:26:38PM +0200, Olaf Hering wrote:
> Since the upgrade of gnulib grub.git#master fails to compile if gettext is "too old". This also happens with configure --disable-nls:
>
> + bash bootstrap --gnulib-srcdir=./grub-core/lib/gnulib --skip-po --no-git --no-bootstrap-sync
> bootstrap: Error: 'gettext' version == 0.17 is too old
> bootstrap:        'gettext' version >= 0.18.3 is required
>
> Is there a way to fix this before release?

Could you tell us more? OS version, etc...

Daniel

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Am Tue, 21 May 2019 11:23:17 +0200
schrieb Daniel Kiper <dkiper@net-space.pl>:

> Could you tell us more? OS version, etc...

Well, SLES11. But most importantly, the old gettext. Does gettext matter at all with --disable-nls?

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Am Tue, 21 May 2019 11:32:18 +0200
schrieb Olaf Hering <olaf@aepfle.de>:

> Does gettext matter at all with --disable-nls?

It does probably not matter at all, but due to this weird code in build-aux/bootstrap it is enforced:

 grep '^[         ]*AM_GNU_GETTEXT_VERSION(' configure.ac >/dev/null || \

Maybe gnulib has just no concept of --disable-nls in the project it serves?

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Am Tue, 21 May 2019 11:49:32 +0200
schrieb Olaf Hering <olaf@aepfle.de>:

> Maybe gnulib has just no concept of --disable-nls in the project it serves?

Even if I disable the gettext checks, there is no check to enforce a new enough autoconf.
For short, the toolchain must be updated for the upcoming grub2. Both are not runtime dependencies, so it can not be considered a problem.

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Daniel Kiper]

Adding Colin who is the original author.

Colin, could you take a look at this thread?

Daniel

On Tue, May 21, 2019 at 11:32:18AM +0200, Olaf Hering wrote:
> Am Tue, 21 May 2019 11:23:17 +0200
> schrieb Daniel Kiper <dkiper@net-space.pl>:
>
> > Could you tell us more? OS version, etc...
>
> Well, SLES11. But most importantly, the old gettext. Does gettext matter at all with --disable-nls?
>
> Olaf

Re: grub.git fails to compiler after gnulib upgrade due to gettext

[Colin Watson]

On Tue, May 21, 2019 at 12:20:00PM +0200, Daniel Kiper wrote:
> On Tue, May 21, 2019 at 11:32:18AM +0200, Olaf Hering wrote:
> > Am Tue, 21 May 2019 11:23:17 +0200
> > schrieb Daniel Kiper <dkiper@net-space.pl>:
> > > Could you tell us more? OS version, etc...
> >
> > Well, SLES11. But most importantly, the old gettext. Does gettext matter at all with --disable-nls?
> 
> Adding Colin who is the original author.
> 
> Colin, could you take a look at this thread?

While gettext probably doesn't massively matter at configure time with
--disable-nls, its Autoconf macros do need to *exist* in order to build
the configure script, and we need to pick a version of those macros.
This is formally a maintainer operation and is expected to be able to
rely on reasonably current tools, so I think a version that's nearly six
years old isn't too unreasonable.  The requirement in bootstrap is
necessary in order to satisfy the version of the gettext macros that's
pinned in configure.ac (having a newer version installed is OK because
gettext ships an archive with lots of older versions of its macros, but
having an older version installed won't work).

You can apply the following patch locally to use an earlier version of
the gettext macros, but we shouldn't do this upstream because it would
mean that the configure script we distribute in tarballs would use the
older version, and hence lose out on bug fixes from the newer version.
In particular, versions of the gettext macros older than 0.18.2 don't
work with Automake >= 1.14, and since that was released in June 2013
maintainers will typically have at least that version installed when
generating tarballs.

diff --git a/bootstrap.conf b/bootstrap.conf
index 988dda099..a3193a93e 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -67,7 +67,7 @@ SKIP_PO=t
 buildreq="\
 autoconf   2.63
 automake   1.11
-gettext    0.18.3
+gettext    0.17
 git        1.5.5
 tar        -
 "
diff --git a/configure.ac b/configure.ac
index 08b518fcc..99f5b364d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -362,7 +362,7 @@ AC_CHECK_PROG(HAVE_CXX, $CXX, yes, no)
 
 AC_GNU_SOURCE
 AM_GNU_GETTEXT([external])
-AM_GNU_GETTEXT_VERSION([0.18.3])
+AM_GNU_GETTEXT_VERSION([0.17])
 AC_SYS_LARGEFILE
 
 # Identify characteristics of the host architecture.

-- 
Colin Watson                                       [cjwatson@debian.org]