From: Keith Busch <kbusch@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Busch, Keith" <keith.busch@intel.com>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 2/2] nvme: reset request timeouts during fw activation
Date: Thu, 23 May 2019 07:34:29 -0600 [thread overview]
Message-ID: <20190523133428.GC14049@localhost.localdomain> (raw)
In-Reply-To: <20190523101953.GA18805@ming.t460p>
On Thu, May 23, 2019 at 03:19:54AM -0700, Ming Lei wrote:
> On Wed, May 22, 2019 at 11:48:12AM -0600, Keith Busch wrote:
> > @@ -3605,6 +3606,11 @@ static void nvme_fw_act_work(struct work_struct *work)
> > msecs_to_jiffies(admin_timeout * 1000);
> >
> > nvme_stop_queues(ctrl);
> > + nvme_sync_queues(ctrl);
> > +
> > + blk_mq_quiesce_queue(ctrl->admin_q);
> > + blk_sync_queue(ctrl->admin_q);
>
> blk_sync_queue() may not halt timeout detection completely since the
> timeout work may reset timer again.
Doh! Didn't hit that in testing, but point taken.
> Also reset still may come during activating FW, is that a problem?
IO timeout and user initiated resets should be avoided. A state machine
addition may be useful here.
WARNING: multiple messages have this Message-ID (diff)
From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH 2/2] nvme: reset request timeouts during fw activation
Date: Thu, 23 May 2019 07:34:29 -0600 [thread overview]
Message-ID: <20190523133428.GC14049@localhost.localdomain> (raw)
In-Reply-To: <20190523101953.GA18805@ming.t460p>
On Thu, May 23, 2019@03:19:54AM -0700, Ming Lei wrote:
> On Wed, May 22, 2019@11:48:12AM -0600, Keith Busch wrote:
> > @@ -3605,6 +3606,11 @@ static void nvme_fw_act_work(struct work_struct *work)
> > msecs_to_jiffies(admin_timeout * 1000);
> >
> > nvme_stop_queues(ctrl);
> > + nvme_sync_queues(ctrl);
> > +
> > + blk_mq_quiesce_queue(ctrl->admin_q);
> > + blk_sync_queue(ctrl->admin_q);
>
> blk_sync_queue() may not halt timeout detection completely since the
> timeout work may reset timer again.
Doh! Didn't hit that in testing, but point taken.
> Also reset still may come during activating FW, is that a problem?
IO timeout and user initiated resets should be avoided. A state machine
addition may be useful here.
next prev parent reply other threads:[~2019-05-23 13:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 17:48 [PATCH 0/2] Reset timeout for paused hardware Keith Busch
2019-05-22 17:48 ` Keith Busch
2019-05-22 17:48 ` [PATCH 1/2] blk-mq: provide way to reset rq deadline Keith Busch
2019-05-22 17:48 ` Keith Busch
2019-05-22 17:48 ` [PATCH 2/2] nvme: reset request timeouts during fw activation Keith Busch
2019-05-22 17:48 ` Keith Busch
2019-05-23 10:19 ` Ming Lei
2019-05-23 10:19 ` Ming Lei
2019-05-23 13:34 ` Keith Busch [this message]
2019-05-23 13:34 ` Keith Busch
2019-05-23 14:07 ` Christoph Hellwig
2019-05-23 14:07 ` Christoph Hellwig
2019-05-22 20:20 ` [PATCH 0/2] Reset timeout for paused hardware Bart Van Assche
2019-05-22 20:20 ` Bart Van Assche
2019-05-22 20:28 ` Keith Busch
2019-05-22 20:28 ` Keith Busch
2019-05-23 10:04 ` Bart Van Assche
2019-05-23 10:04 ` Bart Van Assche
2019-05-23 3:29 ` Ming Lei
2019-05-23 3:29 ` Ming Lei
2019-05-23 3:48 ` Keith Busch
2019-05-23 3:48 ` Keith Busch
2019-05-23 10:13 ` Christoph Hellwig
2019-05-23 10:13 ` Christoph Hellwig
2019-05-23 13:23 ` Keith Busch
2019-05-23 13:23 ` Keith Busch
2019-05-23 14:10 ` Christoph Hellwig
2019-05-23 14:10 ` Christoph Hellwig
2019-05-23 14:19 ` Keith Busch
2019-05-23 14:19 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523133428.GC14049@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.