From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Xiao Yang <ice_yangxiao@163.com>
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
rcu@vger.kernel.org
Subject: Re: [PATCH] rcuperf: correct a example of perf_type
Date: Fri, 31 May 2019 12:00:25 -0700 [thread overview]
Message-ID: <20190531190025.GP28207@linux.ibm.com> (raw)
In-Reply-To: <1559315745-26570-1-git-send-email-ice_yangxiao@163.com>
On Fri, May 31, 2019 at 11:15:45PM +0800, Xiao Yang wrote:
> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types") and only four
> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
> use srcu as a example.
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
Good eyes, applied!
I edited the subject and commit log as shown below. Could you please
check to make sure that I didn't mess something up?
Thanx, Paul
------------------------------------------------------------------------
commit f499b80f236316c5f16c4d5c0d7804c258a003cb
Author: Xiao Yang <ice_yangxiao@163.com>
Date: Fri May 31 23:15:45 2019 +0800
rcuperf: Fix perf_type module-parameter description
The rcu_bh rcuperf type was removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types"), but it lives on in the
MODULE_PARM_DESC() of perf_type. This commit therefore changes that
module-parameter description to substitute srcu for rcu_bh.
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b23c5f..4513807cd4c4 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@ torture_param(int, writer_holdoff, 0, "Holdoff (us) between GPs, zero to disable
static char *perf_type = "rcu";
module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
static int nrealreaders;
static int nrealwriters;
next prev parent reply other threads:[~2019-05-31 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 15:15 [PATCH] rcuperf: correct a example of perf_type Xiao Yang
2019-05-31 19:00 ` Paul E. McKenney [this message]
2019-06-01 1:52 ` Xiao Yang
-- strict thread matches above, loose matches on Subject: below --
2019-05-31 15:12 Xiao Yang
2019-05-31 15:15 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531190025.GP28207@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=ice_yangxiao@163.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.