* [PATCH] rcuperf: correct a example of perf_type
@ 2019-05-31 15:15 Xiao Yang
2019-05-31 19:00 ` Paul E. McKenney
0 siblings, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2019-05-31 15:15 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai; +Cc: rcu, Xiao Yang
rcu_bh type has been removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types") and only four
types(i.e rcu, srcu, srcud, tasks) are supported currently, so
use srcu as a example.
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
kernel/rcu/rcuperf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b..4513807 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@
static char *perf_type = "rcu";
module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
static int nrealreaders;
static int nrealwriters;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rcuperf: correct a example of perf_type
2019-05-31 15:15 [PATCH] rcuperf: correct a example of perf_type Xiao Yang
@ 2019-05-31 19:00 ` Paul E. McKenney
2019-06-01 1:52 ` Xiao Yang
0 siblings, 1 reply; 5+ messages in thread
From: Paul E. McKenney @ 2019-05-31 19:00 UTC (permalink / raw)
To: Xiao Yang; +Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, rcu
On Fri, May 31, 2019 at 11:15:45PM +0800, Xiao Yang wrote:
> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types") and only four
> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
> use srcu as a example.
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
Good eyes, applied!
I edited the subject and commit log as shown below. Could you please
check to make sure that I didn't mess something up?
Thanx, Paul
------------------------------------------------------------------------
commit f499b80f236316c5f16c4d5c0d7804c258a003cb
Author: Xiao Yang <ice_yangxiao@163.com>
Date: Fri May 31 23:15:45 2019 +0800
rcuperf: Fix perf_type module-parameter description
The rcu_bh rcuperf type was removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types"), but it lives on in the
MODULE_PARM_DESC() of perf_type. This commit therefore changes that
module-parameter description to substitute srcu for rcu_bh.
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b23c5f..4513807cd4c4 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@ torture_param(int, writer_holdoff, 0, "Holdoff (us) between GPs, zero to disable
static char *perf_type = "rcu";
module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
static int nrealreaders;
static int nrealwriters;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rcuperf: correct a example of perf_type
2019-05-31 19:00 ` Paul E. McKenney
@ 2019-06-01 1:52 ` Xiao Yang
0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2019-06-01 1:52 UTC (permalink / raw)
To: paulmck; +Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, rcu
On 06/01/2019 03:00 AM, Paul E. McKenney wrote:
> On Fri, May 31, 2019 at 11:15:45PM +0800, Xiao Yang wrote:
>> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
>> Remove the "rcu_bh" and "sched" torture types") and only four
>> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
>> use srcu as a example.
>>
>> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> Good eyes, applied!
>
> I edited the subject and commit log as shown below. Could you please
> check to make sure that I didn't mess something up?
>
> Thanx, Paul
Hi,
Thanks for your change, and it's fine to me.
Best Regards,
Xiao Yang
>
> ------------------------------------------------------------------------
>
> commit f499b80f236316c5f16c4d5c0d7804c258a003cb
> Author: Xiao Yang <ice_yangxiao@163.com>
> Date: Fri May 31 23:15:45 2019 +0800
>
> rcuperf: Fix perf_type module-parameter description
>
> The rcu_bh rcuperf type was removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types"), but it lives on in the
> MODULE_PARM_DESC() of perf_type. This commit therefore changes that
> module-parameter description to substitute srcu for rcu_bh.
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7a6890b23c5f..4513807cd4c4 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -89,7 +89,7 @@ torture_param(int, writer_holdoff, 0, "Holdoff (us) between GPs, zero to disable
>
> static char *perf_type = "rcu";
> module_param(perf_type, charp, 0444);
> -MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
> +MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
>
> static int nrealreaders;
> static int nrealwriters;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rcuperf: correct a example of perf_type
@ 2019-05-31 15:12 Xiao Yang
2019-05-31 15:15 ` Xiao Yang
0 siblings, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2019-05-31 15:12 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai; +Cc: rcu, Xiao Yang
rcu_bh type has been removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types") and only four
types(i.e rcu, srcu, srcud, tasks) are supported currently, so
use scru as a example.
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
kernel/rcu/rcuperf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b..4513807 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@
static char *perf_type = "rcu";
module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
static int nrealreaders;
static int nrealwriters;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rcuperf: correct a example of perf_type
2019-05-31 15:12 Xiao Yang
@ 2019-05-31 15:15 ` Xiao Yang
0 siblings, 0 replies; 5+ messages in thread
From: Xiao Yang @ 2019-05-31 15:15 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai; +Cc: rcu
Hi,
Sorry, please ignore this mail because of a typo. I will resend it soon.
Best Regards,
Xiao Yang
On 05/31/2019 11:12 PM, Xiao Yang wrote:
> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types") and only four
> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
> use scru as a example.
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> ---
> kernel/rcu/rcuperf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7a6890b..4513807 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -89,7 +89,7 @@
>
> static char *perf_type = "rcu";
> module_param(perf_type, charp, 0444);
> -MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
> +MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
>
> static int nrealreaders;
> static int nrealwriters;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-01 2:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31 15:15 [PATCH] rcuperf: correct a example of perf_type Xiao Yang
2019-05-31 19:00 ` Paul E. McKenney
2019-06-01 1:52 ` Xiao Yang
-- strict thread matches above, loose matches on Subject: below --
2019-05-31 15:12 Xiao Yang
2019-05-31 15:15 ` Xiao Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.