[PATCH] rcuperf: correct a example of perf_type

[PATCH] rcuperf: correct a example of perf_type

[Xiao Yang]

rcu_bh type has been removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types") and only four
types(i.e rcu, srcu, srcud, tasks) are supported currently, so
use scru as a example.

Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
 kernel/rcu/rcuperf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b..4513807 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@
 
 static char *perf_type = "rcu";
 module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
 
 static int nrealreaders;
 static int nrealwriters;
-- 
1.8.3.1

Re: [PATCH] rcuperf: correct a example of perf_type

[Xiao Yang]

Hi,

Sorry, please ignore this mail because of a typo.  I will resend it soon.

Best Regards,

Xiao Yang

On 05/31/2019 11:12 PM, Xiao Yang wrote:
> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types") and only four
> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
> use scru as a example.
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> ---
>   kernel/rcu/rcuperf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7a6890b..4513807 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -89,7 +89,7 @@
>   
>   static char *perf_type = "rcu";
>   module_param(perf_type, charp, 0444);
> -MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
> +MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
>   
>   static int nrealreaders;
>   static int nrealwriters;

[PATCH] rcuperf: correct a example of perf_type

[Xiao Yang]

rcu_bh type has been removed by commit 620d246065cd("rcuperf:
Remove the "rcu_bh" and "sched" torture types") and only four
types(i.e rcu, srcu, srcud, tasks) are supported currently, so
use srcu as a example.

Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
 kernel/rcu/rcuperf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b..4513807 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@
 
 static char *perf_type = "rcu";
 module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
 
 static int nrealreaders;
 static int nrealwriters;
-- 
1.8.3.1

Re: [PATCH] rcuperf: correct a example of perf_type

[Paul E. McKenney]

On Fri, May 31, 2019 at 11:15:45PM +0800, Xiao Yang wrote:
> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
> Remove the "rcu_bh" and "sched" torture types") and only four
> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
> use srcu as a example.
> 
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>

Good eyes, applied!

I edited the subject and commit log as shown below.  Could you please
check to make sure that I didn't mess something up?

							Thanx, Paul

------------------------------------------------------------------------

commit f499b80f236316c5f16c4d5c0d7804c258a003cb
Author: Xiao Yang <ice_yangxiao@163.com>
Date:   Fri May 31 23:15:45 2019 +0800

    rcuperf: Fix perf_type module-parameter description
    
    The rcu_bh rcuperf type was removed by commit 620d246065cd("rcuperf:
    Remove the "rcu_bh" and "sched" torture types"), but it lives on in the
    MODULE_PARM_DESC() of perf_type.  This commit therefore changes that
    module-parameter description to substitute srcu for rcu_bh.
    
    Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
    Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>

diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 7a6890b23c5f..4513807cd4c4 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -89,7 +89,7 @@ torture_param(int, writer_holdoff, 0, "Holdoff (us) between GPs, zero to disable
 
 static char *perf_type = "rcu";
 module_param(perf_type, charp, 0444);
-MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
+MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
 
 static int nrealreaders;
 static int nrealwriters;

Re: [PATCH] rcuperf: correct a example of perf_type

[Xiao Yang]

On 06/01/2019 03:00 AM, Paul E. McKenney wrote:
> On Fri, May 31, 2019 at 11:15:45PM +0800, Xiao Yang wrote:
>> rcu_bh type has been removed by commit 620d246065cd("rcuperf:
>> Remove the "rcu_bh" and "sched" torture types") and only four
>> types(i.e rcu, srcu, srcud, tasks) are supported currently, so
>> use srcu as a example.
>>
>> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> Good eyes, applied!
>
> I edited the subject and commit log as shown below.  Could you please
> check to make sure that I didn't mess something up?
>
> 							Thanx, Paul
Hi,

Thanks for your change, and it's fine to me.

Best Regards,
Xiao Yang
>
> ------------------------------------------------------------------------
>
> commit f499b80f236316c5f16c4d5c0d7804c258a003cb
> Author: Xiao Yang <ice_yangxiao@163.com>
> Date:   Fri May 31 23:15:45 2019 +0800
>
>      rcuperf: Fix perf_type module-parameter description
>      
>      The rcu_bh rcuperf type was removed by commit 620d246065cd("rcuperf:
>      Remove the "rcu_bh" and "sched" torture types"), but it lives on in the
>      MODULE_PARM_DESC() of perf_type.  This commit therefore changes that
>      module-parameter description to substitute srcu for rcu_bh.
>      
>      Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
>      Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
>
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7a6890b23c5f..4513807cd4c4 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -89,7 +89,7 @@ torture_param(int, writer_holdoff, 0, "Holdoff (us) between GPs, zero to disable
>   
>   static char *perf_type = "rcu";
>   module_param(perf_type, charp, 0444);
> -MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, rcu_bh, ...)");
> +MODULE_PARM_DESC(perf_type, "Type of RCU to performance-test (rcu, srcu, ...)");
>   
>   static int nrealreaders;
>   static int nrealwriters;