All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Troy Benjegerdes <troy.benjegerdes@sifive.com>
Cc: "Dany Nativel" <dany.nativel@sifive.com>,
	"Andreas Schwab" <schwab@suse.de>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	u-boot <U-Boot@lists.denx.de>,
	"Björn Töpel" <bjorn.topel@gmail.com>,
	"Karsten Merker" <merker@debian.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>
Subject: Re: [U-Boot] Distro bootcmd: Re: 5.2-rc1 boot on Unleashed
Date: Mon, 3 Jun 2019 13:02:57 -0400	[thread overview]
Message-ID: <20190603170257.GF7705@bill-the-cat> (raw)
In-Reply-To: <8D6E3ACE-7AA9-49F9-BF35-15777E7D47CF@sifive.com>


[-- Attachment #1.1: Type: text/plain, Size: 2563 bytes --]

On Mon, Jun 03, 2019 at 09:44:28AM -0500, Troy Benjegerdes wrote:
> 
> 
> > On Jun 3, 2019, at 5:49 AM, Andreas Schwab <schwab@suse.de> wrote:
> > 
> > On Mai 29 2019, Karsten Merker <merker@debian.org> wrote:
> > 
> >> Mainline U-Boot already uses the distro bootcmd environment for
> >> the qemu "virt" machine and it works well.
> > 
> > The distro_bootcmd doesn't work for the sifive platform yet because it
> > doesn't set the correct MAC address for booting.
> > 
> > Andreas.
> > 
> 
> Before we go an use distro_bootcmd and drag in a bunch of legacy stuff 
> we really should not be using, can we make some kind of effort to decide
> what the design goals and boot flow should look like instead using the 
> default legacy behavior of a bunch of hard to read and maintain CPP
> macros?

I feel like you're calling "what everyone agreed on and uses today"
legacy just because it already exists.  It is a bit complex because
devices are so complex, rather than it having to support one-off
situations or similar things people usually call "legacy".

> The first thing I notice is that the default dhcp target is ‘boot.scr.uimg’.
> 
> What good does it do linux distros on RiscV to keep using the old boot
> script format, rather than just load a text file and use ‘env import’? Is there
> some benefit to this? Do we gain something from the .scr format, like
> maybe cryptographic signature support?

Writing things out in script format ends up being more natural (and
easier to understand) than writing things out in environment format.
This is why while I wish the "uEnv.txt" hook had become more popular and
widely used, at this point I also understand why it wasn't.  Doing
a=foo
b=bar
c=baz
magic_name=do this;do that

Was not easier nor more understandable than:
setenv a foo
setenv b bar
setenv c baz
do this; do that

> How do we want to support secure boot into Debian, Fedora, and Suse,
> and does distro_bootcmd have a way to do this, or can we come up with
> some improvement that doesn’t depend on trying to do all the work in
> CPP macros and U-boot runtime scripts?

I think the general answer about "secure boot" is that distros want
"UEFI secure boot".  And I want to make sure that's done in such a way
that things like user-owned secure boot aren't any more difficult than
vendor secured boot.  It seems like making use of existing secure boot
mechanisms has set aside as, well, I don't want to throw snark around
myself, so I'll refrain from speculating.

-- 
Tom

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Distro bootcmd: Re: 5.2-rc1 boot on Unleashed
Date: Mon, 3 Jun 2019 13:02:57 -0400	[thread overview]
Message-ID: <20190603170257.GF7705@bill-the-cat> (raw)
In-Reply-To: <8D6E3ACE-7AA9-49F9-BF35-15777E7D47CF@sifive.com>

On Mon, Jun 03, 2019 at 09:44:28AM -0500, Troy Benjegerdes wrote:
> 
> 
> > On Jun 3, 2019, at 5:49 AM, Andreas Schwab <schwab@suse.de> wrote:
> > 
> > On Mai 29 2019, Karsten Merker <merker@debian.org> wrote:
> > 
> >> Mainline U-Boot already uses the distro bootcmd environment for
> >> the qemu "virt" machine and it works well.
> > 
> > The distro_bootcmd doesn't work for the sifive platform yet because it
> > doesn't set the correct MAC address for booting.
> > 
> > Andreas.
> > 
> 
> Before we go an use distro_bootcmd and drag in a bunch of legacy stuff 
> we really should not be using, can we make some kind of effort to decide
> what the design goals and boot flow should look like instead using the 
> default legacy behavior of a bunch of hard to read and maintain CPP
> macros?

I feel like you're calling "what everyone agreed on and uses today"
legacy just because it already exists.  It is a bit complex because
devices are so complex, rather than it having to support one-off
situations or similar things people usually call "legacy".

> The first thing I notice is that the default dhcp target is ‘boot.scr.uimg’.
> 
> What good does it do linux distros on RiscV to keep using the old boot
> script format, rather than just load a text file and use ‘env import’? Is there
> some benefit to this? Do we gain something from the .scr format, like
> maybe cryptographic signature support?

Writing things out in script format ends up being more natural (and
easier to understand) than writing things out in environment format.
This is why while I wish the "uEnv.txt" hook had become more popular and
widely used, at this point I also understand why it wasn't.  Doing
a=foo
b=bar
c=baz
magic_name=do this;do that

Was not easier nor more understandable than:
setenv a foo
setenv b bar
setenv c baz
do this; do that

> How do we want to support secure boot into Debian, Fedora, and Suse,
> and does distro_bootcmd have a way to do this, or can we come up with
> some improvement that doesn’t depend on trying to do all the work in
> CPP macros and U-boot runtime scripts?

I think the general answer about "secure boot" is that distros want
"UEFI secure boot".  And I want to make sure that's done in such a way
that things like user-owned secure boot aren't any more difficult than
vendor secured boot.  It seems like making use of existing secure boot
mechanisms has set aside as, well, I don't want to throw snark around
myself, so I'll refrain from speculating.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190603/5e79b636/attachment.sig>

  reply	other threads:[~2019-06-03 17:03 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 23:31 5.2-rc1 boot on Unleashed Atish Patra
2019-05-21  9:40 ` Andreas Schwab
2019-05-21 18:14   ` Atish Patra
2019-05-22  7:31     ` Andreas Schwab
2019-05-22  8:40     ` Andreas Schwab
2019-05-22  9:58     ` Andreas Schwab
2019-05-22 21:13       ` Paul Walmsley
2019-05-21 17:47 ` Kevin Hilman
2019-05-21 18:18   ` Atish Patra
2019-05-23  9:42     ` Andreas Schwab
2019-05-22  4:42 ` Sagar Kadam
2019-05-22  9:51   ` Atish Patra
2019-05-22 16:42 ` Paul Walmsley
2019-05-22 17:38   ` Atish Patra
2019-05-22 20:43     ` Paul Walmsley
2019-05-22 22:14       ` Troy Benjegerdes
2019-05-25  8:06         ` Anup Patel
2019-05-25 14:16           ` Troy Benjegerdes
2019-05-29  5:00             ` Anup Patel
2019-05-29  8:31               ` Andreas Schwab
2019-05-29 17:38                 ` Troy Benjegerdes
2019-05-29 18:59                   ` Karsten Merker
2019-05-30 17:00                     ` Palmer Dabbelt
2019-06-03 10:49                     ` Andreas Schwab
2019-06-03 14:44                       ` Distro bootcmd: " Troy Benjegerdes
2019-06-03 14:44                         ` [U-Boot] " Troy Benjegerdes
2019-06-03 17:02                         ` Tom Rini [this message]
2019-06-03 17:02                           ` Tom Rini
2019-06-03 19:17                           ` Palmer Dabbelt
2019-06-03 19:17                             ` Palmer Dabbelt
2019-06-03 19:32                             ` Tom Rini
2019-06-03 19:32                               ` Tom Rini
2019-06-03 19:47                           ` Troy Benjegerdes
2019-06-03 19:47                             ` Troy Benjegerdes
2019-05-24  0:23       ` Troy Benjegerdes
2019-05-24  3:59         ` Atish Patra
2019-05-24 14:46           ` Troy Benjegerdes
2019-05-24 15:35             ` Auer, Lukas
2019-05-24 16:01               ` Troy Benjegerdes
2019-05-24 17:40                 ` Atish Patra
     [not found]                   ` <CAF5mof3_PSwpsSMnjMALpfvmOPdeAgDLa2p6jp4y+Hmas83mbw@mail.gmail.com>
2019-05-24 21:34                     ` Auer, Lukas
2019-05-25  3:49                       ` Anup Patel
2019-05-25 16:23                         ` Troy Benjegerdes
2019-05-25 18:09             ` Paul Walmsley
2019-05-25 18:40               ` Troy Benjegerdes
2019-05-27 12:21                 ` Andreas Schwab
2019-05-27 16:51                   ` Troy Benjegerdes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603170257.GF7705@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=U-Boot@lists.denx.de \
    --cc=bjorn.topel@gmail.com \
    --cc=dany.nativel@sifive.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=merker@debian.org \
    --cc=palmer@sifive.com \
    --cc=schwab@suse.de \
    --cc=troy.benjegerdes@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.