From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Chen-Yu Tsai <wens@kernel.org>,
Vincent Donnefort <vdonnefort@gmail.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>
Subject: [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method
Date: Tue, 4 Jun 2019 12:23:35 +0800 [thread overview]
Message-ID: <20190604042337.26129-2-wens@kernel.org> (raw)
In-Reply-To: <20190604042337.26129-1-wens@kernel.org>
From: Chen-Yu Tsai <wens@csie.org>
The PCF8563 datasheet says the interrupt line is active low and stays
active until the events are cleared, i.e. a level trigger interrupt.
Fix the flags used to request the interrupt.
Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Not sure if this would cause issues for other platforms. Ideally we'd
take the flags from the device tree, but it seems not all platforms
support this.
---
drivers/rtc/rtc-pcf8563.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 3efc86c25d27..e358313466f1 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client,
if (client->irq > 0) {
err = devm_request_threaded_irq(&client->dev, client->irq,
NULL, pcf8563_irq,
- IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING,
+ IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW,
pcf8563_driver.driver.name, client);
if (err) {
dev_err(&client->dev, "unable to request IRQ %d\n",
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Chen-Yu Tsai <wens@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method
Date: Tue, 4 Jun 2019 12:23:35 +0800 [thread overview]
Message-ID: <20190604042337.26129-2-wens@kernel.org> (raw)
In-Reply-To: <20190604042337.26129-1-wens@kernel.org>
From: Chen-Yu Tsai <wens@csie.org>
The PCF8563 datasheet says the interrupt line is active low and stays
active until the events are cleared, i.e. a level trigger interrupt.
Fix the flags used to request the interrupt.
Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Not sure if this would cause issues for other platforms. Ideally we'd
take the flags from the device tree, but it seems not all platforms
support this.
---
drivers/rtc/rtc-pcf8563.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 3efc86c25d27..e358313466f1 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client,
if (client->irq > 0) {
err = devm_request_threaded_irq(&client->dev, client->irq,
NULL, pcf8563_irq,
- IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING,
+ IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW,
pcf8563_driver.driver.name, client);
if (err) {
dev_err(&client->dev, "unable to request IRQ %d\n",
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Chen-Yu Tsai <wens@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method
Date: Tue, 4 Jun 2019 12:23:35 +0800 [thread overview]
Message-ID: <20190604042337.26129-2-wens@kernel.org> (raw)
In-Reply-To: <20190604042337.26129-1-wens@kernel.org>
From: Chen-Yu Tsai <wens@csie.org>
The PCF8563 datasheet says the interrupt line is active low and stays
active until the events are cleared, i.e. a level trigger interrupt.
Fix the flags used to request the interrupt.
Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Not sure if this would cause issues for other platforms. Ideally we'd
take the flags from the device tree, but it seems not all platforms
support this.
---
drivers/rtc/rtc-pcf8563.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
index 3efc86c25d27..e358313466f1 100644
--- a/drivers/rtc/rtc-pcf8563.c
+++ b/drivers/rtc/rtc-pcf8563.c
@@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client,
if (client->irq > 0) {
err = devm_request_threaded_irq(&client->dev, client->irq,
NULL, pcf8563_irq,
- IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING,
+ IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW,
pcf8563_driver.driver.name, client);
if (err) {
dev_err(&client->dev, "unable to request IRQ %d\n",
--
2.20.1
next prev parent reply other threads:[~2019-06-04 4:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 4:23 [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Chen-Yu Tsai
2019-06-04 4:23 ` Chen-Yu Tsai
2019-06-04 4:23 ` Chen-Yu Tsai [this message]
2019-06-04 4:23 ` [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method Chen-Yu Tsai
2019-06-04 4:23 ` Chen-Yu Tsai
2019-06-20 18:36 ` Alexandre Belloni
2019-06-20 18:36 ` Alexandre Belloni
2019-06-04 4:23 ` [PATCH 2/3] rtc: pcf8563: Clear event flags and disable interrupts before requesting irq Chen-Yu Tsai
2019-06-04 4:23 ` Chen-Yu Tsai
2019-06-20 18:37 ` Alexandre Belloni
2019-06-20 18:37 ` Alexandre Belloni
2019-06-04 4:23 ` [PATCH 3/3] arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC Chen-Yu Tsai
2019-06-04 4:23 ` Chen-Yu Tsai
2019-06-20 16:22 ` [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Alexandre Belloni
2019-06-20 16:22 ` Alexandre Belloni
2019-06-24 10:34 ` Chen-Yu Tsai
2019-06-24 10:34 ` Chen-Yu Tsai
2019-06-24 10:42 ` Alexandre Belloni
2019-06-24 10:42 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604042337.26129-2-wens@kernel.org \
--to=wens@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=vdonnefort@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.